Skip to contentSkip to conversation

net: stmmac: change Kconfig menu entry to STMMAC/DWMAC

PATCH In review Johan Jonker 2 participants 3 messages Jun 26, 2020

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 net: stmmac: change Kconfig menu entry to STMMAC/DWMAC

When a Rockchip user wants to enable support for the ethernet controller one has to search for something with STMicroelectronics.
Change the Kconfig menu entry to STMMAC/DWMAC, so that it better reflects the options it enables.

---
 drivers/net/ethernet/stmicro/stmmac/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/stmicro/stmmac/Kconfig +2 -2
index 36bd2e18f..8f7625cc8 100644
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config STMMAC_ETH
-	tristate "STMicroelectronics Multi-Gigabit Ethernet driver"
+	tristate "STMMAC/DWMAC Multi-Gigabit Ethernet driver"
 	depends on HAS_IOMEM && HAS_DMA
 	select MII
 	select MDIO_XPCS
@@ -26,7 +26,7 @@ config STMMAC_SELFTESTS
 	  results to the netdev Mailing List.
 
 config STMMAC_PLATFORM
-	tristate "STMMAC Platform bus support"
+	tristate "STMMAC/DWMAC Platform bus support"
 	depends on STMMAC_ETH
 	select MFD_SYSCON
 	default y
Signature · 1 line
2.11.0
#1 lore raw

PATCH 2/2 net: stmmac: add Rockchip as supported platform in STMMAC_PLATFORM help text

The Kconfig menu has an option for DWMAC_ROCKCHIP. Then add Rockchip also as supported platform in the help text of STMMAC_PLATFORM.

---
 drivers/net/ethernet/stmicro/stmmac/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/stmicro/stmmac/Kconfig +1 -1
index 8f7625cc8..8309e05b4 100644
@@ -33,7 +33,7 @@ config STMMAC_PLATFORM
 	---help---
 	  This selects the platform specific bus support for the stmmac driver.
 	  This is the driver used on several SoCs:
-	  STi, Allwinner, Amlogic Meson, Altera SOCFPGA.
+	  STi, Allwinner, Amlogic Meson, Altera SOCFPGA, Rockchip.
 
 	  If you have a controller with this interface, say Y or M here.
 
Signature · 1 line
2.11.0
maintainer
#2 lore raw
In reply to Johan Jonker

From: Johan Jonker <[email protected]>
Date: Fri, 26 Jun 2020 14:05:26 +0200

Quoted 7 lines

When a Rockchip user wants to enable support for the ethernet controller one has to search for something with STMicroelectronics.
Change the Kconfig menu entry to STMMAC/DWMAC, so that it better reflects the options it enables.

I'm not OK with this. It's called internally stmmac beause it's based upon an ST Microelectronics chipset.

This is what happens when we have several sub drivers based upon a top-level common chipset "library".

The problem you have is that just knowing the driver doesn't tell you the dependencies, but that's a larger scope generic problem that needs a high level solution rather then something we should be hacking around with name adjustments here and there.