Skip to contentSkip to conversation

New man page corrections - encryption-options.rst

PATCH In review Richard Bonhomme 3 participants 4 messages Jun 26, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 New man page corrections - encryption-options.rst

---
 doc/man-sections/encryption-options.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
doc/man-sections/encryption-options.rst +4 -4
index 42c80eb8..076b5fd3 100644
@@ -86,5 +86,5 @@ Generating key material
 
   * Generating *TLS Crypt v2 Server key*
-    Generate a ``--tls-crypt-v2`` key tp be used by an OpenVPN server.
+    Generate a ``--tls-crypt-v2`` key to be used by an OpenVPN server.
     The key is stored in ``keyfile``.
 
@@ -127,7 +127,7 @@ Generating key material
 
     *Note:*
-       This file should be kept secret to the server as anyone that
-       access to this file will be to generate auth tokens that the OpenVPN
-       server will accept as valid.
+       This file should be kept secret to the server as anyone that has
+       access to this file will be able to generate auth tokens that the
+       OpenVPN server will accept as valid.
 
 .. include:: renegotiation.rst
Signature · 1 line
2.17.1
#1 lore raw

Comment inline:

Quoted 17 lines · Richard Bonhomme
---
  doc/man-sections/encryption-options.rst | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
doc/man-sections/encryption-options.rst +1 -1
index 42c80eb8..076b5fd3 100644
@@ -86,5 +86,5 @@ Generating key material
 
    * Generating *TLS Crypt v2 Server key*
-    Generate a ``--tls-crypt-v2`` key tp be used by an OpenVPN server.
+    Generate a ``--tls-crypt-v2`` key to be used by an OpenVPN server.
      The key is stored in ``keyfile``.
 

doc/man-sections/encryption-options.rst Generating key material · line 129

Quoted 6 lines
doc/man-sections/encryption-options.rst +1 -3
@@ -127,7 +127,7 @@ Generating key material
 
      *Note:*
-       This file should be kept secret to the server as anyone that
-       access to this file will be to generate auth tokens that the OpenVPN
-       server will accept as valid.
+       This file should be kept secret to the server as anyone that has

I don't know if this is correct or if it should read:
This file should be kept secret from the server ..

Quoted 5 lines
doc/man-sections/encryption-options.rst +2 -0
+       access to this file will be able to generate auth tokens that the
+       OpenVPN server will accept as valid.
 
  .. include:: renegotiation.rst
#2 lore raw

Am 26.06.20 um 16:34 schrieb tincanteksup:

Quoted 20 lines

Comment inline:

Quoted 17 lines · Richard Bonhomme

---
  doc/man-sections/encryption-options.rst | 8 ++++----

  1 file changed, 4 insertions(+), 4 deletions(-)
doc/man-sections/encryption-options.rst +1 -1
index 42c80eb8..076b5fd3 100644
@@ -86,5 +86,5 @@ Generating key material
       * Generating *TLS Crypt v2 Server key*
-    Generate a ``--tls-crypt-v2`` key tp be used by an OpenVPN server.
+    Generate a ``--tls-crypt-v2`` key to be used by an OpenVPN server.

      The key is stored in ``keyfile``.
  @@ -127,7 +127,7 @@ Generating key material
        *Note:*

Quoted 8 lines
Quoted 5 lines

-       This file should be kept secret to the server as anyone that -       access to this file will be to generate auth tokens that the OpenVPN
-       server will accept as valid.
+       This file should be kept secret to the server as anyone that has

I don't know if this is correct or if it should read:
       This file should be kept secret from the server ..

No, it is correct but maybe not correct English. Basically I wanted to say that the file should be only kept on the server and not anywhere else like a private server key.

Quoted 11 lines
Quoted 5 lines

+       access to this file will be able to generate auth tokens that the +       OpenVPN server will accept as valid.
    .. include:: renegotiation.rst

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

#3 lore raw
In reply to tincanteksup
Quoted 19 lines · tincanteksup

Comment inline:

Quoted 16 lines · Richard Bonhomme

---
  doc/man-sections/encryption-options.rst | 8 ++++----

  1 file changed, 4 insertions(+), 4 deletions(-)
doc/man-sections/encryption-options.rst +1 -1
index 42c80eb8..076b5fd3 100644
@@ -86,5 +86,5 @@ Generating key material
       * Generating *TLS Crypt v2 Server key*
-    Generate a ``--tls-crypt-v2`` key tp be used by an OpenVPN server.
+    Generate a ``--tls-crypt-v2`` key to be used by an OpenVPN server.

      The key is stored in ``keyfile``.
  @@ -127,7 +127,7 @@ Generating key material

Quoted 8 lines
Quoted 5 lines

        *Note:*
-       This file should be kept secret to the server as anyone that -       access to this file will be to generate auth tokens that the OpenVPN -       server will accept as valid.
+       This file should be kept secret to the server as anyone that has

I don't know if this is correct or if it should read:
       This file should be kept secret from the server ..

It wouldn't make sense to keep a (shared) private key used for encryption "secret from the server"; that would make it a bit difficult to use :)

I think what was meant was:

"This file should be kept secret *on* the server ..."

Signature · 4 lines
kind regards,

David Sommerseth
OpenVPN Inc