Revert "drm/amd/display: Expose connector VRR range via debugfs"
Subsystems (3)
PATCH v4 1/1 Revert "drm/amd/display: Expose connector VRR range via debugfs"
From: Bhanuprakash Modem <[email protected]>
v3:
* Rebase (Manasi)
v2:
* Rebase (Manasi)
As both VRR min and max are already part of drm_display_info, drm can expose this VRR range for each connector.
Hence this logic should move to core DRM.
This reverts commit 727962f030c23422a01e8b22d0f463815fb15ec4.
--- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 20 ------------------- 1 file changed, 20 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c +0 -20
@@ -820,24 +820,6 @@ static int output_bpc_show(struct seq_file *m, void *data)return res; } -/* -* Returns the min and max vrr vfreq through the connector's debugfs file. -* Example usage: cat /sys/kernel/debug/dri/0/DP-1/vrr_range -*/ -static int vrr_range_show (struct seq_file *m,void *data) -{ -struct drm_connector *connector = m->private; -struct amdgpu_dm_connector *aconnector =to_amdgpu_dm_connector (connector); - -if (connector->status != connector_status_connected) -return -ENODEV ; - -seq_printf (m,"Min: %u\n" , (unsigned int )aconnector->min_vfreq); -seq_printf (m,"Max: %u\n" , (unsigned int )aconnector->max_vfreq); - -return 0 ; -} -#ifdef CONFIG_DRM_AMD_DC_HDCP /* * Returns the HDCP capability of the Display (1.4 for now).
@@ -1001,7 +983,6 @@ static ssize_t dp_dpcd_data_read(struct file *f, char __user *buf,DEFINE_SHOW_ATTRIBUTE (dmub_fw_state);DEFINE_SHOW_ATTRIBUTE (dmub_tracebuffer);DEFINE_SHOW_ATTRIBUTE (output_bpc); -DEFINE_SHOW_ATTRIBUTE (vrr_range);#ifdef CONFIG_DRM_AMD_DC_HDCP DEFINE_SHOW_ATTRIBUTE (hdcp_sink_capability);#endif
@@ -1058,7 +1039,6 @@ static const struct { {"link_settings", &dp_link_settings_debugfs_fops}, {"phy_settings", &dp_phy_settings_debugfs_fop}, {"test_pattern", &dp_phy_test_pattern_fops}, - {"vrr_range", &vrr_range_fops}, #ifdef CONFIG_DRM_AMD_DC_HDCP {"hdcp_sink_capability", &hdcp_sink_capability_fops}, #endif
Signature · 6 lines
2.19.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Alex Deucher
AppliedQuoted 15 lines · Manasi Navare
From: Bhanuprakash Modem <[email protected]>
v3:
* Rebase (Manasi)
v2:
* Rebase (Manasi)As both VRR min and max are already part of
drm_display_info, drm can expose this VRR range for each connector.Hence this logic should move to core DRM.
This reverts commit
727962f030c23422a01e8b22d0f463815fb15ec4.
Quoted 7 lines
Signed-off-by Bhanuprakash Modem <[email protected]>Cc Nicholas Kazlauskas <[email protected]>Cc Harry Wentland <[email protected]>Cc Alex Deucher <[email protected]>Cc Manasi Navare <[email protected]>Cc AMD gfx <[email protected]>Reviewed-by Nicholas Kazlauskas <[email protected]>
Applied. Thanks!
Alex
Quoted 52 lines
--- .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 20 ------------------- 1 file changed, 20 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c +0
-21@@ -820,24 +820,6 @@ static int output_bpc_show(struct seq_file *m, void *data)return res; } -/* -* Returns the min and max vrr vfreq through the connector's debugfs file. -* Example usage: cat /sys/kernel/debug/dri/0/DP-1/vrr_range -*/ -static int vrr_range_show (struct seq_file *m,void *data) -{ -struct drm_connector *connector = m->private; -struct amdgpu_dm_connector *aconnector =to_amdgpu_dm_connector (connector); - -if (connector->status != connector_status_connected) -return -ENODEV ; - -seq_printf (m,"Min: %u\n" , (unsigned int )aconnector->min_vfreq); -seq_printf (m,"Max: %u\n" , (unsigned int )aconnector->max_vfreq); - -return 0 ; -} -#ifdef CONFIG_DRM_AMD_DC_HDCP /* * Returns the HDCP capability of the Display (1.4 for now). @@ -1001,7 +983,6 @@ static ssize_t dp_dpcd_data_read(struct file *f, char __user *buf,DEFINE_SHOW_ATTRIBUTE (dmub_fw_state);DEFINE_SHOW_ATTRIBUTE (dmub_tracebuffer);DEFINE_SHOW_ATTRIBUTE (output_bpc); -DEFINE_SHOW_ATTRIBUTE (vrr_range);#ifdef CONFIG_DRM_AMD_DC_HDCP DEFINE_SHOW_ATTRIBUTE (hdcp_sink_capability);#endif @@ -1058,7 +1039,6 @@ static const struct { {"link_settings", &dp_link_settings_debugfs_fops}, {"phy_settings", &dp_phy_settings_debugfs_fop}, {"test_pattern", &dp_phy_test_pattern_fops}, - {"vrr_range", &vrr_range_fops}, #ifdef CONFIG_DRM_AMD_DC_HDCP {"hdcp_sink_capability", &hdcp_sink_capability_fops}, #endif --2.19.1
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx