dt-bindings: iio: bmc150_magn: Document and fix missing compatibles
Subsystems (2)
PATCH v2 1/2 dt-bindings: iio: bmc150_magn: Document and fix missing compatibles
The driver supports also BMC156B and BMM150B but these compatibles had redundant suffix "_magn". Add existing compatibles marking them deprecated along with adding a new, proper one for this family of devices.
---
Changes since v1:
1. Mark old compatibles as deprecated, add new one.
--- .../devicetree/bindings/iio/magnetometer/bmc150_magn.txt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt +5 -1
@@ -4,7 +4,11 @@ http://ae-bst.resource.bosch.com/media/products/dokumente/bmc150/BST-BMC150-DS00 Required properties: - - compatible : should be "bosch,bmc150_magn" + - compatible : should be one of: + "bosch,bmc150_magn" + "bosch,bmc156" + "bosch,bmc156_magn" (DEPRECATED, use bosch,bmc156) + "bosch,bmm150_magn" (DEPRECATED, use bosch,bmc156) - reg : the I2C address of the magnetometer Optional properties:
Signature · 1 line
2.17.1
PATCH v2 2/2 iio: magnetometer: bmc150: Add proper compatible BMC156 and BMM150
The compatibles (except BMC150) should not have "_magn" suffix and BMC156 is compatible with BMM150 so use just one compatible.
---
Changes since v1:
1. New patch.
--- drivers/iio/magnetometer/bmc150_magn_i2c.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/iio/magnetometer/bmc150_magn_i2c.c +3 -2
@@ -57,8 +57,9 @@ MODULE_DEVICE_TABLE(i2c, bmc150_magn_i2c_id);static const struct of_device_id bmc150_magn_of_match[] = { { .compatible ="bosch,bmc150_magn" }, - { .compatible ="bosch,bmc156_magn" }, - { .compatible ="bosch,bmm150_magn" }, + { .compatible ="bosch,bmc156" }, + { .compatible ="bosch,bmc156_magn" },/* deprecated compatible */ + { .compatible ="bosch,bmm150_magn" },/* deprecated compatible */ { } };MODULE_DEVICE_TABLE (of, bmc150_magn_of_match);
Signature · 1 line
2.17.1
Jonathan Cameron
maintainerQuoted 4 lines · On Mon, 22 Jun 2020 08:01:09 +0200 Krzysztof Kozlowski <[email protected]> wrote:
The driver supports also BMC156B and BMM150B but these compatibles had redundant suffix "
_magn". Add existing compatibles marking them deprecated along with adding a new, proper one for this family of devices.
Thanks for tidying this up.
The BMC156B is a dual magnetometer and accelerometer chip so for that one the _magn postfix probably is needed.
Or am I missing something?
The way this does SPI is rather odd but seems to be the same as the bmc150 (two chips with non overlapping register maps).
Jonathan
Quoted 28 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>---
Changes since v1:
1. Mark old compatibles as deprecated, add new one.--- .../devicetree/bindings/iio/magnetometer/bmc150_magn.txt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)Documentation/devicetree/bindings/iio/magnetometer/bmc150_magn.txt +5
-1@@ -4,7 +4,11 @@ http://ae-bst.resource.bosch.com/media/products/dokumente/bmc150/BST-BMC150-DS00 Required properties: - - compatible : should be "bosch,bmc150_magn" + - compatible : should be one of: + "bosch,bmc150_magn" + "bosch,bmc156" + "bosch,bmc156_magn" (DEPRECATED, use bosch,bmc156) + "bosch,bmm150_magn" (DEPRECATED, use bosch,bmc156) - reg : the I2C address of the magnetometer Optional properties:
Quoted 9 lines · Jonathan Cameron
Quoted 4 lines · On Mon, 22 Jun 2020 08:01:09 +0200 Krzysztof Kozlowski <[email protected]> wrote:
The driver supports also BMC156B and BMM150B but these compatibles had redundant suffix "
_magn". Add existing compatibles marking them deprecated along with adding a new, proper one for this family of devices.Thanks for tidying this up.
Quoted 7 lines
The BMC156B is a dual magnetometer and accelerometer chip so for that one the
_magnpostfix probably is needed.Or am I missing something?
The way this does SPI is rather odd but seems to be the same as the bmc150 (two chips with non overlapping register maps).
You're right, only one compatible should be trimmed from suffix. I'll send v3.
Best regards,
Krzysztof