Skip to contentSkip to conversation

staging: rtl8188eu: remove unnecessary comments in hal8188e_phy_cfg.h

PATCH Superseded Michael Straube 2 participants 2 messages Jun 27, 2020 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8188eu: remove unnecessary comments in hal8188e_phy_cfg.h

Remove unnecessary comments in hal8188e_phy_cfg.h to improve readability and clear multiple blank lines checkpatch issues.

CHECK: Please don't use multiple blank lines

---
 .../rtl8188eu/include/hal8188e_phy_cfg.h      | 23 -------------------
 1 file changed, 23 deletions(-)
drivers/staging/rtl8188eu/include/hal8188e_phy_cfg.h +0 -23
index 0c5b2b0948f5..78b44bf55f28 100644
@@ -7,8 +7,6 @@
 #ifndef __INC_HAL8188EPHYCFG_H__
 #define __INC_HAL8188EPHYCFG_H__
 
-
-/*--------------------------Define Parameters-------------------------------*/
 #define LOOP_LIMIT			5
 #define MAX_STALL_TIME			50		/* us */
 #define AntennaDiversityValue		0x80
@@ -17,11 +15,6 @@
 
 #define MAX_AGGR_NUM			0x07
 
-
-/*--------------------------Define Parameters-------------------------------*/
-
-
-/*------------------------------Define structure----------------------------*/
 enum sw_chnl_cmd_id {
 	CmdID_End,
 	CmdID_SetTxPowerLevel,
@@ -145,21 +138,7 @@ struct bb_reg_def {
 				 */
 };
 
-/*------------------------------Define structure----------------------------*/
-
-
-/*------------------------Export global variable----------------------------*/
-/*------------------------Export global variable----------------------------*/
-
-
-/*------------------------Export Marco Definition---------------------------*/
-/*------------------------Export Marco Definition---------------------------*/
-
-
-/*--------------------------Exported Function prototype---------------------*/
-/*  */
 /*  BB and RF register read/write */
-/*  */
 
 /* Read initi reg value for tx power setting. */
 void rtl8192c_PHY_GetHWRegOriginalValue(struct adapter *adapter);
@@ -181,8 +160,6 @@ void PHY_EnableHostClkReq(struct adapter *adapter);
 
 bool SetAntennaConfig92C(struct adapter *adapter, u8 defaultant);
 
-/*--------------------------Exported Function prototype---------------------*/
-
 #define PHY_SetMacReg	PHY_SetBBReg
 
 #define	SIC_HW_SUPPORT			0
Signature · 1 line
2.27.0
#1 lore raw
Quoted 8 lines · Michael Straube
drivers/staging/rtl8188eu/include/hal8188e_phy_cfg.h +0 -4
@@ -145,21 +138,7 @@ struct bb_reg_def {
 				 */
 };
 
-/*------------------------------Define structure----------------------------*/
-
-
-/*------------------------Export global variable----------------------------*/

drivers/staging/rtl8188eu/include/hal8188e_phy_cfg.h struct bb_reg_def { · line 141

Quoted 10 lines
drivers/staging/rtl8188eu/include/hal8188e_phy_cfg.h +0 -9
-/*------------------------Export global variable----------------------------*/
-
-
-/*------------------------Export Marco Definition---------------------------*/
-/*------------------------Export Marco Definition---------------------------*/
-
-
-/*--------------------------Exported Function prototype---------------------*/
-/*  */
 /*  BB and RF register read/write */

You can probably delete this line as well. ;)

drivers/staging/rtl8188eu/include/hal8188e_phy_cfg.h struct bb_reg_def { · line 144

Quoted 4 lines
drivers/staging/rtl8188eu/include/hal8188e_phy_cfg.h +0 -1
-/*  */
 
 /* Read initi reg value for tx power setting. */
 void rtl8192c_PHY_GetHWRegOriginalValue(struct adapter *adapter);

regards,
dan carpenter