Skip to contentSkip to conversation

nfs-utils: systemd: nfs-server.service: Cleanup extra whitespaces

PATCH In review Salvatore Bonaccorso 2 participants 2 messages Jun 28, 2020 – Jul 17, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfs-utils: systemd: nfs-server.service: Cleanup extra whitespaces

Although whitespaces immediately before or after the "=" are ignored, removing the extra whitespaces in some of the key=value assignments makes the style more consistent.

At least since systemd v242-rc1[1] this has been clarified that whitespaces immediately before and after the "=" are allowed.

[1] https://github.com/systemd/systemd/commit/170342c90be07f418ab786718d95ef76289126a0

---
 systemd/nfs-server.service | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
systemd/nfs-server.service +7 -7
index 24118d693965..06c1adb71692 100644
@@ -1,18 +1,18 @@
 [Unit]
 Description=NFS server and services
 DefaultDependencies=no
-Requires= network.target proc-fs-nfsd.mount
-Requires= nfs-mountd.service
+Requires=network.target proc-fs-nfsd.mount
+Requires=nfs-mountd.service
 Wants=rpcbind.socket network-online.target
 Wants=rpc-statd.service nfs-idmapd.service
 Wants=rpc-statd-notify.service
 Wants=nfsdcld.service
 
-After= network-online.target local-fs.target
-After= proc-fs-nfsd.mount rpcbind.socket nfs-mountd.service
-After= nfs-idmapd.service rpc-statd.service
-After= nfsdcld.service
-Before= rpc-statd-notify.service
+After=network-online.target local-fs.target
+After=proc-fs-nfsd.mount rpcbind.socket nfs-mountd.service
+After=nfs-idmapd.service rpc-statd.service
+After=nfsdcld.service
+Before=rpc-statd-notify.service
 
 # GSS services dependencies and ordering
 Wants=auth-rpcgss-module.service
Signature · 1 line
2.27.0
#1 lore raw
Quoted 10 lines · Salvatore Bonaccorso

Although whitespaces immediately before or after the "=" are ignored, removing the extra whitespaces in some of the key=value assignments makes the style more consistent.

At least since systemd v242-rc1[1] this has been clarified that whitespaces immediately before and after the "=" are allowed.

[1] https://github.com/systemd/systemd/commit/170342c90be07f418ab786718d95ef76289126a0

Committed... (tag: nfs-utils-2-5-2-rc2)

steved.

Quoted 35 lines
---
 systemd/nfs-server.service | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
systemd/nfs-server.service +7 -7
index 24118d693965..06c1adb71692 100644
@@ -1,18 +1,18 @@
 [Unit]
 Description=NFS server and services
 DefaultDependencies=no
-Requires= network.target proc-fs-nfsd.mount
-Requires= nfs-mountd.service
+Requires=network.target proc-fs-nfsd.mount
+Requires=nfs-mountd.service
 Wants=rpcbind.socket network-online.target
 Wants=rpc-statd.service nfs-idmapd.service
 Wants=rpc-statd-notify.service
 Wants=nfsdcld.service
 
-After= network-online.target local-fs.target
-After= proc-fs-nfsd.mount rpcbind.socket nfs-mountd.service
-After= nfs-idmapd.service rpc-statd.service
-After= nfsdcld.service
-Before= rpc-statd-notify.service
+After=network-online.target local-fs.target
+After=proc-fs-nfsd.mount rpcbind.socket nfs-mountd.service
+After=nfs-idmapd.service rpc-statd.service
+After=nfsdcld.service
+Before=rpc-statd-notify.service
 
 # GSS services dependencies and ordering
 Wants=auth-rpcgss-module.service