Skip to contentSkip to conversation

lib: packing: add documentation for pbuflen argument

PATCH In review Vladimir Oltean 2 participants 2 messages Jun 28, 2020 – Jun 29, 2020

Subsystems (4)
lore
Share & tools
lore

Vladimir Oltean

author maintainer
#0 lore raw

PATCH 1/1 lib: packing: add documentation for pbuflen argument

Fixes sparse warning:

Function parameter or member 'pbuflen' not described in 'packing'

Fixes 554aae35007e ("lib: Add support for generic packing operations")

---
Hi David, since the original "packing" submission went in through your tree, could you please take this patch as well?

 lib/packing.c | 1 +
 1 file changed, 1 insertion(+)
lib/packing.c +1 -0
index 50d1e9f2f5a7..6ed72dccfdb5 100644
@@ -73,6 +73,7 @@ static void adjust_for_msb_right_quirk(u64 *to_write, int *box_start_bit,
  * @endbit: The index (in logical notation, compensated for quirks) where
  *	    the packed value ends within pbuf. Must be smaller than, or equal
  *	    to, startbit.
+ * @pbuflen: The length in bytes of the packed buffer pointed to by @pbuf.
  * @op: If PACK, then uval will be treated as const pointer and copied (packed)
  *	into pbuf, between startbit and endbit.
  *	If UNPACK, then pbuf will be treated as const pointer and the logical
Signature · 1 line
2.25.1
maintainer
#1 lore raw

From: Vladimir Oltean <[email protected]>
Date: Sun, 28 Jun 2020 17:49:35 +0300

Quoted 9 lines

Fixes sparse warning:

Function parameter or member 'pbuflen' not described in 'packing'

Fixes 554aae35007e ("lib: Add support for generic packing operations")

---
Hi David, since the original "packing" submission went in through your tree, could you please take this patch as well?

Sure, applied, thank you.