drivers/scsi/snic/snic_scsi.c:2442 snic_scsi_cleanup_iter() error: uninitialized symbol 'tag'.
PATCH 13/22 drivers/scsi/snic/snic_scsi.c:2442 snic_scsi_cleanup_iter() error: uninitialized symbol 'tag'.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git reserved-tags.v4 head: 2a2c3155f8291828f41350cf90a0c8a37cdd263c commit: 7bcbf8091de87eabb173015ba75dd6129dd61527 [13/22] snic: use tagset iter for traversing commands config: i386-randconfig-m021-20200629 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
New smatch warnings:drivers/scsi/snic/snic_scsi.c:2442 snic_scsi_cleanup_iter() error: uninitialized symbol 'tag'.
# https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git/commit/?id=7bcbf8091de87eabb173015ba75dd6129dd61527
git remote add hare-scsi-devel https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
git remote update hare-scsi-devel
git checkout 7bcbf8091de87eabb173015ba75dd6129dd61527
vim +/tag +2442 drivers/scsi/snic/snic_scsi.c
7bcbf8091de87e Hannes Reinecke 2019-03-24 2414 static bool
7bcbf8091de87e Hannes Reinecke 2019-03-24 2415 snic_scsi_cleanup_iter(struct scsi_cmnd *sc, void *data, bool rsvd)
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2416 {
7bcbf8091de87e Hannes Reinecke 2019-03-24 2417 struct snic *snic = data;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2418 struct snic_req_info *rqi = NULL;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2419 spinlock_t *io_lock = NULL;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2420 unsigned long flags;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2421 int tag;
^^^^^^^Never initialized.
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2422 u64 st_time = 0;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2423
7bcbf8091de87e Hannes Reinecke 2019-03-24 2424 io_lock = snic_io_lock_tag(snic, sc->request->tag);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2425 spin_lock_irqsave(io_lock, flags);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2426 if (unlikely(snic_tmreq_pending(sc))) {
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2427 /*
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2428 * When FW Completes reset w/o sending completions
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2429 * for outstanding ios.
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2430 */
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2431 snic_cmpl_pending_tmreq(snic, sc);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2432 spin_unlock_irqrestore(io_lock, flags);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2433
7bcbf8091de87e Hannes Reinecke 2019-03-24 2434 return true;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2435 }
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2436 rqi = (struct snic_req_info *) CMD_SP(sc);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2437 if (!rqi) {
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2438 spin_unlock_irqrestore(io_lock, flags);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2439 goto cleanup;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2440 }
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2441
c8806b6c9e824f Narsimhulu Musini 2015-05-29 @2442 SNIC_SCSI_DBG(snic->shost,
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2443 "sc_clean: sc %p, rqi %p, tag %d flags 0x%llx\n",
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2444 sc, rqi, tag, CMD_FLAGS(sc));
^^^c8806b6c9e824f Narsimhulu Musini 2015-05-29 2445
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2446 CMD_SP(sc) = NULL;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2447 CMD_FLAGS(sc) |= SNIC_SCSI_CLEANUP;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2448 spin_unlock_irqrestore(io_lock, flags);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2449 st_time = rqi->start_time;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2450
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2451 SNIC_HOST_INFO(snic->shost,
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2452 "sc_clean: Releasing rqi %p : flags 0x%llx\n",
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2453 rqi, CMD_FLAGS(sc));
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2454
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2455 snic_release_req_buf(snic, rqi, sc);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2456
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2457 cleanup:
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2458 sc->result = DID_TRANSPORT_DISRUPTED << 16;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2459 SNIC_HOST_INFO(snic->shost,
3f5c11a463fd87 Narsimhulu Musini 2016-03-17 2460 "sc_clean: DID_TRANSPORT_DISRUPTED for sc %p, Tag %d flags 0x%llx rqi %p duration %u msecs\n",
3f5c11a463fd87 Narsimhulu Musini 2016-03-17 2461 sc, sc->request->tag, CMD_FLAGS(sc), rqi,
3f5c11a463fd87 Narsimhulu Musini 2016-03-17 2462 jiffies_to_msecs(jiffies - st_time));
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2463
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2464 /* Update IO stats */
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2465 snic_stats_update_io_cmpl(&snic->s_stats);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2466
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2467 if (sc->scsi_done) {
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2468 SNIC_TRC(snic->shost->host_no, tag, (ulong) sc,
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2469 jiffies_to_msecs(jiffies - st_time), 0,
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2470 SNIC_TRC_CMD(sc),
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2471 SNIC_TRC_CMD_STATE_FLAGS(sc));
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2472
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2473 sc->scsi_done(sc);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2474 }
7bcbf8091de87e Hannes Reinecke 2019-03-24 2475 return true;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2476 }---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org