Skip to contentSkip to conversation

ARM: dts: exynos: Fix missing empty reg/ranges property regulators on Trats

PATCH Applied Krzysztof Kozlowski 3 participants 8 messages Jun 29, 2020 – Jul 7, 2020

Subsystems (2)

v1 of 2 Applied Latest is v2 →

lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH 1/3 ARM: dts: exynos: Fix missing empty reg/ranges property regulators on Trats

Remove the simple-bus compatible from a regulators node because its children do not have any unit addresses. This fixes DTC warning:

Warning (simple_bus_reg): /regulators/regulator-0: missing or empty reg/ranges property

---
 arch/arm/boot/dts/exynos4210-trats.dts | 2 --
 1 file changed, 2 deletions(-)
arch/arm/boot/dts/exynos4210-trats.dts +0 -2
index 3d791db6095c..cec413ee4490 100644
@@ -31,8 +31,6 @@
 	};
 
 	regulators {
-		compatible = "simple-bus";
-
 		vemmc_reg: regulator-0 {
 			compatible = "regulator-fixed";
 			regulator-name = "VMEM_VDD_2.8V";
Signature · 1 line
2.17.1
author maintainer
#1 lore raw

PATCH 2/3 arm64: dts: exynos: Add unit address to soc node on Exynos5433

Add @0 unit address to 'soc' node match its 'reg' property and silence DTC warning:

Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name

---

Not tested on HW.

---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/exynos/exynos5433.dtsi +1 -1
index 6721966140f4..ebe089469b5f 100644
@@ -256,7 +256,7 @@
 		cpu_on = <0xC4000003>;
 	};
 
-	soc: soc {
+	soc: soc@0 {
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
Signature · 1 line
2.17.1
Tested-by on v1 2/3
#2 lore raw

Re: [RFT 2/3] arm64: dts: exynos: Add unit address to soc node on Exynos5433

Quoted 6 lines · Krzysztof Kozlowski

Add @0 unit address to 'soc' node match its 'reg' property and silence DTC warning:

Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name

Quoted 12 lines

---

Not tested on HW.

---
  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/exynos/exynos5433.dtsi +0 -0
index 6721966140f4..ebe089469b5f 100644

arch/arm64/boot/dts/exynos/exynos5433.dtsi line 262

Quoted 8 lines
arch/arm64/boot/dts/exynos/exynos5433.dtsi +1 -1
@@ -256,7 +256,7 @@
  		cpu_on = <0xC4000003>;
  	};
 
-	soc: soc {
+	soc: soc@0 {
  		compatible = "simple-bus";
  		#address-cells = <1>;
  		#size-cells = <1>;

Best regards

Signature · 2 lines
Marek Szyprowski, PhD
Samsung R&D Institute Poland
author maintainer Applied
#3 lore raw

Re: [RFT 2/3] arm64: dts: exynos: Add unit address to soc node on Exynos5433

In reply to Krzysztof Kozlowski
Quoted 5 lines · Krzysztof Kozlowski

Add @0 unit address to 'soc' node match its 'reg' property and silence DTC warning:

Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name

Quoted 7 lines

---

Not tested on HW.

---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 +-

Applied.

Best regards,
Krzysztof

author maintainer
#4 lore raw

PATCH 3/3 arm64: dts: exynos: Add unit address to soc node and move thermal zones on Exynos7

In reply to Krzysztof Kozlowski

Add @0 unit address to 'soc' node match its 'reg' property and move the thermal zones out of 'soc' to main root as it this is usually not a property of a Soc.

This silences DTC warnings:

Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name Warning (simple_bus_reg): /soc/thermal-zones: missing or empty reg/ranges property

---

Not tested on HW.

---
 arch/arm64/boot/dts/exynos/exynos7.dtsi | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
arch/arm64/boot/dts/exynos/exynos7.dtsi +10 -10
index 300ad7326ea8..f590891efe25 100644
@@ -83,7 +83,7 @@
 		method = "smc";
 	};
 
-	soc: soc {
+	soc: soc@0 {
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
@@ -597,15 +597,6 @@
 			#thermal-sensor-cells = <0>;
 		};
 
-		thermal-zones {
-			atlas_thermal: cluster0-thermal {
-				polling-delay-passive = <0>; /* milliseconds */
-				polling-delay = <0>; /* milliseconds */
-				thermal-sensors = <&tmuctrl_0>;
-				#include "exynos7-trip-points.dtsi"
-			};
-		};
-
 		ufs: ufs@15570000 {
 			compatible = "samsung,exynos7-ufs";
 			reg = <0x15570000 0x100>,  /* 0: HCI standard */
@@ -675,6 +666,15 @@
 		};
 	};
 
+	thermal-zones {
+		atlas_thermal: cluster0-thermal {
+			polling-delay-passive = <0>; /* milliseconds */
+			polling-delay = <0>; /* milliseconds */
+			thermal-sensors = <&tmuctrl_0>;
+			#include "exynos7-trip-points.dtsi"
+		};
+	};
+
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <GIC_PPI 13
Signature · 1 line
2.17.1
author maintainer Applied
#5 lore raw

Re: [RFT 3/3] arm64: dts: exynos: Add unit address to soc node and move thermal zones on Exynos7

Quoted 9 lines · Krzysztof Kozlowski

Add @0 unit address to 'soc' node match its 'reg' property and move the thermal zones out of 'soc' to main root as it this is usually not a property of a Soc.

This silences DTC warnings:

Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name Warning (simple_bus_reg): /soc/thermal-zones: missing or empty reg/ranges property

Quoted 7 lines

---

Not tested on HW.

---
 arch/arm64/boot/dts/exynos/exynos7.dtsi | 20 ++++++++++----------

Applied.

Best regards,
Krzysztof

#6 lore raw
In reply to Krzysztof Kozlowski

Hi Krzysztof,

Quoted 15 lines · Krzysztof Kozlowski

Remove the simple-bus compatible from a regulators node because its children do not have any unit addresses. This fixes DTC warning:

Warning (simple_bus_reg): /regulators/regulator-0: missing or empty reg/ranges property

---
  arch/arm/boot/dts/exynos4210-trats.dts | 2 --
  1 file changed, 2 deletions(-)
arch/arm/boot/dts/exynos4210-trats.dts +0 -0
index 3d791db6095c..cec413ee4490 100644

arch/arm/boot/dts/exynos4210-trats.dts line 34

Quoted 4 lines
arch/arm/boot/dts/exynos4210-trats.dts +0 -1
@@ -31,8 +31,6 @@
  	};
 
  	regulators {
-		compatible = "simple-bus";

I think you would also need to remove the 'regulators' node altogether, otherwise with your change the subnodes below won't get parsed and the regulators will not get registered.

arch/arm/boot/dts/exynos4210-trats.dts line 36

Quoted 4 lines
arch/arm/boot/dts/exynos4210-trats.dts +0 -0
  		vemmc_reg: regulator-0 {
  			compatible = "regulator-fixed";
  			regulator-name = "VMEM_VDD_2.8V";

--
Thanks,
Sylwester

author maintainer
#7 lore raw
Quoted 13 lines · Sylwester Nawrocki

Hi Krzysztof,

Quoted 10 lines · Krzysztof Kozlowski

Remove the simple-bus compatible from a regulators node because its children do not have any unit addresses. This fixes DTC warning:

Warning (simple_bus_reg): /regulators/regulator-0: missing or empty reg/ranges property

---
  arch/arm/boot/dts/exynos4210-trats.dts | 2 --
  1 file changed, 2 deletions(-)
Quoted 12 lines

arch/arm/boot/dts/exynos4210-trats.dts line 33

Quoted 8 lines
arch/arm/boot/dts/exynos4210-trats.dts +0 -1
index 3d791db6095c..cec413ee4490 100644
@@ -31,8 +31,6 @@
  	};
  	regulators {
-		compatible = "simple-bus";

I think you would also need to remove the 'regulators' node altogether, otherwise with your change the subnodes below won't get parsed and the regulators will not get registered.

Good point, I actually did not test this patch. Let me recheck and send a follow up.

Thanks for review!

Best regards,
Krzysztof