Skip to contentSkip to conversation

net/ixgbe: enable 10Mb/s speed for x553

PATCH In review Wei Zhao 3 participants 5 messages Jun 28, 2020 – Jun 30, 2020 Network drivers

lore
Share & tools
lore

Wei Zhao

author
#0 lore raw

PATCH 1/1 net/ixgbe: enable 10Mb/s speed for x553

For ixgbe x553(IXGBE_DEV_ID_X550EM_A_1G_T) it support 10M link speed, so enable it for the kind of ixgbe nic.

Fixes af75078fece3 ("first public release")
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/ixgbe/ixgbe_ethdev.c +4 -0
index f8a84c565..d812579fe 100644
@@ -4320,6 +4320,10 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
 			link.link_speed = ETH_SPEED_NUM_100M;
 		break;
 
+	case IXGBE_LINK_SPEED_10_FULL:
+		link.link_speed = ETH_SPEED_NUM_10M;
+		break;
+
 	case IXGBE_LINK_SPEED_100_FULL:
 		link.link_speed = ETH_SPEED_NUM_100M;
 		break;
Signature · 1 line
2.19.1
Acked-by on v1 1/1
#1 lore raw

hi, wei

Quoted 2 lines · Wei Zhao

For ixgbe x553(IXGBE_DEV_ID_X550EM_A_1G_T) it support 10M link speed, so enable it for the kind of ixgbe nic.

This is not an enabling patch i think, it just add the support link speed info for specific nic, so suggest you refine the commit log and bring my

ack at coming version.

Quoted 13 lines
Fixes af75078fece3 ("first public release")
---
  drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++++
  1 file changed, 4 insertions(+)
drivers/net/ixgbe/ixgbe_ethdev.c +0 -0
index f8a84c565..d812579fe 100644

drivers/net/ixgbe/ixgbe_ethdev.c ixgbe_dev_link_update_share(struct rte_eth_dev *dev, · line 4329

Quoted 10 lines
drivers/net/ixgbe/ixgbe_ethdev.c +4 -0
@@ -4320,6 +4320,10 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
  			link.link_speed = ETH_SPEED_NUM_100M;
  		break;
 
+	case IXGBE_LINK_SPEED_10_FULL:
+		link.link_speed = ETH_SPEED_NUM_10M;
+		break;
+
  	case IXGBE_LINK_SPEED_100_FULL:
  		link.link_speed = ETH_SPEED_NUM_100M;
  		break;
author
#2 lore raw

Hi, jia

Quoted 11 lines

-----Original Message-----
From: Guo, Jia <[email protected]>
Sent: Monday, June 29, 2020 4:21 PM
To: Zhao1, Wei <[email protected]>; [email protected]
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Yigit, Ferruh <[email protected]>
Subject: Re: [PATCH] net/ixgbe: enable 10Mb/s speed for x553

hi, wei

On 6/28/2020 2:12 PM, Wei Zhao wrote:

Quoted 9 lines
Quoted 2 lines

For ixgbe x553(IXGBE_DEV_ID_X550EM_A_1G_T) it support 10M link speed, so enable it for the kind of ixgbe nic.

This is not an enabling patch i think, it just add the support link speed info for specific nic, so suggest you refine the commit log and bring my

ack at coming version.

Ok

Quoted 27 lines

drivers/net/ixgbe/ixgbe_ethdev.c ixgbe_dev_link_update_share(struct

Quoted 15 lines
Fixes af75078fece3 ("first public release")
---
  drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++++
  1 file changed, 4 insertions(+)
drivers/net/ixgbe/ixgbe_ethdev.c +0 -0
index f8a84c565..d812579fe 100644
@@ -4320,6 +4320,10 @@ ixgbe_dev_link_update_share(struct

rte_eth_dev *dev,

drivers/net/ixgbe/ixgbe_ethdev.c ixgbe_dev_link_update_share(struct rte_eth_dev *dev, · line 4329

Quoted 10 lines
drivers/net/ixgbe/ixgbe_ethdev.c +4 -0
  			link.link_speed = ETH_SPEED_NUM_100M;
  		break;
 
+	case IXGBE_LINK_SPEED_10_FULL:
+		link.link_speed = ETH_SPEED_NUM_10M;
+		break;
+
  	case IXGBE_LINK_SPEED_100_FULL:
  		link.link_speed = ETH_SPEED_NUM_100M;
  		break;
author
#3 lore raw

PATCH v2 1/1 net/ixgbe: add the support link speed info for x553

In reply to Wei Zhao

For ixgbe x553(IXGBE_DEV_ID_X550EM_A_1G_T) it support 10M link speed, so add the support link speed info for 10Mb/s.

Fixes af75078fece3 ("first public release")
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/ixgbe/ixgbe_ethdev.c +4 -0
index f8a84c565..d812579fe 100644
@@ -4320,6 +4320,10 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
 			link.link_speed = ETH_SPEED_NUM_100M;
 		break;
 
+	case IXGBE_LINK_SPEED_10_FULL:
+		link.link_speed = ETH_SPEED_NUM_10M;
+		break;
+
 	case IXGBE_LINK_SPEED_100_FULL:
 		link.link_speed = ETH_SPEED_NUM_100M;
 		break;
Signature · 1 line
2.19.1
Applied
#4 lore raw

Re: [dpdk-dev] [PATCH v2] net/ixgbe: add the support link speed info for x553

Quoted 10 lines

-----Original Message-----
From: Zhao1, Wei <[email protected]>
Sent: Tuesday, June 30, 2020 9:17 AM
To: [email protected]
Cc: [email protected]; Zhang, Qi Z <[email protected]>; Guo, Jia <[email protected]>; Zhao1, Wei <[email protected]>
Subject: [PATCH v2] net/ixgbe: add the support link speed info for x553

Quoted 8 lines

For ixgbe x553(IXGBE_DEV_ID_X550EM_A_1G_T) it support 10M link speed, so add the support link speed info for 10Mb/s.

Fixes af75078fece3 ("first public release")

Applied to dpdk-next-net-intel.

Thanks
Qi