Skip to contentSkip to conversation

dt-bindings: display: vc4: dpi: Remove unneeded 'simple-panel' property

PATCH In review Fabio Estevam 2 participants 3 messages Jun 29, 2020 – Jun 30, 2020

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dt-bindings: display: vc4: dpi: Remove unneeded 'simple-panel' property

Remove the unneeded "simple-panel" property to fix the following warning seen with 'make dt_binding_check':

Documentation/devicetree/bindings/display/brcm,bcm2835-dpi.example.dt.yaml: panel: compatible: Additional items are not allowed ('simple-panel' was unexpected) Documentation/devicetree/bindings/display/brcm,bcm2835-dpi.example.dt.yaml: panel: compatible: ['ontat,yx700wv03', 'simple-panel'] is too long

---
 Documentation/devicetree/bindings/display/brcm,bcm2835-dpi.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/display/brcm,bcm2835-dpi.yaml +1 -1
index 58213c564e03..24119411b007 100644
@@ -46,7 +46,7 @@ examples:
     #include <dt-bindings/clock/bcm2835.h>
 
     panel: panel {
-        compatible = "ontat,yx700wv03", "simple-panel";
+        compatible = "ontat,yx700wv03";
 
         port {
             panel_in: endpoint {
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/2 dt-bindings: display: vc4: dpi: Pass the required 'power-supply' prorperty

Pass the required 'power-supply' prorperty to fix the following warning seen with 'make dt_binding_check':

Documentation/devicetree/bindings/display/brcm,bcm2835-dpi.example.dt.yaml: panel: 'power-supply' is a required property

---
 Documentation/devicetree/bindings/display/brcm,bcm2835-dpi.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/display/brcm,bcm2835-dpi.yaml +1 -0
index 24119411b007..7ab03614a8ea 100644
@@ -47,6 +47,7 @@ examples:
 
     panel: panel {
         compatible = "ontat,yx700wv03";
+        power-supply = <&panel_reg>;
 
         port {
             panel_in: endpoint {
Signature · 1 line
2.17.1
maintainer
#2 lore raw
In reply to Fabio Estevam
Quoted 5 lines · Fabio Estevam

Remove the unneeded "simple-panel" property to fix the following warning seen with 'make dt_binding_check':

Documentation/devicetree/bindings/display/brcm,bcm2835-dpi.example.dt.yaml: panel: compatible: Additional items are not allowed ('simple-panel' was unexpected) Documentation/devicetree/bindings/display/brcm,bcm2835-dpi.example.dt.yaml: panel: compatible: ['ontat,yx700wv03', 'simple-panel'] is too long

There's already a fix for this from Maxime which just removes the example as it doesn't add much value.

Quoted 22 lines
---
 Documentation/devicetree/bindings/display/brcm,bcm2835-dpi.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/display/brcm,bcm2835-dpi.yaml +1 -1
index 58213c564e03..24119411b007 100644
@@ -46,7 +46,7 @@ examples:
     #include <dt-bindings/clock/bcm2835.h>
 
     panel: panel {
-        compatible = "ontat,yx700wv03", "simple-panel";
+        compatible = "ontat,yx700wv03";
 
         port {
             panel_in: endpoint {
Signature · 1 line
2.17.1