Skip to contentSkip to conversation

gitlab: add pycrypto for arm64

PATCH New Kever Yang 2 participants 4 messages Jun 28, 2020 – Jun 30, 2020

lore
Share & tools
lore

Kever Yang

author
#0 lore raw

PATCH 1/1 gitlab: add pycrypto for arm64

pycrypto is needed for script to generate correct its.

---

 .gitlab-ci.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
.gitlab-ci.yml +2 -2
index f2e491c117..4841e7afbe 100644
@@ -67,7 +67,7 @@ build all 64bit ARM platforms:
   script:
     - virtualenv -p /usr/bin/python3 /tmp/venv
     - . /tmp/venv/bin/activate
-    - pip install pyelftools
+    - pip install pyelftools pycrypto
     - ret=0;
       ./tools/buildman/buildman -o /tmp -P -E -W aarch64 || ret=$?;
       if [[ $ret -ne 0 ]]; then
@@ -159,7 +159,7 @@ Run binman, buildman, dtoc, Kconfig and patman testsuites:
       export USER=gitlab;
       virtualenv -p /usr/bin/python3 /tmp/venv;
       . /tmp/venv/bin/activate;
-      pip install pyelftools pytest;
+      pip install pyelftools pytest pycrypto;
       export UBOOT_TRAVIS_BUILD_DIR=/tmp/sandbox_spl;
       export PYTHONPATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc/pylibfdt";
       export PATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc:${PATH}";
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 gitlab: add pycrypto for arm64

Quoted 22 lines · Kever Yang

pycrypto is needed for script to generate correct its.

---

 .gitlab-ci.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
.gitlab-ci.yml +1 -1
index f2e491c117..4841e7afbe 100644
@@ -67,7 +67,7 @@ build all 64bit ARM platforms:
   script:
     - virtualenv -p /usr/bin/python3 /tmp/venv
     - . /tmp/venv/bin/activate
-    - pip install pyelftools
+    - pip install pyelftools pycrypto
     - ret=0;
       ./tools/buildman/buildman -o /tmp -P -E -W aarch64 || ret=$?;
       if [[ $ret -ne 0 ]]; then

.gitlab-ci.yml Run binman, buildman, dtoc, Kconfig and patman testsuites: · line 165

Quoted 8 lines
.gitlab-ci.yml +1 -1
@@ -159,7 +159,7 @@ Run binman, buildman, dtoc, Kconfig and patman testsuites:
       export USER=gitlab;
       virtualenv -p /usr/bin/python3 /tmp/venv;
       . /tmp/venv/bin/activate;
-      pip install pyelftools pytest;
+      pip install pyelftools pytest pycrypto;
       export UBOOT_TRAVIS_BUILD_DIR=/tmp/sandbox_spl;
       export PYTHONPATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc/pylibfdt";
       export PATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc:${PATH}";

We need to update all of the CI config files to install the needed modules. I also assume we haven't pushed changes in yet that require pycrypto, so which tool is going to need it? I want to make sure we document it and perhaps we need to start thinking about a requirement.txt for our python tools if it's binman that needs it (as that's what also needs pyelftools). Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200629/12c13587/attachment.sig>
author
#2 lore raw

PATCH 1/1 gitlab: add pycrypto for arm64

Hi Tom,

Quoted 30 lines · Tom Rini
Quoted 28 lines · Kever Yang

pycrypto is needed for script to generate correct its.

---

  .gitlab-ci.yml | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
.gitlab-ci.yml +2 -2
index f2e491c117..4841e7afbe 100644
@@ -67,7 +67,7 @@ build all 64bit ARM platforms:
    script:
      - virtualenv -p /usr/bin/python3 /tmp/venv
      - . /tmp/venv/bin/activate
-    - pip install pyelftools
+    - pip install pyelftools pycrypto
      - ret=0;
        ./tools/buildman/buildman -o /tmp -P -E -W aarch64 || ret=$?;
        if [[ $ret -ne 0 ]]; then
@@ -159,7 +159,7 @@ Run binman, buildman, dtoc, Kconfig and patman testsuites:
        export USER=gitlab;
        virtualenv -p /usr/bin/python3 /tmp/venv;
        . /tmp/venv/bin/activate;
-      pip install pyelftools pytest;
+      pip install pyelftools pytest pycrypto;
        export UBOOT_TRAVIS_BUILD_DIR=/tmp/sandbox_spl;
Quoted 8 lines

.gitlab-ci.yml Run binman, buildman, dtoc, Kconfig and patman testsuites: · line 165

Quoted 2 lines
.gitlab-ci.yml +0 -0
        export PYTHONPATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc/pylibfdt";
        export PATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc:${PATH}";

We need to update all of the CI config files to install the needed modules. I also assume we haven't pushed changes in yet that require pycrypto, so which tool is going to need it? I want to make sure we document it and perhaps we need to start thinking about a requirement.txt for our python tools if it's binman that needs it (as that's what also needs pyelftools). Thanks!

This is need by below patches

http://patchwork.ozlabs.org/project/uboot/cover/20200619104550.1972307-1-heiko at sntech.de/

Thanks,

- Kever

#3 lore raw

PATCH 1/1 gitlab: add pycrypto for arm64

Quoted 42 lines · Kever Yang

Hi Tom,

Quoted 30 lines · Tom Rini
Quoted 28 lines · Kever Yang

pycrypto is needed for script to generate correct its.

---

  .gitlab-ci.yml | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
.gitlab-ci.yml +2 -2
index f2e491c117..4841e7afbe 100644
@@ -67,7 +67,7 @@ build all 64bit ARM platforms:
    script:
      - virtualenv -p /usr/bin/python3 /tmp/venv
      - . /tmp/venv/bin/activate
-    - pip install pyelftools
+    - pip install pyelftools pycrypto
      - ret=0;
        ./tools/buildman/buildman -o /tmp -P -E -W aarch64 || ret=$?;
        if [[ $ret -ne 0 ]]; then
@@ -159,7 +159,7 @@ Run binman, buildman, dtoc, Kconfig and patman testsuites:
        export USER=gitlab;
        virtualenv -p /usr/bin/python3 /tmp/venv;
        . /tmp/venv/bin/activate;
-      pip install pyelftools pytest;
+      pip install pyelftools pytest pycrypto;
        export UBOOT_TRAVIS_BUILD_DIR=/tmp/sandbox_spl;
Quoted 8 lines

.gitlab-ci.yml Run binman, buildman, dtoc, Kconfig and patman testsuites: · line 165

Quoted 2 lines
.gitlab-ci.yml +0 -0
        export PYTHONPATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc/pylibfdt";
        export PATH="${UBOOT_TRAVIS_BUILD_DIR}/scripts/dtc:${PATH}";

We need to update all of the CI config files to install the needed modules. I also assume we haven't pushed changes in yet that require pycrypto, so which tool is going to need it? I want to make sure we document it and perhaps we need to start thinking about a requirement.txt for our python tools if it's binman that needs it (as that's what also needs pyelftools). Thanks!

Quoted 3 lines

This is need by below patches

http://patchwork.ozlabs.org/project/uboot/cover/20200619104550.1972307-1-heiko at sntech.de/

OK, so the patch here needs to update all CI, so I'm marking this as Changes Requested in patchwork. I have some other comments for that series (thanks) and I'll follow up there.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200630/e26a428c/attachment.sig>