KVM: arm64: Change default caching mode for {PEND,PROP}BASER.outer
PATCH 1/1 KVM: arm64: Change default caching mode for {PEND,PROP}BASER.outer
PENDBASER and PROPBASER define the outer caching mode for LPI tables. The memory backing them may not be outer sharable, so we mark them as nC by default. This however, breaks Windows on ARM which only accepts SameAsInner or RaWaWb as values for outer cachability.
We do today already allow the outer mode to be set to SameAsInner explicitly, so the easy fix is to default to that instead of nC for situations when an OS asks for a not fulfillable cachability request.
This fixes booting Windows in KVM with vgicv3 and ITS enabled for me.
--- arch/arm64/kvm/vgic/vgic-mmio-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/kvm/vgic/vgic-mmio-v3.c +1 -1
@@ -389,7 +389,7 @@ u64 vgic_sanitise_outer_cacheability(u64 field)case GIC_BASER_CACHE_nC:return field;default : -return GIC_BASER_CACHE_nC; +return GIC_BASER_CACHE_SameAsInner; } }
Signature · 12 lines
2.17.1 Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879
Marc Zyngier
maintainerRe: [PATCH] KVM: arm64: Change default caching mode for {PEND, PROP}BASER.outer
Quoted 22 lines · Alexander Graf
PENDBASER and PROPBASER define the outer caching mode for LPI tables. The memory backing them may not be outer sharable, so we mark them as nC by default. This however, breaks Windows on ARM which only accepts SameAsInner or RaWaWb as values for outer cachability.
We do today already allow the outer mode to be set to SameAsInner explicitly, so the easy fix is to default to that instead of nC for situations when an OS asks for a not fulfillable cachability request.
This fixes booting Windows in KVM with vgicv3 and ITS enabled for me.
Signed-off-by Alexander Graf <[email protected]>--- arch/arm64/kvm/vgic/vgic-mmio-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/kvm/vgic/vgic-mmio-v3.c +0
-0
arch/arm64/kvm/vgic/vgic-mmio-v3.c u64 vgic_sanitise_outer_cacheability(u64 field) · line 395
Quoted 8 lines
arch/arm64/kvm/vgic/vgic-mmio-v3.c +1
-1@@ -389,7 +389,7 @@ u64 vgic_sanitise_outer_cacheability(u64 field)case GIC_BASER_CACHE_nC:return field;default : -return GIC_BASER_CACHE_nC; +return GIC_BASER_CACHE_SameAsInner; } }
I am going to provisionally queue this for 5.9, with the explicit reserve that it will be reverted if it causes a regression for other guests (as this is an observable change in behaviour).
Thanks,
M.
Signature · 5 lines
Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
Re: [PATCH] KVM: arm64: Change default caching mode for {PEND, PROP}BASER.outer
In reply to Alexander GrafQuoted 10 lines · Alexander Graf
PENDBASER and PROPBASER define the outer caching mode for LPI tables. The memory backing them may not be outer sharable, so we mark them as nC by default. This however, breaks Windows on ARM which only accepts SameAsInner or RaWaWb as values for outer cachability.
We do today already allow the outer mode to be set to SameAsInner explicitly, so the easy fix is to default to that instead of nC for situations when an OS asks for a not fulfillable cachability request.
[...]
Applied to kvm-arm64/next-5.9, thanks!
[1/1] KVM: arm64: vgic-its: Change default outer cacheability for {PEND, PROP}BASER
commit: 731532176716e2775a5d21115bb9c5c61e0cb704
Cheers,
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.