video: fbdev: vt8623fb: Constify static vga_regsets
PATCH 1/1 video: fbdev: vt8623fb: Constify static vga_regsets
These are not modified so make them const to allow the compiler to put them in read-only memory.
Before:
text data bss dec hex filename
25509 7928 64 33501 82dd drivers/video/fbdev/vt8623fb.o
After:
text data bss dec hex filename
26533 6904 64 33501 82dd drivers/video/fbdev/vt8623fb.o
--- drivers/video/fbdev/vt8623fb.c | 36 +++++++++++++++++----------------- 1 file changed, 18 insertions(+), 18 deletions(-)
drivers/video/fbdev/vt8623fb.c +18 -18
@@ -62,24 +62,24 @@ static const struct svga_pll vt8623_pll = {2, 127, 2, 7, 0, 3,/* CRT timing register sets */ -static struct vga_regset vt8623_h_total_regs[] = {{0x00 ,0 ,7 }, {0x36 ,3 ,3 },VGA_REGSET_END }; -static struct vga_regset vt8623_h_display_regs[] = {{0x01 ,0 ,7 },VGA_REGSET_END }; -static struct vga_regset vt8623_h_blank_start_regs[] = {{0x02 ,0 ,7 },VGA_REGSET_END }; -static struct vga_regset vt8623_h_blank_end_regs[] = {{0x03 ,0 ,4 }, {0x05 ,7 ,7 }, {0x33 ,5 ,5 },VGA_REGSET_END }; -static struct vga_regset vt8623_h_sync_start_regs[] = {{0x04 ,0 ,7 }, {0x33 ,4 ,4 },VGA_REGSET_END }; -static struct vga_regset vt8623_h_sync_end_regs[] = {{0x05 ,0 ,4 },VGA_REGSET_END }; - -static struct vga_regset vt8623_v_total_regs[] = {{0x06 ,0 ,7 }, {0x07 ,0 ,0 }, {0x07 ,5 ,5 }, {0x35 ,0 ,0 },VGA_REGSET_END }; -static struct vga_regset vt8623_v_display_regs[] = {{0x12 ,0 ,7 }, {0x07 ,1 ,1 }, {0x07 ,6 ,6 }, {0x35 ,2 ,2 },VGA_REGSET_END }; -static struct vga_regset vt8623_v_blank_start_regs[] = {{0x15 ,0 ,7 }, {0x07 ,3 ,3 }, {0x09 ,5 ,5 }, {0x35 ,3 ,3 },VGA_REGSET_END }; -static struct vga_regset vt8623_v_blank_end_regs[] = {{0x16 ,0 ,7 },VGA_REGSET_END }; -static struct vga_regset vt8623_v_sync_start_regs[] = {{0x10 ,0 ,7 }, {0x07 ,2 ,2 }, {0x07 ,7 ,7 }, {0x35 ,1 ,1 },VGA_REGSET_END }; -static struct vga_regset vt8623_v_sync_end_regs[] = {{0x11 ,0 ,3 },VGA_REGSET_END }; - -static struct vga_regset vt8623_offset_regs[] = {{0x13 ,0 ,7 }, {0x35 ,5 ,7 },VGA_REGSET_END }; -static struct vga_regset vt8623_line_compare_regs[] = {{0x18 ,0 ,7 }, {0x07 ,4 ,4 }, {0x09 ,6 ,6 }, {0x33 ,0 ,2 }, {0x35 ,4 ,4 },VGA_REGSET_END }; -static struct vga_regset vt8623_fetch_count_regs[] = {{0x1C ,0 ,7 }, {0x1D ,0 ,1 },VGA_REGSET_END }; -static struct vga_regset vt8623_start_address_regs[] = {{0x0d ,0 ,7 }, {0x0c ,0 ,7 }, {0x34 ,0 ,7 }, {0x48 ,0 ,1 },VGA_REGSET_END }; +static const struct vga_regset vt8623_h_total_regs[] = {{0x00 ,0 ,7 }, {0x36 ,3 ,3 },VGA_REGSET_END }; +static const struct vga_regset vt8623_h_display_regs[] = {{0x01 ,0 ,7 },VGA_REGSET_END }; +static const struct vga_regset vt8623_h_blank_start_regs[] = {{0x02 ,0 ,7 },VGA_REGSET_END }; +static const struct vga_regset vt8623_h_blank_end_regs[] = {{0x03 ,0 ,4 }, {0x05 ,7 ,7 }, {0x33 ,5 ,5 },VGA_REGSET_END }; +static const struct vga_regset vt8623_h_sync_start_regs[] = {{0x04 ,0 ,7 }, {0x33 ,4 ,4 },VGA_REGSET_END }; +static const struct vga_regset vt8623_h_sync_end_regs[] = {{0x05 ,0 ,4 },VGA_REGSET_END }; + +static const struct vga_regset vt8623_v_total_regs[] = {{0x06 ,0 ,7 }, {0x07 ,0 ,0 }, {0x07 ,5 ,5 }, {0x35 ,0 ,0 },VGA_REGSET_END }; +static const struct vga_regset vt8623_v_display_regs[] = {{0x12 ,0 ,7 }, {0x07 ,1 ,1 }, {0x07 ,6 ,6 }, {0x35 ,2 ,2 },VGA_REGSET_END }; +static const struct vga_regset vt8623_v_blank_start_regs[] = {{0x15 ,0 ,7 }, {0x07 ,3 ,3 }, {0x09 ,5 ,5 }, {0x35 ,3 ,3 },VGA_REGSET_END }; +static const struct vga_regset vt8623_v_blank_end_regs[] = {{0x16 ,0 ,7 },VGA_REGSET_END }; +static const struct vga_regset vt8623_v_sync_start_regs[] = {{0x10 ,0 ,7 }, {0x07 ,2 ,2 }, {0x07 ,7 ,7 }, {0x35 ,1 ,1 },VGA_REGSET_END }; +static const struct vga_regset vt8623_v_sync_end_regs[] = {{0x11 ,0 ,3 },VGA_REGSET_END }; + +static const struct vga_regset vt8623_offset_regs[] = {{0x13 ,0 ,7 }, {0x35 ,5 ,7 },VGA_REGSET_END }; +static const struct vga_regset vt8623_line_compare_regs[] = {{0x18 ,0 ,7 }, {0x07 ,4 ,4 }, {0x09 ,6 ,6 }, {0x33 ,0 ,2 }, {0x35 ,4 ,4 },VGA_REGSET_END }; +static const struct vga_regset vt8623_fetch_count_regs[] = {{0x1C ,0 ,7 }, {0x1D ,0 ,1 },VGA_REGSET_END }; +static const struct vga_regset vt8623_start_address_regs[] = {{0x0d ,0 ,7 }, {0x0c ,0 ,7 }, {0x34 ,0 ,7 }, {0x48 ,0 ,1 },VGA_REGSET_END };static const struct svga_timing_regs vt8623_timing_regs = { vt8623_h_total_regs, vt8623_h_display_regs, vt8623_h_blank_start_regs,
Signature · 1 line
2.27.0
Bartlomiej Zolnierkiewicz
AppliedQuoted 7 lines · Rikard Falkeborn
These are not modified so make them const to allow the compiler to put them in read-only memory.
Before:
text data bss dec hex filename
25509 7928 64 33501 82dddrivers/video/fbdev/vt8623fb.o
Quoted 5 lines
After:
text data bss dec hex filename
26533 6904 64 33501 82dddrivers/video/fbdev/vt8623fb.oSigned-off-by Rikard Falkeborn <[email protected]>
Applied to drm-misc-next tree, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Quoted 52 lines
--- drivers/video/fbdev/vt8623fb.c | 36 +++++++++++++++++----------------- 1 file changed, 18 insertions(+), 18 deletions(-)drivers/video/fbdev/vt8623fb.c +18
-18@@ -62,24 +62,24 @@ static const struct svga_pll vt8623_pll = {2, 127, 2, 7, 0, 3,/* CRT timing register sets */ -static struct vga_regset vt8623_h_total_regs[] = {{0x00 ,0 ,7 }, {0x36 ,3 ,3 },VGA_REGSET_END }; -static struct vga_regset vt8623_h_display_regs[] = {{0x01 ,0 ,7 },VGA_REGSET_END }; -static struct vga_regset vt8623_h_blank_start_regs[] = {{0x02 ,0 ,7 },VGA_REGSET_END }; -static struct vga_regset vt8623_h_blank_end_regs[] = {{0x03 ,0 ,4 }, {0x05 ,7 ,7 }, {0x33 ,5 ,5 },VGA_REGSET_END }; -static struct vga_regset vt8623_h_sync_start_regs[] = {{0x04 ,0 ,7 }, {0x33 ,4 ,4 },VGA_REGSET_END }; -static struct vga_regset vt8623_h_sync_end_regs[] = {{0x05 ,0 ,4 },VGA_REGSET_END }; - -static struct vga_regset vt8623_v_total_regs[] = {{0x06 ,0 ,7 }, {0x07 ,0 ,0 }, {0x07 ,5 ,5 }, {0x35 ,0 ,0 },VGA_REGSET_END }; -static struct vga_regset vt8623_v_display_regs[] = {{0x12 ,0 ,7 }, {0x07 ,1 ,1 }, {0x07 ,6 ,6 }, {0x35 ,2 ,2 },VGA_REGSET_END }; -static struct vga_regset vt8623_v_blank_start_regs[] = {{0x15 ,0 ,7 }, {0x07 ,3 ,3 }, {0x09 ,5 ,5 }, {0x35 ,3 ,3 },VGA_REGSET_END }; -static struct vga_regset vt8623_v_blank_end_regs[] = {{0x16 ,0 ,7 },VGA_REGSET_END }; -static struct vga_regset vt8623_v_sync_start_regs[] = {{0x10 ,0 ,7 }, {0x07 ,2 ,2 }, {0x07 ,7 ,7 }, {0x35 ,1 ,1 },VGA_REGSET_END }; -static struct vga_regset vt8623_v_sync_end_regs[] = {{0x11 ,0 ,3 },VGA_REGSET_END }; - -static struct vga_regset vt8623_offset_regs[] = {{0x13 ,0 ,7 }, {0x35 ,5 ,7 },VGA_REGSET_END }; -static struct vga_regset vt8623_line_compare_regs[] = {{0x18 ,0 ,7 }, {0x07 ,4 ,4 }, {0x09 ,6 ,6 }, {0x33 ,0 ,2 }, {0x35 ,4 ,4 },VGA_REGSET_END }; -static struct vga_regset vt8623_fetch_count_regs[] = {{0x1C ,0 ,7 }, {0x1D ,0 ,1 },VGA_REGSET_END }; -static struct vga_regset vt8623_start_address_regs[] = {{0x0d ,0 ,7 }, {0x0c ,0 ,7 }, {0x34 ,0 ,7 }, {0x48 ,0 ,1 },VGA_REGSET_END }; +static const struct vga_regset vt8623_h_total_regs[] = {{0x00 ,0 ,7 }, {0x36 ,3 ,3 },VGA_REGSET_END }; +static const struct vga_regset vt8623_h_display_regs[] = {{0x01 ,0 ,7 },VGA_REGSET_END }; +static const struct vga_regset vt8623_h_blank_start_regs[] = {{0x02 ,0 ,7 },VGA_REGSET_END }; +static const struct vga_regset vt8623_h_blank_end_regs[] = {{0x03 ,0 ,4 }, {0x05 ,7 ,7 }, {0x33 ,5 ,5 },VGA_REGSET_END }; +static const struct vga_regset vt8623_h_sync_start_regs[] = {{0x04 ,0 ,7 }, {0x33 ,4 ,4 },VGA_REGSET_END }; +static const struct vga_regset vt8623_h_sync_end_regs[] = {{0x05 ,0 ,4 },VGA_REGSET_END }; + +static const struct vga_regset vt8623_v_total_regs[] = {{0x06 ,0 ,7 }, {0x07 ,0 ,0 }, {0x07 ,5 ,5 }, {0x35 ,0 ,0 },VGA_REGSET_END }; +static const struct vga_regset vt8623_v_display_regs[] = {{0x12 ,0 ,7 }, {0x07 ,1 ,1 }, {0x07 ,6 ,6 }, {0x35 ,2 ,2 },VGA_REGSET_END }; +static const struct vga_regset vt8623_v_blank_start_regs[] = {{0x15 ,0 ,7 }, {0x07 ,3 ,3 }, {0x09 ,5 ,5 }, {0x35 ,3 ,3 },VGA_REGSET_END }; +static const struct vga_regset vt8623_v_blank_end_regs[] = {{0x16 ,0 ,7 },VGA_REGSET_END }; +static const struct vga_regset vt8623_v_sync_start_regs[] = {{0x10 ,0 ,7 }, {0x07 ,2 ,2 }, {0x07 ,7 ,7 }, {0x35 ,1 ,1 },VGA_REGSET_END }; +static const struct vga_regset vt8623_v_sync_end_regs[] = {{0x11 ,0 ,3 },VGA_REGSET_END }; + +static const struct vga_regset vt8623_offset_regs[] = {{0x13 ,0 ,7 }, {0x35 ,5 ,7 },VGA_REGSET_END }; +static const struct vga_regset vt8623_line_compare_regs[] = {{0x18 ,0 ,7 }, {0x07 ,4 ,4 }, {0x09 ,6 ,6 }, {0x33 ,0 ,2 }, {0x35 ,4 ,4 },VGA_REGSET_END }; +static const struct vga_regset vt8623_fetch_count_regs[] = {{0x1C ,0 ,7 }, {0x1D ,0 ,1 },VGA_REGSET_END }; +static const struct vga_regset vt8623_start_address_regs[] = {{0x0d ,0 ,7 }, {0x0c ,0 ,7 }, {0x34 ,0 ,7 }, {0x48 ,0 ,1 },VGA_REGSET_END };static const struct svga_timing_regs vt8623_timing_regs = { vt8623_h_total_regs, vt8623_h_display_regs, vt8623_h_blank_start_regs,