Add support for PinePhone LCD panel
Subsystems (2)
v8 cover Add support for PinePhone LCD panel
This patchset adds support for the LCD panel of PinePhone.
I've tested this on PinePhone 1.0 and 1.2.
Please take a look.
thank you and regards,
Ondrej Jirman
Changes in v8:
- Drop goodix,gt911 fallback compatible (Icenowy)
- Drop address/size-cells from &dsi node (Maxime)
- Drop already applied patches
- v7->v8 diff: https://megous.com/dl/tmp/v7-v8.patch
Changes in v7:
- Removed mode.vrefresh, rebased onto next-20200701
- v6->v7 diff: https://megous.com/dl/tmp/v6-v7.patch
Changes in v6:
- Fixed spacing in yaml
- Fixed wrong vccio->iovcc supply name in the bindings doc
- I noticed that the original driver uses a delay of 20ms in the init function to achieve a combined total of 120ms required from post-reset to display_on. I've added a similar delay to xbd599_init, so that xbd599 panel also has the right timing. (patch 9)
- v5->v6 diff: https://megous.com/dl/tmp/v5-v6.patch
- Added review/ack tags
- Learned to run dt_binding_check by myself ;)
Changes in v5:
- rewritten on top of rocktech-jh057n00900 driver
- rocktech-jh057n00900 renamed to st7703 (controller name)
- converted rocktech-jh057n00900 bindings to yaml and extended for xbd599
Changes in v4:
- use ->type from the mode instead of hardcoding (Samuel)
- move init_sequence to ->prepare (Samuel)
- move anti-flicker delay to ->enable, explain it (Samuel)
- add enter_sleep after display_off (Samuel)
- drop ->disable (move code to ->unprepare)
- add ID bytes dumping (Linus)
(I can't test it since allwinner DSI driver has a broken
dcs_read function, and I didn't manage to fix it.)
- document magic bytes (Linus)
- assert reset during powerup
- cleanup powerup timings according to the datasheet
Changes in v3:
- Panel driver renamed to the name of the LCD controller
- Re-organize the driver slightly to more easily support more panels based on the same controller.
- Add patch to enable the touchscreen to complete the LCD support on PinePhone.
- Dropped the "DSI fix" patch (the driver seems to work for me without it)
- Improved brightness levels handling:
- PinePhone 1.0 uses default levels generated by the driver
- On PinePhone 1.1 duty cycles < 20% lead to black screen, so default levels can't be used. Martijn Braam came up with a list of duty cycle values that lead to perception of linear brigtness level <-> light intensity on PinePhone 1.1
- There was some feedback on v2 about this being similar to st7701. It's only similar in name. Most of the "user commands" are different, so I opted to keep this in a new driver instead of creating st770x.
Anyone who likes to check the differences, here are datasheets:
- https://megous.com/dl/tmp/ST7703_DS_v01_20160128.pdf
- https://megous.com/dl/tmp/ST7701.pdf
Changes in v2:
- DT Example fix.
- DT Format fix.
- Raised copyright info to 2020.
- Sort panel operation functions.
- Sort inclusion.
-- For phone owners: --
There's an open question on how to set the backlight brightness values on post 1.0 revision phone, since lower duty cycles (< 10-20%) lead to backlight being black. It would be nice if more people can test the various backlight levels on 1.1 and 1.2 revision with this change in dts:
brightness-levels = <0 1000>;
num-interpolated-steps = <1000>;and report at what brightness level the backlight turns on. So far it seems this has a wide range. Lowest useable duty cycle for me is ~7% on 1.2 and for Martijn ~20% on 1.1.
Icenowy Zheng (1):
arm64: dts: sun50i-a64-pinephone: Enable LCD support on PinePhone
Ondrej Jirman (1):
arm64: dts: sun50i-a64-pinephone: Add touchscreen support
.../allwinner/sun50i-a64-pinephone-1.1.dts | 19 +++++++ .../dts/allwinner/sun50i-a64-pinephone.dtsi | 52 +++++++++++++++++++ 2 files changed, 71 insertions(+)
Signature · 1 line
2.27.0
PATCH v8 1/2 arm64: dts: sun50i-a64-pinephone: Enable LCD support on PinePhone
From: Icenowy Zheng <[email protected]>
PinePhone uses PWM backlight and a XBD599 LCD panel over DSI for display.
Backlight levels curve was optimized by Martijn Braam using a lux meter.
Add its device nodes.
--- .../allwinner/sun50i-a64-pinephone-1.1.dts | 19 +++++++++++ .../dts/allwinner/sun50i-a64-pinephone.dtsi | 33 +++++++++++++++++++ 2 files changed, 52 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts +19 -0
@@ -9,3 +9,22 @@ / { model = "Pine64 PinePhone Braveheart (1.1)"; compatible = "pine64,pinephone-1.1", "allwinner,sun50i-a64"; }; + +&backlight { + power-supply = <®_ldo_io0>; + /* + * PWM backlight circuit on this PinePhone revision was changed since + * 1.0, and the lowest PWM duty cycle that doesn't lead to backlight + * being off is around 20%. Duty cycle for the lowest brightness level + * also varries quite a bit between individual boards, so the lowest + * value here was chosen as a safe default. + */ + brightness-levels = < + 774 793 814 842 + 882 935 1003 1088 + 1192 1316 1462 1633 + 1830 2054 2309 2596 + 2916 3271 3664 4096>; + num-interpolated-steps = <50>; + default-brightness-level = <400>; +};
arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi +33 -0
@@ -16,6 +16,13 @@ aliases { serial0 = &uart0; }; + backlight: backlight { + compatible = "pwm-backlight"; + pwms = <&r_pwm 0 50000 PWM_POLARITY_INVERTED>; + enable-gpios = <&pio 7 10 GPIO_ACTIVE_HIGH>; /* PH10 */ + /* Backlight configuration differs per PinePhone revision. */ + }; + chosen { stdout-path = "serial0:115200n8"; };
@@ -84,6 +91,28 @@ &dai { status = "okay"; }; +&de { + status = "okay"; +}; + +&dphy { + status = "okay"; +}; + +&dsi { + vcc-dsi-supply = <®_dldo1>; + status = "okay"; + + panel@0 { + compatible = "xingbangda,xbd599"; + reg = <0>; + reset-gpios = <&pio 3 23 GPIO_ACTIVE_LOW>; /* PD23 */ + iovcc-supply = <®_dldo2>; + vcc-supply = <®_ldo_io0>; + backlight = <&backlight>; + }; +}; + &ehci0 { status = "okay"; };
@@ -188,6 +217,10 @@ &r_pio { */ }; +&r_pwm { + status = "okay"; +}; + &r_rsb { status = "okay";
Signature · 1 line
2.27.0
PATCH v8 2/2 arm64: dts: sun50i-a64-pinephone: Add touchscreen support
In reply to Ondrej JirmanPinephone has a Goodix GT917S capacitive touchscreen controller on I2C0 bus. Add support for it.
--- .../dts/allwinner/sun50i-a64-pinephone.dtsi | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi +19 -0
@@ -121,6 +121,25 @@ &ehci1 { status = "okay"; }; +&i2c0 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c0_pins>; + status = "okay"; + + touchscreen@5d { + compatible = "goodix,gt917s"; + reg = <0x5d>; + interrupt-parent = <&pio>; + interrupts = <7 4 IRQ_TYPE_LEVEL_HIGH>; /* PH4 */ + irq-gpios = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */ + reset-gpios = <&pio 7 11 GPIO_ACTIVE_HIGH>; /* PH11 */ + AVDD28-supply = <®_ldo_io0>; + VDDIO-supply = <®_ldo_io0>; + touchscreen-size-x = <720>; + touchscreen-size-y = <1440>; + }; +}; + &i2c1 { status = "okay";
Signature · 1 line
2.27.0
Re: [PATCH v8 2/2] arm64: dts: sun50i-a64-pinephone: Add touchscreen support
Hi,
Quoted 14 lines · Ondrej Jirman
Pinephone has a Goodix GT917S capacitive touchscreen controller on I2C0 bus. Add support for it.
Signed-off-by Ondrej Jirman <[email protected]>Acked-by Linus Walleij <[email protected]>--- .../dts/allwinner/sun50i-a64-pinephone.dtsi | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi +0
-0
arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi &ehci1 { · line 127
Quoted 7 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi +4
-0@@ -121,6 +121,25 @@ &ehci1 { status = "okay"; }; +&i2c0 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c0_pins>; + status = "okay";
I didn't spot this earlier, but the pinctrl properties are already set in the DTSI. I've removed them while applying the patch.
Thanks!
Maxime
Re: [PATCH v8 2/2] arm64: dts: sun50i-a64-pinephone: Add touchscreen support
Quoted 20 lines · Maxime Ripard
Hi,
Quoted 17 lines · Ondrej Jirman
Pinephone has a Goodix GT917S capacitive touchscreen controller on I2C0 bus. Add support for it.
Signed-off-by Ondrej Jirman <[email protected]>Acked-by Linus Walleij <[email protected]>--- .../dts/allwinner/sun50i-a64-pinephone.dtsi | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi +0
-0@@ -121,6 +121,25 @@ &ehci1 { status = "okay"; };
Quoted 7 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi &ehci1 { · line 127
Quoted 4 lines
arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi +4
-0+&i2c0 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c0_pins>; + status = "okay";I didn't spot this earlier, but the pinctrl properties are already set in the DTSI. I've removed them while applying the patch.
Ah, right. Thank you very much. :)
regards,
o.
Quoted 2 lines
Thanks!
Maxime