scftorture: Make symbol 'scf_torture_rand' static
PATCH 1/1 scftorture: Make symbol 'scf_torture_rand' static
Fix sparse build warning:
kernel/scftorture.c:124:1: warning:
symbol '__pcpu_scope_scf_torture_rand' was not declared. Should it be static?
--- kernel/scftorture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/scftorture.c +1 -1
@@ -121,7 +121,7 @@ static unsigned long scf_sel_totweight;static atomic_t n_started;static atomic_t n_errs; -DEFINE_TORTURE_RANDOM_PERCPU (scf_torture_rand); +static DEFINE_TORTURE_RANDOM_PERCPU (scf_torture_rand);// Print torture statistics. Caller must ensure serialization. static void scf_torture_stats_print (void )
Quoted 7 lines · Wei Yongjun
Fix sparse build warning:
kernel/scftorture.c:124:1: warning:
symbol '__pcpu_scope_scf_torture_rand' was not declared. Should it be static?Reported-by Hulk Robot <[email protected]>Signed-off-by Wei Yongjun <[email protected]>
Good catch, applied, thank you!
Due to recent changes, I hand-applied this as shown below. Please let me know if I messed anything up.
Thanx, Paul
------------------------------------------------------------------------
commit ff9210137b0b8d8f045dd1fd116253ba7686e892
Author: Wei Yongjun <[email protected]> Date: Thu Jul 2 09:56:50 2020 -0700
scftorture: Make symbol 'scf_torture_rand' static
The sparse tool complains as follows
kernel/scftorture.c:124:1: warning:
symbol '__pcpu_scope_scf_torture_rand' was not declared. Should it be static?
And this per-CPU variable is not used outside of scftorture.c, so this commit marks it static.
kernel/scftorture.c +1 -1
@@ -134,7 +134,7 @@ static atomic_t n_alloc_errs;static bool scfdone;static char *bangstr ="" ; -DEFINE_TORTURE_RANDOM_PERCPU (scf_torture_rand); +static DEFINE_TORTURE_RANDOM_PERCPU (scf_torture_rand);// Print torture statistics. Caller must ensure serialization. static void scf_torture_stats_print (void )