Skip to contentSkip to conversation

Add information for skipped commit options

PATCH New Patrick Delaunay 2 participants 2 messages Jul 2, 2020 – Jul 3, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add information for skipped commit options

The unsupported Commit-xxx option are silently skipped and removed as 're_remove=Commit-\w*', this patch adds warning message in this case to detect misspelled issue for the 2 supported options:
Commit-notes:
Commit-changes:

For example: the final 's' is missing (Commit-note:)

NB: no issue for Series-xxx option as only the supported
options are accepted (see valid_series in series.py)

---

 tools/patman/patchstream.py | 3 +++
 1 file changed, 3 insertions(+)
tools/patman/patchstream.py +3 -0
index a575c09b47..7efab8c2dd 100644
@@ -342,6 +342,9 @@ class PatchStream:
             elif name == 'changes':
                 self.in_change = 'Commit'
                 self.change_version = self.ParseVersion(value, line)
+            else:
+                self.warn.append('Line %d: Ignoring Commit-%s' %
+                    (self.linenum, name))
 
         # Detect the start of a new commit
         elif commit_match:
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 Add information for skipped commit options

Quoted 10 lines · Patrick Delaunay

The unsupported Commit-xxx option are silently skipped and removed as 're_remove=Commit-\w*', this patch adds warning message in this case to detect misspelled issue for the 2 supported options:
Commit-notes:
Commit-changes:

For example: the final 's' is missing (Commit-note:)

Quoted 8 lines

NB: no issue for Series-xxx option as only the supported
options are accepted (see valid_series in series.py)

---

 tools/patman/patchstream.py | 3 +++
 1 file changed, 3 insertions(+)