Skip to contentSkip to conversation

package/gstreamer1/gst1-plugins-good: Enable GUDEV for V4L2 if available

PATCH Superseded Ezequiel Garcia 3 participants 4 messages Jun 8, 2020 – Jul 20, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 package/gstreamer1/gst1-plugins-good: Enable GUDEV for V4L2 if available

From: Nicolas Dufresne <[email protected]>

Video4Linux2 plugins can udev for device probing and monitor. This greatly improves load time and monitoring performance.

It also enables hotplug monitoring for cameras.

---
v3:
* Apply the dependency only if V4L2 plugins are enabled v2:
* Enable/disable v4l2-gudev explicitly

 package/gstreamer1/gst1-plugins-good/Config.in            | 1 +
 package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 7 +++++++
 2 files changed, 8 insertions(+)
package/gstreamer1/gst1-plugins-good/Config.in +1 -0
index 20aebc473e89..be77f5a82e3d 100644
@@ -295,6 +295,7 @@ config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2
 config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2
 	bool "v4l2"
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # multi planar api
+	select BR2_PACKAGE_LIBGUDEV if BR2_PACKAGE_HAS_UDEV
 	help
 	  elements for Video 4 Linux
 
package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +7 -0
index 223af9850897..7bb2fa5f3720 100644
@@ -355,6 +355,13 @@ endif
 
 ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2),y)
 GST1_PLUGINS_GOOD_CONF_OPTS += -Dv4l2=enabled
+# Enable use of gudev if available, for device probing and monitoring.
+ifeq ($(BR2_PACKAGE_LIBGUDEV),y)
+GST1_PLUGINS_GOOD_DEPENDENCIES += libgudev
+GST1_PLUGINS_GOOD_CONF_OPTS += -Dv4l2-gudev=enabled
+else
+GST1_PLUGINS_GOOD_CONF_OPTS += -Dv4l2-gudev=disabled
+endif
 else
 GST1_PLUGINS_GOOD_CONF_OPTS += -Dv4l2=disabled
 endif
Signature · 1 line
2.26.0.rc2
#1 lore raw

PATCH v3 1/1 package/gstreamer1/gst1-plugins-good: Enable GUDEV for V4L2 if available

Gentle ping :-)

Quoted 53 lines · Ezequiel Garcia

From: Nicolas Dufresne <[email protected]>

Video4Linux2 plugins can udev for device probing and monitor. This greatly improves load time and monitoring performance.

It also enables hotplug monitoring for cameras.

---
v3:
* Apply the dependency only if V4L2 plugins are enabled v2:
* Enable/disable v4l2-gudev explicitly

 package/gstreamer1/gst1-plugins-good/Config.in            | 1 +
 package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 7 +++++++
 2 files changed, 8 insertions(+)
package/gstreamer1/gst1-plugins-good/Config.in +1 -0
index 20aebc473e89..be77f5a82e3d 100644
@@ -295,6 +295,7 @@ config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2
 config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2
        bool "v4l2"
        depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # multi planar api
+       select BR2_PACKAGE_LIBGUDEV if BR2_PACKAGE_HAS_UDEV
        help
          elements for Video 4 Linux
 
package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +7 -1
index 223af9850897..7bb2fa5f3720 100644
@@ -355,6 +355,13 @@ endif
 
 ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2),y)
 GST1_PLUGINS_GOOD_CONF_OPTS += -Dv4l2=enabled
+# Enable use of gudev if available, for device probing and monitoring.
+ifeq ($(BR2_PACKAGE_LIBGUDEV),y)
+GST1_PLUGINS_GOOD_DEPENDENCIES += libgudev
+GST1_PLUGINS_GOOD_CONF_OPTS += -Dv4l2-gudev=enabled
+else
+GST1_PLUGINS_GOOD_CONF_OPTS += -Dv4l2-gudev=disabled
+endif
 else
 GST1_PLUGINS_GOOD_CONF_OPTS += -Dv4l2=disabled
 endif
--

2.26.0.rc2

#2 lore raw

PATCH v3 1/1 package/gstreamer1/gst1-plugins-good: Enable GUDEV for V4L2 if available

In reply to Ezequiel Garcia

Nicolas, Ezequiel, All,

On 2020-06-07 21:00 -0300, Ezequiel Garcia spake thusly:

Quoted 6 lines

From: Nicolas Dufresne <[email protected]>

Video4Linux2 plugins can udev for device probing and monitor. This greatly improves load time and monitoring performance.

It also enables hotplug monitoring for cameras.

Here, I've added a blurb explaining why we do not propagate the dependencies from libgudev eventhough we select it.

I am always a bit conflicted that we don't do that explicitly, even if superfluous.

But heck, the libglib2 world is not ready to drop the existing dependencies (MMU, wchar, and threads) anytime soon, so this ought to be enough for everybody (famous last words).

Quoted 2 lines

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 43 lines

---
v3:
* Apply the dependency only if V4L2 plugins are enabled v2:
* Enable/disable v4l2-gudev explicitly

 package/gstreamer1/gst1-plugins-good/Config.in            | 1 +
 package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 7 +++++++
 2 files changed, 8 insertions(+)
package/gstreamer1/gst1-plugins-good/Config.in +1 -0
index 20aebc473e89..be77f5a82e3d 100644
@@ -295,6 +295,7 @@ config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2
 config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2
 	bool "v4l2"
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # multi planar api
+	select BR2_PACKAGE_LIBGUDEV if BR2_PACKAGE_HAS_UDEV
 	help
 	  elements for Video 4 Linux
 
package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +7 -0
index 223af9850897..7bb2fa5f3720 100644
@@ -355,6 +355,13 @@ endif
 
 ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2),y)
 GST1_PLUGINS_GOOD_CONF_OPTS += -Dv4l2=enabled
+# Enable use of gudev if available, for device probing and monitoring.
+ifeq ($(BR2_PACKAGE_LIBGUDEV),y)
+GST1_PLUGINS_GOOD_DEPENDENCIES += libgudev
+GST1_PLUGINS_GOOD_CONF_OPTS += -Dv4l2-gudev=enabled
+else
+GST1_PLUGINS_GOOD_CONF_OPTS += -Dv4l2-gudev=disabled
+endif
 else
 GST1_PLUGINS_GOOD_CONF_OPTS += -Dv4l2=disabled
 endif
Signature · 1 line
2.26.0.rc2
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH v3 1/1 package/gstreamer1/gst1-plugins-good: Enable GUDEV for V4L2 if available

In reply to Ezequiel Garcia
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ezequiel" == Ezequiel Garcia <[email protected]> writes:

From: Nicolas Dufresne <[email protected]> Video4Linux2 plugins can udev for device probing and monitor. This greatly improves load time and monitoring performance.

It also enables hotplug monitoring for cameras.

Quoted 7 lines

---
v3:
* Apply the dependency only if V4L2 plugins are enabled v2:
* Enable/disable v4l2-gudev explicitly

Committed to 2020.02.x and 2020.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard