powerpc/powernv: machine check handler for POWER10
Nicholas Piggin
reviewerPATCH 1/1 powerpc/powernv: machine check handler for POWER10
--- arch/powerpc/include/asm/mce.h | 1 + arch/powerpc/kernel/dt_cpu_ftrs.c | 10 ++++ arch/powerpc/kernel/mce.c | 1 + arch/powerpc/kernel/mce_power.c | 84 +++++++++++++++++++++++++++++++ 4 files changed, 96 insertions(+)
arch/powerpc/include/asm/mce.h +1 -0
@@ -86,6 +86,7 @@ enum MCE_TlbErrorType {enum MCE_UserErrorType {MCE_USER_ERROR_INDETERMINATE =0 ,MCE_USER_ERROR_TLBIE =1 , +MCE_USER_ERROR_SCV =2 , };enum MCE_RaErrorType {
arch/powerpc/kernel/dt_cpu_ftrs.c +10 -0
@@ -67,6 +67,7 @@ struct dt_cpu_feature {extern long __machine_check_early_realmode_p8 (struct pt_regs *regs);extern long __machine_check_early_realmode_p9 (struct pt_regs *regs); +extern long __machine_check_early_realmode_p10 (struct pt_regs *regs);static int hv_mode;
@@ -450,6 +451,14 @@ static int __init feat_enable_pmu_power9(struct dt_cpu_feature *f)return 1 ; } +static int __init feat_enable_mce_power10 (struct dt_cpu_feature *f) +{ + cur_cpu_spec->platform ="power10" ; + cur_cpu_spec->machine_check_early = __machine_check_early_realmode_p10; + +return 1 ; +} +static int __init feat_enable_tm (struct dt_cpu_feature *f) {#ifdef CONFIG_PPC_TRANSACTIONAL_MEM
@@ -638,6 +647,7 @@ static struct dt_cpu_feature_match __initdata {"group-start-register", feat_enable, 0}, {"pc-relative-addressing", feat_enable, 0}, {"machine-check-power9", feat_enable_mce_power9, 0}, + {"machine-check-power10", feat_enable_mce_power10, 0}, {"performance-monitor-power9", feat_enable_pmu_power9, 0}, {"event-based-branch-v3", feat_enable, 0}, {"random-number-generator", feat_enable, 0},
arch/powerpc/kernel/mce.c +1 -0
@@ -370,6 +370,7 @@ void machine_check_print_event_info(struct machine_check_event *evt,static const char *mc_user_types[] = {"Indeterminate" ,"tlbie(l) invalid" , +"scv invalid" , };static const char *mc_ra_types[] = {"Indeterminate" ,
arch/powerpc/kernel/mce_power.c +84 -0
99 lines not on this page · raw message
Signature · 1 line
2.23.0
kernel test robot
build botI love your patch! Perhaps something to improve:
Hi Nicholas,
I love your patch! Perhaps something to improve:
[auto build test WARNING on powerpc/next]
[also build test WARNING on v5.8-rc3 next-20200702]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/powerpc-powernv-machine-check-handler-for-POWER10/20200703-073739 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-allyesconfig (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
All warnings (new ones prefixed by >>):
arch/powerpc/kernel/mce_power.c:709:6: warning: no previous prototype for '__machine_check_early_realmode_p7' [-Wmissing-prototypes]
709 | long __machine_check_early_realmode_p7(struct pt_regs *regs)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/kernel/mce_power.c:717:6: warning: no previous prototype for '__machine_check_early_realmode_p8' [-Wmissing-prototypes]
717 | long __machine_check_early_realmode_p8(struct pt_regs *regs)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/kernel/mce_power.c:722:6: warning: no previous prototype for '__machine_check_early_realmode_p9' [-Wmissing-prototypes]
722 | long __machine_check_early_realmode_p9(struct pt_regs *regs)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> arch/powerpc/kernel/mce_power.c:740:6: warning: no previous prototype for '__machine_check_early_realmode_p10' [-Wmissing-prototypes]
740 | long __machine_check_early_realmode_p10(struct pt_regs *regs)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/__machine_check_early_realmode_p10 +740 arch/powerpc/kernel/mce_power.c
739
> 740 long __machine_check_early_realmode_p10(struct pt_regs *regs)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
Michael Ellerman
AppliedQuoted 1 line · Nicholas Piggin
Applied to powerpc/next.
[1/1] powerpc/powernv: Machine check handler for POWER10
https://git.kernel.org/powerpc/c/201220bb0e8cbc163ec7f550b3b7b3da46eb5877
cheers