Skip to contentSkip to conversation

meta-arm: Use dynamic layer magic to build trusted-firmware-m

PATCH In review Khem Raj 4 participants 10 messages Jul 3, 2020 – Jul 14, 2020

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 meta-arm: Use dynamic layer magic to build trusted-firmware-m

trusted-firmware-m needs arm binary toolchain to build from another layer, this is the only recipe thus far and its better to hide it to majority users who may not be using trusted-firmware-m and thusly meta-arm-toolchain, folks who need to use trusted-firmware-m should explicitly add it to layer mix

---
 meta-arm/conf/layer.conf                                    | 6 +++++-
 .../trusted-firmware-m/trusted-firmware-m_1.0.bb            | 0
 2 files changed, 5 insertions(+), 1 deletion(-)
 rename meta-arm/{ => dynamic-layers/arm-toolchain}/recipes-bsp/trusted-firmware-m/trusted-firmware-m_1.0.bb (100%)
meta-arm/conf/layer.conf +5 -1
index 10a7951..2d0c49f 100644
@@ -11,6 +11,10 @@ BBFILE_PRIORITY_meta-arm = "6"
 
 LAYERDEPENDS_meta-arm = " \
     core \
-    arm-toolchain \
 "
 LAYERSERIES_COMPAT_meta-arm = "warrior zeus dunfell"
+
+BBFILES_DYNAMIC += " \
+    arm-toolchain:${LAYERDIR}/dynamic-layers/arm-toolchain/*/*/*.bb \
+    arm-toolchain:${LAYERDIR}/dynamic-layers/arm-toolchain/*/*/*.bbappend \
+"
meta-arm/dynamic-layers/arm-toolchain/recipes-bsp/trusted-firmware-m/trusted-firmware-m_1.0.bb renamed from meta-arm/recipes-bsp/trusted-firmware-m/trusted-firmware-m_1.0.bb +0 -0
similarity index 100%
rename from meta-arm/recipes-bsp/trusted-firmware-m/trusted-firmware-m_1.0.bb
rename to meta-arm/dynamic-layers/arm-toolchain/recipes-bsp/trusted-firmware-m/trusted-firmware-m_1.0.bb
Signature · 1 line
2.27.0
#1 lore raw

meta-arm/dynamic-layers/arm-toolchain/recipes-bsp/trusted-firmware-m/trusted-firmware-m_1.0.bb

Quoted 33 lines · Khem Raj

trusted-firmware-m needs arm binary toolchain to build from another layer, this is the only recipe thus far and its better to hide it to majority users who may not be using trusted-firmware-m and thusly meta-arm-toolchain, folks who need to use trusted-firmware-m should explicitly add it to layer mix

---
 meta-arm/conf/layer.conf                                    | 6 +++++-
 .../trusted-firmware-m/trusted-firmware-m_1.0.bb            | 0
 2 files changed, 5 insertions(+), 1 deletion(-)
 rename meta-arm/{ => dynamic-layers/arm-toolchain}/recipes-bsp/trusted-firmware-m/trusted-firmware-m_1.0.bb (100%)
meta-arm/conf/layer.conf +5 -1
index 10a7951..2d0c49f 100644
@@ -11,6 +11,10 @@ BBFILE_PRIORITY_meta-arm = "6"
 
 LAYERDEPENDS_meta-arm = " \
     core \
-    arm-toolchain \
 "
 LAYERSERIES_COMPAT_meta-arm = "warrior zeus dunfell"
+
+BBFILES_DYNAMIC += " \
+    arm-toolchain:${LAYERDIR}/dynamic-layers/arm-toolchain/*/*/*.bb \
+    arm-toolchain:${LAYERDIR}/dynamic-layers/arm-toolchain/*/*/*.bbappend \
+"
meta-arm/dynamic-layers/arm-toolchain/recipes-bsp/trusted-firmware-m/trusted-firmware-m_1.0.bb renamed from meta-arm/recipes-bsp/trusted-firmware-m/trusted-firmware-m_1.0.bb +0 -0
similarity index 100%
rename from meta-arm/recipes-bsp/trusted-firmware-m/trusted-firmware-m_1.0.bb
rename to meta-arm/dynamic-layers/arm-toolchain/recipes-bsp/trusted-firmware-m/trusted-firmware-m_1.0.bb

Ross asked to add meta-arm to the autobuilder and I agreed on the basis it was passing testing. Due to this change all full builds are now red again :(

https://autobuilder.yoctoproject.org/typhoon/#/builders/113/builds/11

Cheers,

Richard

#2 lore raw
Quoted 39 lines · Richard Purdie

meta-arm/dynamic-layers/arm-toolchain/recipes-bsp/trusted-firmware-m/trusted-firmware-m_1.0.bb

Quoted 33 lines · Khem Raj

trusted-firmware-m needs arm binary toolchain to build from another layer, this is the only recipe thus far and its better to hide it to majority users who may not be using trusted-firmware-m and thusly meta-arm-toolchain, folks who need to use trusted-firmware-m should explicitly add it to layer mix

---
 meta-arm/conf/layer.conf                                    | 6 +++++-
 .../trusted-firmware-m/trusted-firmware-m_1.0.bb            | 0
 2 files changed, 5 insertions(+), 1 deletion(-)
 rename meta-arm/{ => dynamic-layers/arm-toolchain}/recipes-bsp/trusted-firmware-m/trusted-firmware-m_1.0.bb (100%)
meta-arm/conf/layer.conf +5 -1
index 10a7951..2d0c49f 100644
@@ -11,6 +11,10 @@ BBFILE_PRIORITY_meta-arm = "6"
 
 LAYERDEPENDS_meta-arm = " \
     core \
-    arm-toolchain \
 "
 LAYERSERIES_COMPAT_meta-arm = "warrior zeus dunfell"
+
+BBFILES_DYNAMIC += " \
+    arm-toolchain:${LAYERDIR}/dynamic-layers/arm-toolchain/*/*/*.bb \
+    arm-toolchain:${LAYERDIR}/dynamic-layers/arm-toolchain/*/*/*.bbappend \
+"
meta-arm/dynamic-layers/arm-toolchain/recipes-bsp/trusted-firmware-m/trusted-firmware-m_1.0.bb renamed from meta-arm/recipes-bsp/trusted-firmware-m/trusted-firmware-m_1.0.bb +0 -0
similarity index 100%
rename from meta-arm/recipes-bsp/trusted-firmware-m/trusted-firmware-m_1.0.bb
rename to meta-arm/dynamic-layers/arm-toolchain/recipes-bsp/trusted-firmware-m/trusted-firmware-m_1.0.bb

Ross asked to add meta-arm to the autobuilder and I agreed on the basis it was passing testing. Due to this change all full builds are now red again :(

Quoted 1 line

https://autobuilder.yoctoproject.org/typhoon/#/builders/113/builds/11

FWIW, this has been discussed at length here:
https://lists.yoctoproject.org/g/meta-arm/topic/patch_4_6_arm/75033886

Signature · 1 line
Denys
#3 lore raw
In reply to Richard Purdie
Quoted 6 lines · Richard Purdie
Quoted 5 lines · Khem Raj

trusted-firmware-m needs arm binary toolchain to build from another layer, this is the only recipe thus far and its better to hide it to majority users who may not be using trusted-firmware-m and thusly meta-arm-toolchain, folks who need to use trusted-firmware-m should explicitly add it to layer mix

My fault: the layer ordering wasn't quite as important before, but it is now. Testing a fix to autobuilder-helper now.

Ross

#4 lore raw

Update: Richard has merged the fix. Hopefully that now results in a green build!

Ross

Quoted 14 lines · Ross Burton
Quoted 6 lines · Richard Purdie
Quoted 5 lines · Khem Raj

trusted-firmware-m needs arm binary toolchain to build from another layer, this is the only recipe thus far and its better to hide it to majority users who may not be using trusted-firmware-m and thusly meta-arm-toolchain, folks who need to use trusted-firmware-m should explicitly add it to layer mix

My fault: the layer ordering wasn't quite as important before, but it is now. Testing a fix to autobuilder-helper now.

Ross

author
#5 lore raw
Quoted 3 lines · Ross Burton

Update: Richard has merged the fix. Hopefully that now results in a green build!

this does not fix the problem for other distributions which are using meta-arm as dependency. this patch would still be better option IMO to avoid this dependency when not needed.

Quoted 17 lines

Ross

Quoted 14 lines · Ross Burton
Quoted 6 lines · Richard Purdie
Quoted 5 lines · Khem Raj

trusted-firmware-m needs arm binary toolchain to build from another layer, this is the only recipe thus far and its better to hide it to majority users who may not be using trusted-firmware-m and thusly meta-arm-toolchain, folks who need to use trusted-firmware-m should explicitly add it to layer mix

My fault: the layer ordering wasn't quite as important before, but it is now. Testing a fix to autobuilder-helper now.

Ross

#6 lore raw
In reply to Khem Raj

meta-arm/conf/layer.conf BBFILE_PRIORITY_meta-arm = "6" · line 19

Quoted 3 lines · Khem Raj
meta-arm/conf/layer.conf +3 -0
+BBFILES_DYNAMIC += " \
+    arm-toolchain:${LAYERDIR}/dynamic-layers/arm-toolchain/*/*/*.bb \
+    arm-toolchain:${LAYERDIR}/dynamic-layers/arm-toolchain/*/*/*.bbappend \

What I dislike about dynamic layers is how nested everything gets. How about something more like:

BBFILES_DYNAMIC += "arm-toolchain:${LAYERDIR}/with-arm-toolchain/recipes-*/*/*.bb"

One less directory level, and all of the dynamic layers are at the top-level alongside the recipes.

I'm also still unsure why there's so much pushback towards adding arm-toolchain. It doesn't do anything by simply adding the layer, if you don't build tf-m it won't get used at all, and I want to get rid of it anyway (using multiconfig to build a gcc). Can you explain why this dependency is so important to you? I'm obviously not understanding something, and I'm on the record for hating on binary toolchains over many years!

Ross

author
#7 lore raw
Quoted 8 lines · Ross Burton

meta-arm/conf/layer.conf BBFILE_PRIORITY_meta-arm = "6" · line 19

Quoted 3 lines · Khem Raj
meta-arm/conf/layer.conf +3 -0
+BBFILES_DYNAMIC += " \
+    arm-toolchain:${LAYERDIR}/dynamic-layers/arm-toolchain/*/*/*.bb \
+    arm-toolchain:${LAYERDIR}/dynamic-layers/arm-toolchain/*/*/*.bbappend \

What I dislike about dynamic layers is how nested everything gets. How about something more like:

Quoted 8 lines

BBFILES_DYNAMIC += "arm-toolchain:${LAYERDIR}/with-arm-toolchain/recipes-*/*/*.bb"

One less directory level, and all of the dynamic layers are at the top-level alongside the recipes.

I'm also still unsure why there's so much pushback towards adding arm-toolchain.

reason meta-arm is needed for me is becuase meta-ti asks for it and now there is another dependency added so I am a bit not-nice to this because this serves no use for me as tf-a and tf-m are not even needed for machines of interest, but it does show up on world builds and broke last time.

It doesn't do anything by simply adding the layer, if

Quoted 8 lines

you don't build tf-m it won't get used at all, and I want to get rid of it anyway (using multiconfig to build a gcc). Can you explain why this dependency is so important to you? I'm obviously not understanding something, and I'm on the record for hating on binary toolchains over many years!

Ross

author
#8 lore raw
In reply to Ross Burton
Quoted 14 lines · Ross Burton

meta-arm/conf/layer.conf BBFILE_PRIORITY_meta-arm = "6" · line 19

Quoted 3 lines · Khem Raj
meta-arm/conf/layer.conf +3 -0
+BBFILES_DYNAMIC += " \
+    arm-toolchain:${LAYERDIR}/dynamic-layers/arm-toolchain/*/*/*.bb \
+    arm-toolchain:${LAYERDIR}/dynamic-layers/arm-toolchain/*/*/*.bbappend \

What I dislike about dynamic layers is how nested everything gets. How about something more like:

BBFILES_DYNAMIC += "arm-toolchain:${LAYERDIR}/with-arm-toolchain/recipes-*/*/*.bb"

One less directory level, and all of the dynamic layers are at the top-level alongside the recipes.

Quoted 8 lines

I'm also still unsure why there's so much pushback towards adding arm-toolchain. It doesn't do anything by simply adding the layer, if you don't build tf-m it won't get used at all, and I want to get rid of it anyway (using multiconfig to build a gcc). Can you explain why this dependency is so important to you? I'm obviously not understanding something, and I'm on the record for hating on binary toolchains over many years!

So I have added meta-arm-toolchain to distro ( ever to reluctantly ) and it did not break anything so I intend to keep that change, therefore this patch is no longer required for my usecase and can be ignored.

Quoted 2 lines

Ross

#9 lore raw
Quoted 3 lines · Khem Raj

So I have added meta-arm-toolchain to distro ( ever to reluctantly ) and it did not break anything so I intend to keep that change, therefore this patch is no longer required for my usecase and can be ignored.

Thanks for the update Khem. I have removing the need for binary toolchains on my todo list.

Ross