Skip to contentSkip to conversation

MAINTAINERS: Cover the firmware JSON schema

RFC PATCH Superseded Philippe Mathieu-Daudé 4 participants 6 messages Jul 3, 2020

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 MAINTAINERS: Cover the firmware JSON schema

Add an entry to cover firmware.json (see commit 3a0adfc9bf:
schema that describes the different uses and properties of virtual machine firmware).
Cc the libvirt maintainers if it ever changes.

Cc Laszlo Ersek <[email protected]>
Cc Daniel P. Berrange <[email protected]>
Cc Gerd Hoffmann <[email protected]>
Cc Kashyap Chamarthy <[email protected]>
Cc Michael S. Tsirkin <[email protected]>

---
Based on a comment from Laszlo:
https://www.mail-archive.com/[email protected]/msg604925.html

I don't think Laszlo should be the sole maintainer, not sure who else should be listed. Gerd and Kashyap? :) Can we add it 'maintained' without specific maintainer?

---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)
MAINTAINERS +6 -0
index dec252f38b..57c90201df 100644
@@ -2601,6 +2601,12 @@ F: include/hw/i2c/smbus_master.h
 F: include/hw/i2c/smbus_slave.h
 F: include/hw/i2c/smbus_eeprom.h
 
+Firmware schema specifications
+M: Laszlo Ersek <[email protected]>
+R: [email protected]
+S: Maintained
+F: docs/interop/firmware.json
+
 EDK2 Firmware
 M: Laszlo Ersek <[email protected]>
 M: Philippe Mathieu-Daudé <[email protected]>
Signature · 1 line
2.21.3
#1 lore raw
Quoted 28 lines · Philippe Mathieu-Daudé

Add an entry to cover firmware.json (see commit 3a0adfc9bf:
schema that describes the different uses and properties of virtual machine firmware).
Cc the libvirt maintainers if it ever changes.

Cc Laszlo Ersek <[email protected]>
Cc Daniel P. Berrange <[email protected]>
Cc Gerd Hoffmann <[email protected]>
Cc Kashyap Chamarthy <[email protected]>
Cc Michael S. Tsirkin <[email protected]>

---
Based on a comment from Laszlo:
https://www.mail-archive.com/[email protected]/msg604925.html

I don't think Laszlo should be the sole maintainer, not sure who else should be listed. Gerd and Kashyap? :) Can we add it 'maintained' without specific maintainer?

---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)
MAINTAINERS +0 -0
index dec252f38b..57c90201df 100644

MAINTAINERS F: include/hw/i2c/smbus_master.h · line 2606

Quoted 6 lines
MAINTAINERS +3 -0
@@ -2601,6 +2601,12 @@ F: include/hw/i2c/smbus_master.h
 F: include/hw/i2c/smbus_slave.h
 F: include/hw/i2c/smbus_eeprom.h
 
+Firmware schema specifications
+M: Laszlo Ersek <[email protected]>
+R: [email protected]

FWIW, I don't think libvirt needs to review this. Our firmware handling code doesn't really care what specific files exist - it just follows the declared logic to pick amongst whatever exists.

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#2 lore raw
Quoted 32 lines · Daniel P. Berrangé
Quoted 31 lines · Philippe Mathieu-Daudé

Add an entry to cover firmware.json (see commit 3a0adfc9bf:
schema that describes the different uses and properties of virtual machine firmware).
Cc the libvirt maintainers if it ever changes.

Cc Laszlo Ersek <[email protected]>
Cc Daniel P. Berrange <[email protected]>
Cc Gerd Hoffmann <[email protected]>
Cc Kashyap Chamarthy <[email protected]>
Cc Michael S. Tsirkin <[email protected]>

---
Based on a comment from Laszlo:
https://www.mail-archive.com/[email protected]/msg604925.html

I don't think Laszlo should be the sole maintainer, not sure who else should be listed. Gerd and Kashyap? :) Can we add it 'maintained' without specific maintainer?

---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)
MAINTAINERS +0 -0
index dec252f38b..57c90201df 100644
@@ -2601,6 +2601,12 @@ F: include/hw/i2c/smbus_master.h
 F: include/hw/i2c/smbus_slave.h
 F: include/hw/i2c/smbus_eeprom.h
 
Quoted 7 lines

MAINTAINERS F: include/hw/i2c/smbus_master.h · line 2606

Quoted 3 lines
MAINTAINERS +3 -0
+Firmware schema specifications
+M: Laszlo Ersek <[email protected]>
+R: [email protected]

FWIW, I don't think libvirt needs to review this. Our firmware handling code doesn't really care what specific files exist - it just follows the declared logic to pick amongst whatever exists.

I request that

- Phil be listed please as another maintainer (so there are two people that can send pull requests, if a 3rd person needs to patch this file for whatever reason),

- Dan be listed please *at least* as an "R" person; the business logic written up under the @Firmware element, and lots of the initial review comments (in particular the suggestion to mention specific QEMU command line switches in the schema), had come from him.

If Dan is willing to be an "M", then we can collapse both of my above requests into one, and Phil wouldn't have to be listed (Dan could both review suggested changes and submit pull requests). However, I'm raising this only as a technical possibility; what really matters to me is that Dan be CC'd on suggested changes, and that someone other than me can submit PRs if necessary.

Thanks!
Laszlo

#3 lore raw
Quoted 52 lines · Laszlo Ersek
Quoted 32 lines · Daniel P. Berrangé
Quoted 31 lines · Philippe Mathieu-Daudé

Add an entry to cover firmware.json (see commit 3a0adfc9bf:
schema that describes the different uses and properties of virtual machine firmware).
Cc the libvirt maintainers if it ever changes.

Cc Laszlo Ersek <[email protected]>
Cc Daniel P. Berrange <[email protected]>
Cc Gerd Hoffmann <[email protected]>
Cc Kashyap Chamarthy <[email protected]>
Cc Michael S. Tsirkin <[email protected]>

---
Based on a comment from Laszlo:
https://www.mail-archive.com/[email protected]/msg604925.html

I don't think Laszlo should be the sole maintainer, not sure who else should be listed. Gerd and Kashyap? :) Can we add it 'maintained' without specific maintainer?

---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)
MAINTAINERS +0 -0
index dec252f38b..57c90201df 100644
@@ -2601,6 +2601,12 @@ F: include/hw/i2c/smbus_master.h
 F: include/hw/i2c/smbus_slave.h
 F: include/hw/i2c/smbus_eeprom.h
 
Quoted 7 lines

MAINTAINERS F: include/hw/i2c/smbus_master.h · line 2606

Quoted 3 lines
MAINTAINERS +3 -0
+Firmware schema specifications
+M: Laszlo Ersek <[email protected]>
+R: [email protected]

FWIW, I don't think libvirt needs to review this. Our firmware handling code doesn't really care what specific files exist - it just follows the declared logic to pick amongst whatever exists.

I request that

- Phil be listed please as another maintainer (so there are two people that can send pull requests, if a 3rd person needs to patch this file for whatever reason),

- Dan be listed please *at least* as an "R" person; the business logic written up under the @Firmware element, and lots of the initial review comments (in particular the suggestion to mention specific QEMU command line switches in the schema), had come from him.

Quoted 6 lines

If Dan is willing to be an "M", then we can collapse both of my above requests into one, and Phil wouldn't have to be listed (Dan could both review suggested changes and submit pull requests). However, I'm raising this only as a technical possibility; what really matters to me is that Dan be CC'd on suggested changes, and that someone other than me can submit PRs if necessary.

I'm fine with "R", but don't want to be "M" as I don't want to be responsible for queueing patches, etc on more parts of QEMU.

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#4 lore raw
Quoted 60 lines · Daniel P. Berrangé
Quoted 52 lines · Laszlo Ersek
Quoted 32 lines · Daniel P. Berrangé
Quoted 31 lines · Philippe Mathieu-Daudé

Add an entry to cover firmware.json (see commit 3a0adfc9bf:
schema that describes the different uses and properties of virtual machine firmware).
Cc the libvirt maintainers if it ever changes.

Cc Laszlo Ersek <[email protected]>
Cc Daniel P. Berrange <[email protected]>
Cc Gerd Hoffmann <[email protected]>
Cc Kashyap Chamarthy <[email protected]>
Cc Michael S. Tsirkin <[email protected]>

---
Based on a comment from Laszlo:
https://www.mail-archive.com/[email protected]/msg604925.html

I don't think Laszlo should be the sole maintainer, not sure who else should be listed. Gerd and Kashyap? :) Can we add it 'maintained' without specific maintainer?

---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)
MAINTAINERS +0 -0
index dec252f38b..57c90201df 100644
@@ -2601,6 +2601,12 @@ F: include/hw/i2c/smbus_master.h
 F: include/hw/i2c/smbus_slave.h
 F: include/hw/i2c/smbus_eeprom.h
 
Quoted 7 lines

MAINTAINERS F: include/hw/i2c/smbus_master.h · line 2606

Quoted 3 lines
MAINTAINERS +3 -0
+Firmware schema specifications
+M: Laszlo Ersek <[email protected]>
+R: [email protected]

FWIW, I don't think libvirt needs to review this. Our firmware handling code doesn't really care what specific files exist - it just follows the declared logic to pick amongst whatever exists.

I request that

- Phil be listed please as another maintainer (so there are two people that can send pull requests, if a 3rd person needs to patch this file for whatever reason),

- Dan be listed please *at least* as an "R" person; the business logic written up under the @Firmware element, and lots of the initial review comments (in particular the suggestion to mention specific QEMU command line switches in the schema), had come from him.

Quoted 6 lines

If Dan is willing to be an "M", then we can collapse both of my above requests into one, and Phil wouldn't have to be listed (Dan could both review suggested changes and submit pull requests). However, I'm raising this only as a technical possibility; what really matters to me is that Dan be CC'd on suggested changes, and that someone other than me can submit PRs if necessary.

Quoted 2 lines

I'm fine with "R", but don't want to be "M" as I don't want to be responsible for queueing patches, etc on more parts of QEMU.

Thanks all! I'm queuing this patch as:

Firmware schema specifications
M: Laszlo Ersek <[email protected]>
M: Philippe Mathieu-Daudé <[email protected]>
R: Daniel P. Berrange <[email protected]>
R: Kashyap Chamarthy <[email protected]>
S: Maintained
F: docs/interop/firmware.json

Regards,

Phil.

#5 lore raw
In reply to Philippe Mathieu-Daudé
Quoted 12 lines · Philippe Mathieu-Daudé

Add an entry to cover firmware.json (see commit 3a0adfc9bf:
schema that describes the different uses and properties of virtual machine firmware).
Cc the libvirt maintainers if it ever changes.

Cc Laszlo Ersek <[email protected]>
Cc Daniel P. Berrange <[email protected]>
Cc Gerd Hoffmann <[email protected]>
Cc Kashyap Chamarthy <[email protected]>
Cc Michael S. Tsirkin <[email protected]>
Quoted 6 lines

---
Based on a comment from Laszlo:
https://www.mail-archive.com/[email protected]/msg604925.html

I don't think Laszlo should be the sole maintainer, not sure who else should be listed. Gerd and Kashyap? :)

Hiya,

I'm a mere enthusiastic user of firmware.json. :-) The original design heavy-lifting[*] was done by Dan, Gerd, and Laszlo. That said, I'm happy to be Cced on patches to it, and review changes to the extent I can.

[*] https://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg01978.html
— [RFC] Defining firmware (OVMF, et al) metadata format & file

Quoted 25 lines

Can we add it 'maintained' without specific maintainer?

---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)
MAINTAINERS +6 -0
index dec252f38b..57c90201df 100644
@@ -2601,6 +2601,12 @@ F: include/hw/i2c/smbus_master.h
 F: include/hw/i2c/smbus_slave.h
 F: include/hw/i2c/smbus_eeprom.h
 
+Firmware schema specifications
+M: Laszlo Ersek <[email protected]>
+R: [email protected]
+S: Maintained
+F: docs/interop/firmware.json
+
 EDK2 Firmware
 M: Laszlo Ersek <[email protected]>
 M: Philippe Mathieu-Daudé <[email protected]>
Signature · 1 line
2.21.3
Signature · 1 line
/kashyap