PINE64 Rock64 - How to get SPI driver working
Subsystems (4)
Hello,
I just compiled U-Boot v2020.04 for a PINE64 Rock media board. It compiles fine without errors, but when I try to probe the on board flash I get an error:
=> sf probe
Invalid bus 0 (err=-19)
Failed to initialize SPI flash at 0:0 (error -19)
=>
SPI is activated in the Device-Tree blob. I also added support to the Rockchip SPI driver (added IDS strings for this SoC).
In the device config I added the following:
CONFIG_SPI=yCONFIG_ROCKCHIP_SPI=yCONFIG_SPI_FLASH=y
But the driver still doesn't work. Output of DM (shortened):
=> dm tree
[...]
spi 0 [ ] rockchip_spi |-- spi at ff190000
spi_flash 0 [ ] spi_flash_std | `-- spiflash at 0
[...]
What is missing? Is there a way to load driver?
Any kind of help is highly appreciated.
Signature · 3 lines
Kind regards, Johannes K.
Hello,
I want to add a helper function to uboot i.e
uboot# help
will show a list of commands. I want to add 1 for my own private command. which file contains the list of cmd that will be displayed and the indirection?
thanks
-kamal
Quoted 38 lines · Johannes Krottmayer
Hello,
I just compiled U-Boot v2020.04 for a PINE64 Rock media board. It compiles fine without errors, but when I try to probe the on board flash I get an error:
=> sf probe
Invalid bus 0 (err=-19)
Failed to initialize SPI flash at 0:0 (error -19)
=>SPI is activated in the Device-Tree blob. I also added support to the Rockchip SPI driver (added IDS strings for this SoC).
In the device config I added the following:
CONFIG_SPI=yCONFIG_ROCKCHIP_SPI=yCONFIG_SPI_FLASH=yBut the driver still doesn't work. Output of DM (shortened):
=> dm tree
[...]
spi 0 [ ]rockchip_spi|-- spi atff190000
spi_flash0 [ ]spi_flash_std| `-- spiflash at 0
[...]What is missing? Is there a way to load driver?
Any kind of help is highly appreciated.
--
Kind regards,Johannes K.
Jagan may some idea here.
I would suggest you to add some log in the spi/flash driver for bind, probe and etc
to check what's wrong.
Thanks,
- Kever
Quoted 33 lines · Johannes Krottmayer
Hello,
I just compiled U-Boot v2020.04 for a PINE64 Rock media board. It compiles fine without errors, but when I try to probe the on board flash I get an error:
=> sf probe
Invalid bus 0 (err=-19)
Failed to initialize SPI flash at 0:0 (error -19)
=>SPI is activated in the Device-Tree blob. I also added support to the Rockchip SPI driver (added IDS strings for this SoC).
In the device config I added the following:
CONFIG_SPI=yCONFIG_ROCKCHIP_SPI=yCONFIG_SPI_FLASH=yBut the driver still doesn't work. Output of DM (shortened):
=> dm tree
[...]
spi 0 [ ]rockchip_spi|-- spi atff190000
spi_flash0 [ ]spi_flash_std| `-- spiflash at 0
[...]What is missing? Is there a way to load driver?
Any kind of help is highly appreciated.
Hi Kever,
I think you answered the wrong person. :)
Okay, thanks for the suggestions.
I will check the sources. There was also a missing alias in the Device-Tree source. I have added the specific alias for the SPI bus. Now I'm getting the error code -2.
I'm new with U-Boot and the source code itself, but I think the problem occurs still in the device tree file for the specific board.
Cheers,
Johannes K.
Quoted 49 lines · Kever Yang
Jagan may some idea here.
I would suggest you to add some log in the spi/flash driver for bind, probe and etc
to check what's wrong.
Thanks,
- Kever
Quoted 33 lines · Johannes Krottmayer
Hello,
I just compiled U-Boot v2020.04 for a PINE64 Rock media board. It compiles fine without errors, but when I try to probe the on board flash I get an error:
=> sf probe
Invalid bus 0 (err=-19)
Failed to initialize SPI flash at 0:0 (error -19)
=>SPI is activated in the Device-Tree blob. I also added support to the Rockchip SPI driver (added IDS strings for this SoC).
In the device config I added the following:
CONFIG_SPI=yCONFIG_ROCKCHIP_SPI=yCONFIG_SPI_FLASH=yBut the driver still doesn't work. Output of DM (shortened):
=> dm tree
[...]
spi 0 [ ]rockchip_spi|-- spi atff190000
spi_flash0 [ ]spi_flash_std| `-- spiflash at 0
[...]What is missing? Is there a way to load driver?
Any kind of help is highly appreciated.
Quoted 10 lines · Johannes Krottmayer
Hi Kever,
I think you answered the wrong person. :)
Okay, thanks for the suggestions.
I will check the sources. There was also a missing alias in the Device-Tree source. I have added the specific alias for the SPI bus. Now I'm getting the error code -2.
Make sure you enable the driver for the actual flash chip too, some of the popular ones are:CONFIG_SPI_FLASH_WINBOND=yCONFIG_SPI_FLASH_MACRONIX=yCONFIG_SPI_FLASH_SPANSION=yCONFIG_SPI_FLASH_GIGADEVICE=y
Quoted 59 lines
I'm new with U-Boot and the source code itself, but I think the problem occurs still in the device tree file for the specific board.
Cheers,
Johannes K.
Quoted 49 lines · Kever Yang
Jagan may some idea here.
I would suggest you to add some log in the spi/flash driver for bind, probe and etc
to check what's wrong.
Thanks,
- Kever
Quoted 33 lines · Johannes Krottmayer
Hello,
I just compiled U-Boot v2020.04 for a PINE64 Rock media board. It compiles fine without errors, but when I try to probe the on board flash I get an error:
=> sf probe
Invalid bus 0 (err=-19)
Failed to initialize SPI flash at 0:0 (error -19)
=>SPI is activated in the Device-Tree blob. I also added support to the Rockchip SPI driver (added IDS strings for this SoC).
In the device config I added the following:
CONFIG_SPI=yCONFIG_ROCKCHIP_SPI=yCONFIG_SPI_FLASH=yBut the driver still doesn't work. Output of DM (shortened):
=> dm tree
[...]
spi 0 [ ]rockchip_spi|-- spi atff190000
spi_flash0 [ ]spi_flash_std| `-- spiflash at 0
[...]What is missing? Is there a way to load driver?
Any kind of help is highly appreciated.
Sorry for my late response.
Thanks for the suggestions.
Quoted 6 lines · Peter Robinson
Make sure you enable the driver for the actual flash chip too, some of the popular ones are:
CONFIG_SPI_FLASH_WINBOND=yCONFIG_SPI_FLASH_MACRONIX=yCONFIG_SPI_FLASH_SPANSION=yCONFIG_SPI_FLASH_GIGADEVICE=y
I have enabled 'CONFIG_SPI_FLASH_GIGADEVICE'. But still getting the same error code (-2). On board is the GD25Q127C from Gigadevice.
The device ID for the operation code 0x9F according to the datasheet should be 0xC84018. I also found this device ID in the SPI-NOR IDS file.
I finally resolved the issue:
=> sf probe
SF: Detected gd25q128 with page size 256 Bytes, erase size 4 KiB, total 16 MiB
=>
The flash device will be correctly detected.
The problem was missing support in the clock driver of the SoC.
Should I release a patch for it?
Quoted 19 lines · Johannes Krottmayer
Sorry for my late response.
Thanks for the suggestions.
Quoted 6 lines · Peter Robinson
Make sure you enable the driver for the actual flash chip too, some of the popular ones are:
CONFIG_SPI_FLASH_WINBOND=yCONFIG_SPI_FLASH_MACRONIX=yCONFIG_SPI_FLASH_SPANSION=yCONFIG_SPI_FLASH_GIGADEVICE=yI have enabled '
CONFIG_SPI_FLASH_GIGADEVICE'. But still getting the same error code (-2). On board is the GD25Q127C from Gigadevice.The device ID for the operation code
0x9Faccording to the datasheet should be0xC84018. I also found this device ID in the SPI-NOR IDS file.
PATCH 1/1 rockchip: rk3328: Add SPI support
Add U-Boot SPI support for the RK3328
---
It's a initial SPI support. Not sure if "rk3399_spi_params" is also needed. Probing of the SPI flash devices works. Tested with the PINE64 Rock64 board.
Okay?
arch/arm/dts/rk3328-u-boot.dtsi | 5 +++++ drivers/clk/rockchip/clk_rk3328.c | 31 +++++++++++++++++++++++++++++++ drivers/spi/rk_spi.c | 2 ++ 3 files changed, 38 insertions(+)
arch/arm/dts/rk3328-u-boot.dtsi +5 -0
@@ -7,6 +7,7 @@ aliases { mmc0 = &emmc; mmc1 = &sdmmc; + spi0 = &spi0; }; chosen {
@@ -66,3 +67,7 @@ &usb20_otg { hnp-srp-disable; }; + +&spi0 { + u-boot,dm-pre-reloc; +};
drivers/clk/rockchip/clk_rk3328.c +31 -0
@@ -555,6 +555,31 @@ static ulong rk3328_saradc_set_clk(struct rk3328_cru *cru, uint hz)return rk3328_saradc_get_clk (cru); } +static ulong rk3328_spi_get_clk (struct rk3328_cru *cru) +{ +u32 div, val; + + val =readl (&cru->clksel_con[24 ]); + div = (val &CLK_SPI_DIV_CON_MASK ) >>CLK_SPI_DIV_CON_SHIFT ; + +return DIV_TO_RATE (OSC_HZ , div); +} + +static ulong rk3328_spi_set_clk (struct rk3328_cru *cru,uint hz) +{ +u32 src_clk_div; + + src_clk_div =GPLL_HZ / hz; +assert (src_clk_div <128 ); + +rk_clrsetreg (&cru->clksel_con[24 ], +CLK_PWM_PLL_SEL_MASK |CLK_PWM_DIV_CON_MASK , +CLK_PWM_PLL_SEL_GPLL <<CLK_PWM_PLL_SEL_SHIFT | + (src_clk_div -1 ) <<CLK_PWM_DIV_CON_SHIFT ); + +return rk3328_spi_get_clk (cru); +} +static ulong rk3328_clk_get_rate (struct clk *clk) {struct rk3328_clk_priv *priv =dev_get_priv (clk->dev);
@@ -581,6 +606,9 @@ static ulong rk3328_clk_get_rate(struct clk *clk)case SCLK_SARADC : rate =rk3328_saradc_get_clk (priv->cru);break ; +case SCLK_SPI : + rate =rk3328_spi_get_clk (priv->cru); +break ;default :return -ENOENT ; }
@@ -617,6 +645,9 @@ static ulong rk3328_clk_set_rate(struct clk *clk, ulong rate)case SCLK_SARADC : ret =rk3328_saradc_set_clk (priv->cru, rate);break ; +case SCLK_SPI : + ret =rk3328_spi_set_clk (priv->cru, rate); +break ;case DCLK_LCDC :case SCLK_PDM :case SCLK_RTC32K :
drivers/spi/rk_spi.c +2 -0
@@ -545,7 +545,9 @@ const struct rockchip_spi_params rk3399_spi_params = { };static const struct udevice_id rockchip_spi_ids[] = { + { .compatible ="rockchip,rk3066-spi" }, { .compatible ="rockchip,rk3288-spi" }, + { .compatible ="rockchip,rk3328-spi" }, { .compatible ="rockchip,rk3368-spi" , .data = (ulong)&rk3399_spi_params }, { .compatible ="rockchip,rk3399-spi" ,
Signature · 1 line
2.26.2
PATCH 1/1 rockchip: rock64-rk3328: Add SPI Flash support
Add SPI Flash support for the PINE64 Rock64 board
---
Initial SPI Flash support.
Okay?
arch/arm/dts/rk3328-rock64-u-boot.dtsi | 6 ++++++ configs/rock64-rk3328_defconfig | 2 ++ 2 files changed, 8 insertions(+)
arch/arm/dts/rk3328-rock64-u-boot.dtsi +6 -0
@@ -46,3 +46,9 @@ &vcc_sd { u-boot,dm-spl; }; + +&spi0 { + spi_flash: spiflash at 0 { + u-boot,dm-pre-reloc; + }; +};
configs/rock64-rk3328_defconfig +2 -0
@@ -97,3 +97,5 @@ CONFIG_SPL_TINY_MEMSET=y CONFIG_TPL_TINY_MEMSET=y CONFIG_ERRNO_STR=y CONFIG_SMBIOS_MANUFACTURER="pine64" +CONFIG_ROCKCHIP_SPI=y +CONFIG_SPI_FLASH_GIGADEVICE=y
Signature · 1 line
2.26.2
PATCH 1/1 rockchip: rk3328: Add SPI support
In reply to Johannes KrottmayerHi Johannes,
The changes look good to me, but you need to split the patch into 3 patches:
- rk3328 clock driver;
- rkspi driver;
- rk3328-u-boot.dtsi
BTW: the patch no need reply-to previous mail, you can make a new thread.
Thanks,
- Kever
Quoted 108 lines · Johannes Krottmayer
Add U-Boot SPI support for the RK3328
Signed-off-by Johannes Krottmayer <[email protected]>Cc Kever Yang <[email protected]>Cc Jagan Teki <[email protected]>---
It's a initial SPI support. Not sure if "
rk3399_spi_params" is also needed. Probing of the SPI flash devices works. Tested with the PINE64 Rock64 board.Okay?
arch/arm/dts/rk3328-u-boot.dtsi | 5 +++++ drivers/clk/rockchip/clk_rk3328.c | 31 +++++++++++++++++++++++++++++++ drivers/spi/rk_spi.c | 2 ++ 3 files changed, 38 insertions(+)arch/arm/dts/rk3328-u-boot.dtsi +5
-0@@ -7,6 +7,7 @@ aliases { mmc0 = &emmc; mmc1 = &sdmmc; + spi0 = &spi0; }; chosen {@@ -66,3 +67,7 @@ &usb20_otg { hnp-srp-disable; }; + +&spi0 { + u-boot,dm-pre-reloc; +};drivers/clk/rockchip/clk_rk3328.c +31
-0@@ -555,6 +555,31 @@ static ulong rk3328_saradc_set_clk(struct rk3328_cru *cru, uint hz)return rk3328_saradc_get_clk (cru); } +static ulong rk3328_spi_get_clk (struct rk3328_cru *cru) +{ +u32 div, val; + + val =readl (&cru->clksel_con[24 ]); + div = (val &CLK_SPI_DIV_CON_MASK ) >>CLK_SPI_DIV_CON_SHIFT ; + +return DIV_TO_RATE (OSC_HZ , div); +} + +static ulong rk3328_spi_set_clk (struct rk3328_cru *cru,uint hz) +{ +u32 src_clk_div; + + src_clk_div =GPLL_HZ / hz; +assert (src_clk_div <128 ); + +rk_clrsetreg (&cru->clksel_con[24 ], +CLK_PWM_PLL_SEL_MASK |CLK_PWM_DIV_CON_MASK , +CLK_PWM_PLL_SEL_GPLL <<CLK_PWM_PLL_SEL_SHIFT | + (src_clk_div -1 ) <<CLK_PWM_DIV_CON_SHIFT ); + +return rk3328_spi_get_clk (cru); +} +static ulong rk3328_clk_get_rate (struct clk *clk) {struct rk3328_clk_priv *priv =dev_get_priv (clk->dev);@@ -581,6 +606,9 @@ static ulong rk3328_clk_get_rate(struct clk *clk)case SCLK_SARADC : rate =rk3328_saradc_get_clk (priv->cru);break ; +case SCLK_SPI : + rate =rk3328_spi_get_clk (priv->cru); +break ;default :return -ENOENT ; }@@ -617,6 +645,9 @@ static ulong rk3328_clk_set_rate(struct clk *clk, ulong rate)case SCLK_SARADC : ret =rk3328_saradc_set_clk (priv->cru, rate);break ; +case SCLK_SPI : + ret =rk3328_spi_set_clk (priv->cru, rate); +break ;case DCLK_LCDC :case SCLK_PDM :case SCLK_RTC32K :drivers/spi/rk_spi.c +2
-0@@ -545,7 +545,9 @@ const struct rockchip_spi_params rk3399_spi_params = { };static const struct udevice_id rockchip_spi_ids[] = { + { .compatible ="rockchip,rk3066-spi" }, { .compatible ="rockchip,rk3288-spi" }, + { .compatible ="rockchip,rk3328-spi" }, { .compatible ="rockchip,rk3368-spi" , .data = (ulong)&rk3399_spi_params }, { .compatible ="rockchip,rk3399-spi" ,
PATCH 1/1 rockchip: rk3328: Add SPI support
Hi Johannes,
??? Do you have plan to update for this patch?
Thanks,
- Kever
Quoted 130 lines · Kever Yang
Hi Johannes,
The changes look good to me, but you need to split the patch into 3 patches:
- rk3328 clock driver;
- rkspi driver;
-
rk3328-u-boot.dtsiBTW: the patch no need reply-to previous mail, you can make a new thread.
Thanks,
- Kever
Quoted 110 lines · Johannes Krottmayer
Add U-Boot SPI support for the RK3328
Signed-off-by Johannes Krottmayer <[email protected]>Cc Kever Yang <[email protected]>Cc Jagan Teki <[email protected]>---
It's a initial SPI support. Not sure if "
rk3399_spi_params" is also needed. Probing of the SPI flash devices works. Tested with the PINE64 Rock64 board.Okay?
? arch/arm/dts/rk3328-u-boot.dtsi?? |? 5 +++++ ? drivers/clk/rockchip/clk_rk3328.c | 31 +++++++++++++++++++++++++++++++ ? drivers/spi/rk_spi.c????????????? |? 2 ++? 3 files changed, 38 insertions(+)
arch/arm/dts/rk3328-u-boot.dtsi +5
-0@@ -7,6 +7,7 @@ ????? aliases { ????????? mmc0 = &emmc; ????????? mmc1 = &sdmmc; +???????? spi0 = &spi0; ????? }; ? ????? chosen {@@ -66,3 +67,7 @@ ? &usb20_otg { ????? hnp-srp-disable; ? }; + +&spi0 { +??? u-boot,dm-pre-reloc; +};drivers/clk/rockchip/clk_rk3328.c +24
-0@@ -555,6 +555,31 @@ static ulong rk3328_saradc_set_clk(struct rk3328_cru *cru, uint hz) ????? return rk3328_saradc_get_clk(cru); ? } ? +static ulong rk3328_spi_get_clk(struct rk3328_cru *cru) +{ +??? u32 div, val; + +??? val = readl(&cru->clksel_con[24]); +??? div = (val & CLK_SPI_DIV_CON_MASK) >> CLK_SPI_DIV_CON_SHIFT; + +??? return DIV_TO_RATE(OSC_HZ, div); +} + +static ulong rk3328_spi_set_clk (struct rk3328_cru *cru,uint hz) +{ +??? u32 src_clk_div; + +??? src_clk_div = GPLL_HZ / hz; +??? assert(src_clk_div < 128); + +??? rk_clrsetreg(&cru->clksel_con[24], +???????????? CLK_PWM_PLL_SEL_MASK | CLK_PWM_DIV_CON_MASK, +???????????? CLK_PWM_PLL_SEL_GPLL << CLK_PWM_PLL_SEL_SHIFT | +???????????? (src_clk_div - 1) << CLK_PWM_DIV_CON_SHIFT); + +??? return rk3328_spi_get_clk(cru); +} + ? static ulong rk3328_clk_get_rate(struct clk *clk) ? {????? struct
rk3328_clk_priv*priv =dev_get_priv(clk->dev);drivers/clk/rockchip/clk_rk3328.c +0
-0@@ -581,6 +606,9 @@ static ulong rk3328_clk_get_rate(struct clk *clk)????? case
SCLK_SARADC:
????????? rate =rk3328_saradc_get_clk(priv->cru); ????????? break;
+??? caseSCLK_SPI:
+??????? rate =rk3328_spi_get_clk(priv->cru); +??????? break;
????? default:
????????? return-ENOENT;
????? }drivers/clk/rockchip/clk_rk3328.c +0
-0@@ -617,6 +645,9 @@ static ulong rk3328_clk_set_rate(struct clk *clk, ulong rate)????? case
SCLK_SARADC:
????????? ret =rk3328_saradc_set_clk(priv->cru, rate); ????????? break;
+??? caseSCLK_SPI:
+??????? ret =rk3328_spi_set_clk(priv->cru, rate); +??????? break;
????? caseDCLK_LCDC:
????? caseSCLK_PDM:
????? caseSCLK_RTC32K:drivers/spi/rk_spi.c +2
-0@@ -545,7 +545,9 @@ const? struct rockchip_spi_params rk3399_spi_params = { ? }; ? ? static const struct udevice_id rockchip_spi_ids[] = { +??? { .compatible = "rockchip,rk3066-spi" }, ????? { .compatible = "rockchip,rk3288-spi" }, +??? { .compatible = "rockchip,rk3328-spi" }, ????? { .compatible = "rockchip,rk3368-spi", ??????? .data = (ulong)&rk3399_spi_params }, ????? { .compatible = "rockchip,rk3399-spi",
PATCH 1/1 rockchip: rk3328: Add SPI support
Hi Kever,
Quoted 3 lines · Kever Yang
Hi Johannes,
??? Do you have plan to update for this patch?
I think this thread is obsolete. You have already applied the improved two patch (RK3328, PINE64 Rock64) series later in a new thread.
Many thanks for the apply.
Kind regards,
Johannes K.
Quoted 138 lines
Thanks,
- Kever
Quoted 130 lines · Kever Yang
Hi Johannes,
The changes look good to me, but you need to split the patch into 3 patches:
- rk3328 clock driver;
- rkspi driver;
-
rk3328-u-boot.dtsiBTW: the patch no need reply-to previous mail, you can make a new thread.
Thanks,
- Kever
Quoted 110 lines · Johannes Krottmayer
Add U-Boot SPI support for the RK3328
Signed-off-by Johannes Krottmayer <[email protected]>Cc Kever Yang <[email protected]>Cc Jagan Teki <[email protected]>---
It's a initial SPI support. Not sure if "
rk3399_spi_params" is also needed. Probing of the SPI flash devices works. Tested with the PINE64 Rock64 board.Okay?
? arch/arm/dts/rk3328-u-boot.dtsi?? |? 5 +++++ ? drivers/clk/rockchip/clk_rk3328.c | 31 +++++++++++++++++++++++++++++++ ? drivers/spi/rk_spi.c????????????? |? 2 ++? 3 files changed, 38 insertions(+)
arch/arm/dts/rk3328-u-boot.dtsi +5
-0@@ -7,6 +7,7 @@ ????? aliases { ????????? mmc0 = &emmc; ????????? mmc1 = &sdmmc; +???????? spi0 = &spi0; ????? }; ? ????? chosen {@@ -66,3 +67,7 @@ ? &usb20_otg { ????? hnp-srp-disable; ? }; + +&spi0 { +??? u-boot,dm-pre-reloc; +};drivers/clk/rockchip/clk_rk3328.c +24
-0@@ -555,6 +555,31 @@ static ulong rk3328_saradc_set_clk(struct rk3328_cru *cru, uint hz) ????? return rk3328_saradc_get_clk(cru); ? } ? +static ulong rk3328_spi_get_clk(struct rk3328_cru *cru) +{ +??? u32 div, val; + +??? val = readl(&cru->clksel_con[24]); +??? div = (val & CLK_SPI_DIV_CON_MASK) >> CLK_SPI_DIV_CON_SHIFT; + +??? return DIV_TO_RATE(OSC_HZ, div); +} + +static ulong rk3328_spi_set_clk (struct rk3328_cru *cru,uint hz) +{ +??? u32 src_clk_div; + +??? src_clk_div = GPLL_HZ / hz; +??? assert(src_clk_div < 128); + +??? rk_clrsetreg(&cru->clksel_con[24], +???????????? CLK_PWM_PLL_SEL_MASK | CLK_PWM_DIV_CON_MASK, +???????????? CLK_PWM_PLL_SEL_GPLL << CLK_PWM_PLL_SEL_SHIFT | +???????????? (src_clk_div - 1) << CLK_PWM_DIV_CON_SHIFT); + +??? return rk3328_spi_get_clk(cru); +} + ? static ulong rk3328_clk_get_rate(struct clk *clk) ? {????? struct
rk3328_clk_priv*priv =dev_get_priv(clk->dev);drivers/clk/rockchip/clk_rk3328.c +0
-0@@ -581,6 +606,9 @@ static ulong rk3328_clk_get_rate(struct clk *clk)????? case
SCLK_SARADC:
????????? rate =rk3328_saradc_get_clk(priv->cru); ????????? break;
+??? caseSCLK_SPI:
+??????? rate =rk3328_spi_get_clk(priv->cru); +??????? break;
????? default:
????????? return-ENOENT;
????? }drivers/clk/rockchip/clk_rk3328.c +0
-0@@ -617,6 +645,9 @@ static ulong rk3328_clk_set_rate(struct clk *clk, ulong rate)????? case
SCLK_SARADC:
????????? ret =rk3328_saradc_set_clk(priv->cru, rate); ????????? break;
+??? caseSCLK_SPI:
+??????? ret =rk3328_spi_set_clk(priv->cru, rate); +??????? break;
????? caseDCLK_LCDC:
????? caseSCLK_PDM:
????? caseSCLK_RTC32K:drivers/spi/rk_spi.c +2
-0@@ -545,7 +545,9 @@ const? struct rockchip_spi_params rk3399_spi_params = { ? }; ? ? static const struct udevice_id rockchip_spi_ids[] = { +??? { .compatible = "rockchip,rk3066-spi" }, ????? { .compatible = "rockchip,rk3288-spi" }, +??? { .compatible = "rockchip,rk3328-spi" }, ????? { .compatible = "rockchip,rk3368-spi", ??????? .data = (ulong)&rk3399_spi_params }, ????? { .compatible = "rockchip,rk3399-spi",