Skip to contentSkip to conversation

mmc: omap_hsmmc: Set 3.3V for IO voltage on all places

PATCH New Pali Rohár 3 participants 3 messages Jul 3, 2020 – Jul 5, 2020 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: omap_hsmmc: Set 3.3V for IO voltage on all places

In commit commit d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage") was changed 3.0V IO voltage to 3.3V but it was not done on all places in omap_hsmmc driver. That commit broke eMMC support on Nokia N900.

This patch fixes that problematic commit and changes 3.0V to 3.3V on all remaining places in omap_hsmmc driver.

Fixes d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage")
---
 drivers/mmc/omap_hsmmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/omap_hsmmc.c +1 -1
index 8636cd713a..dc26e54795 100644
@@ -840,7 +840,7 @@ static int omap_hsmmc_init_setup(struct mmc *mmc)
 	omap_hsmmc_conf_bus_power(mmc, (reg_val & VS33_3V3SUP) ?
 			  MMC_SIGNAL_VOLTAGE_330 : MMC_SIGNAL_VOLTAGE_180);
 #else
-	writel(DTW_1_BITMODE | SDBP_PWROFF | SDVS_3V0, &mmc_base->hctl);
+	writel(DTW_1_BITMODE | SDBP_PWROFF | SDVS_3V3, &mmc_base->hctl);
 	writel(readl(&mmc_base->capa) | VS33_3V3SUP | VS18_1V8SUP,
 		&mmc_base->capa);
 #endif
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 mmc: omap_hsmmc: Set 3.3V for IO voltage on all places

Quoted 9 lines · Pali Roh?r

In commit commit d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage") was changed 3.0V IO voltage to 3.3V but it was not done on all places in omap_hsmmc driver. That commit broke eMMC support on Nokia N900.

This patch fixes that problematic commit and changes 3.0V to 3.3V on all remaining places in omap_hsmmc driver.

Fixes d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage")
Signature · 9 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200704/2d9d7006/attachment.sig>
#2 lore raw

PATCH 1/1 mmc: omap_hsmmc: Set 3.3V for IO voltage on all places

In reply to Pali Rohár

Hi,

Quoted 10 lines · Pali Roh?r

In commit commit d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage") was changed 3.0V IO voltage to 3.3V but it was not done on all places in omap_hsmmc driver. That commit broke eMMC support on Nokia N900.

This patch fixes that problematic commit and changes 3.0V to 3.3V on all remaining places in omap_hsmmc driver.

Fixes d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage")

---

Thanks,
Faiz