drm/sun4i: lvds: Invert the LVDS polarity
PATCH 1/1 drm/sun4i: lvds: Invert the LVDS polarity
The LVDS controller can invert the polarity / lanes of the LVDS output. The default polarity causes some issues on some panels.
However, U-Boot has always used the opposite polarity without any reported issue, and the only currently supported LVDS panel in-tree (the TBS A711) seems to be able to work with both settings.
Let's just use the same polarity than U-Boot to be more consistent and hopefully support all the panels.
--- drivers/gpu/drm/sun4i/sun4i_tcon.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/sun4i/sun4i_tcon.c +1 -3
@@ -474,9 +474,7 @@ static void sun4i_tcon0_mode_set_lvds(struct sun4i_tcon *tcon,SUN4I_TCON0_BASIC2_V_TOTAL (mode->crtc_vtotal *2 ) | SUN4I_TCON0_BASIC2_V_BACKPORCH(bp)); - reg =SUN4I_TCON0_LVDS_IF_CLK_SEL_TCON0 | -SUN4I_TCON0_LVDS_IF_DATA_POL_NORMAL | -SUN4I_TCON0_LVDS_IF_CLK_POL_NORMAL ; + reg =SUN4I_TCON0_LVDS_IF_CLK_SEL_TCON0 ;if (sun4i_tcon_get_pixel_depth (encoder) ==24 ) reg |=SUN4I_TCON0_LVDS_IF_BITWIDTH_24BITS ;else
Signature · 7 lines
2.26.2 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 8 lines · Maxime Ripard
The LVDS controller can invert the polarity / lanes of the LVDS output. The default polarity causes some issues on some panels.
However, U-Boot has always used the opposite polarity without any reported issue, and the only currently supported LVDS panel in-tree (the TBS A711) seems to be able to work with both settings.
Quoted 5 lines
Let's just use the same polarity than U-Boot to be more consistent and hopefully support all the panels.
Cc Ondrej Jirman <[email protected]>Signed-off-by Maxime Ripard <[email protected]>
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Maxime Ripard
AppliedQuoted 9 lines · Chen-Yu Tsai
Quoted 8 lines · Maxime Ripard
The LVDS controller can invert the polarity / lanes of the LVDS output. The default polarity causes some issues on some panels.
However, U-Boot has always used the opposite polarity without any reported issue, and the only currently supported LVDS panel in-tree (the TBS A711) seems to be able to work with both settings.
Quoted 7 lines
Quoted 5 lines
Let's just use the same polarity than U-Boot to be more consistent and hopefully support all the panels.
Cc Ondrej Jirman <[email protected]>Signed-off-by Maxime Ripard <[email protected]>Reviewed-by Chen-Yu Tsai <[email protected]>
Applied, thanks!
Maxime
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel