dt-bindings: fix simple-framebuffer warning
Subsystems (5)
cover dt-bindings: fix simple-framebuffer warning
Trivial fix for a long standing warning.
At least not fixed in drm-msc-next for now.
Just in case it was not fixed by someone else (Rob?) already.
Sam
Sam Ravnborg (1):
dt-bindings: fix simple-framebuffer example
.../bindings/display/simple-framebuffer.yaml | 45 +++++++++++----------- 1 file changed, 23 insertions(+), 22 deletions(-)
PATCH 1/1 dt-bindings: fix simple-framebuffer example
Now that dt-extract-example gained support for using root nodes in examples, update the example for the simple-frambuffer binding to use it.
This gives us a better example and kill a long standing warning:
simple-framebuffer.example.dts:23.16-39.11:
Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
Note: To get the update dt-extract-example execute:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
--- .../bindings/display/simple-framebuffer.yaml | 45 ++++++++++--------- 1 file changed, 23 insertions(+), 22 deletions(-)
Documentation/devicetree/bindings/display/simple-framebuffer.yaml +23 -22
@@ -152,28 +152,29 @@ additionalProperties: false examples: - | - aliases { - display0 = &lcdc0; + / { + compatible = "foo"; + model = "foo"; + #address-cells = <1>; + #size-cells = <1>; + + chosen { + #address-cells = <1>; + #size-cells = <1>; + stdout-path = "display0"; + framebuffer0: framebuffer@1d385000 { + compatible = "allwinner,simple-framebuffer", "simple-framebuffer"; + allwinner,pipeline = "de_be0-lcd0"; + reg = <0x1d385000 3840000>; + width = <1600>; + height = <1200>; + stride = <3200>; + format = "r5g6b5"; + clocks = <&ahb_gates 36>, <&ahb_gates 43>, <&ahb_gates 44>; + lcd-supply = <®_dc1sw>; + display = <&lcdc0>; + }; + }; }; - chosen { - #address-cells = <1>; - #size-cells = <1>; - stdout-path = "display0"; - framebuffer0: framebuffer@1d385000 { - compatible = "allwinner,simple-framebuffer", "simple-framebuffer"; - allwinner,pipeline = "de_be0-lcd0"; - reg = <0x1d385000 3840000>; - width = <1600>; - height = <1200>; - stride = <3200>; - format = "r5g6b5"; - clocks = <&ahb_gates 36>, <&ahb_gates 43>, <&ahb_gates 44>; - lcd-supply = <®_dc1sw>; - display = <&lcdc0>; - }; - }; - - lcdc0: lcdc { }; - ...
Signature · 1 line
2.25.1
Re: [PATCH v1 1/1] dt-bindings: fix simple-framebuffer example
Hi Sam,
Thanks for your patch!
Quoted 2 lines · Sam Ravnborg
Now that dt-extract-example gained support for using root nodes in examples, update the example for the simple-frambuffer binding to use it.
simple-framebuffer
Quoted 13 lines
This gives us a better example and kill a long standing warning:
simple-framebuffer.example.dts:23.16-39.11:
Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root nodeNote: To get the update dt-extract-example execute:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgradeSigned-off-by Sam Ravnborg <[email protected]>
Documentation/devicetree/bindings/display/simple-framebuffer.yaml additionalProperties: false · line 156
Quoted 5 lines
Documentation/devicetree/bindings/display/simple-framebuffer.yaml +0
-2@@ -152,28 +152,29 @@ additionalProperties: false examples: - | - aliases { - display0 = &lcdc0;
Why drop the aliases example?
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH v1 1/1] dt-bindings: fix simple-framebuffer example
Quoted 9 lines · Geert Uytterhoeven
Hi Sam,
Thanks for your patch!
Quoted 2 lines · Sam Ravnborg
Now that dt-extract-example gained support for using root nodes in examples, update the example for the simple-frambuffer binding to use it.
simple-framebuffer
Thanks, will fix.
Quoted 15 lines
Quoted 15 lines
This gives us a better example and kill a long standing warning:
simple-framebuffer.example.dts:23.16-39.11:
Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root nodeNote: To get the update dt-extract-example execute:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgradeSigned-off-by Sam Ravnborg <[email protected]>Documentation/devicetree/bindings/display/simple-framebuffer.yaml +0
-0@@ -152,28 +152,29 @@ additionalProperties: false
Quoted 6 lines
Documentation/devicetree/bindings/display/simple-framebuffer.yaml additionalProperties: false · line 156
Quoted 4 lines
Documentation/devicetree/bindings/display/simple-framebuffer.yaml +0
-2examples: - | - aliases { - display0 = &lcdc0;Why drop the aliases example?
I did not see it had any value for the binding that the example shall demonstrate. But it was not somthing I have given much thought of.
Sam
Quoted 11 lines
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Rob Herring
maintainerRe: [PATCH v1 1/1] dt-bindings: fix simple-framebuffer example
Quoted 28 lines · Sam Ravnborg
Quoted 9 lines · Geert Uytterhoeven
Hi Sam,
Thanks for your patch!
Quoted 2 lines · Sam Ravnborg
Now that dt-extract-example gained support for using root nodes in examples, update the example for the simple-frambuffer binding to use it.
simple-framebuffer
Thanks, will fix.
Quoted 15 lines
Quoted 15 lines
This gives us a better example and kill a long standing warning:
simple-framebuffer.example.dts:23.16-39.11:
Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root nodeNote: To get the update dt-extract-example execute:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgradeSigned-off-by Sam Ravnborg <[email protected]>Documentation/devicetree/bindings/display/simple-framebuffer.yaml +0
-0@@ -152,28 +152,29 @@ additionalProperties: false
Quoted 8 lines
Quoted 6 lines
Documentation/devicetree/bindings/display/simple-framebuffer.yaml additionalProperties: false · line 156
Quoted 4 lines
Documentation/devicetree/bindings/display/simple-framebuffer.yaml +0
-2examples: - | - aliases { - display0 = &lcdc0;Why drop the aliases example?
I did not see it had any value for the binding that the example shall demonstrate. But it was not somthing I have given much thought of.
I don't think anything actually supports 'display' aliases and it is beyond the scope of this binding, so I'd drop.
stdout-path should be dropped too as it points to this.
Rob
Sam Ravnborg
AppliedQuoted 8 lines · Sam Ravnborg
Trivial fix for a long standing warning.
At least not fixed in drm-msc-next for now.
Just in case it was not fixed by someone else (Rob?) already.Sam
Sam Ravnborg (1):
dt-bindings: fix simple-framebuffer example
Applied to drm-misc-next.
Sam
Quoted 9 lines
.../bindings/display/simple-framebuffer.yaml | 45 +++++++++++----------- 1 file changed, 23 insertions(+), 22 deletions(-)_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel