Skip to contentSkip to conversation

soc: qcom-geni-se: fix configury of qcom-geni-se.c

PATCH New [email protected] 1 participant 1 message Jul 5, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: qcom-geni-se: fix configury of qcom-geni-se.c

From: Tom Rix <[email protected]>

In a randconfig, qcom-geni-se.c breaks with

drivers/soc/qcom/qcom-geni-se.c: In function ‘geni_remove_earlycon_icc_vote’:
drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of function ‘of_get_next_parent’; did you mean ‘of_get_parent’? [-Werror=implicit-function-declaration]

  parent = of_get_next_parent(wrapper->dev->of_node);
           ^~~~~~~~~~~~~~~~~~
           of_get_parent

qcom-geni-sec.c correctly includes the linux/of.h header. But the header depends on CONFIG_OF being set.

So add depends to QCOM_GENI_SE

---
 drivers/soc/qcom/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/soc/qcom/Kconfig +1 -0
index 899f8c066797..f699cfa33d7d 100644
@@ -29,6 +29,7 @@ config QCOM_COMMAND_DB
 config QCOM_GENI_SE
 	tristate "QCOM GENI Serial Engine Driver"
 	depends on ARCH_QCOM || COMPILE_TEST
+	depends on OF
 	help
 	  This driver is used to manage Generic Interface (GENI) firmware based
 	  Qualcomm Technologies, Inc. Universal Peripheral (QUP) Wrapper. This
Signature · 1 line
2.18.1