Skip to contentSkip to conversation

package/lshw: bump version to 02.19.2

PATCH New Sergio Prado 2 participants 2 messages Jul 4, 2020 – Jul 5, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/lshw: bump version to 02.19.2

Remove patch 0001 (changes already upstream) and rework patches 0002 and 0003 (merge request sent upstream [1])

[1] https://github.com/lyonel/lshw/pull/56

---
 ...x-musl-build-basename-is-in-libgen.h.patch | 101 ++++++++++++++++++
 ...kefile-allow-to-pass-additional-LIBS.patch |  44 --------
 ...x-musl-build-basename-is-in-libgen.h.patch |  78 --------------
 ...-musl-build-wrong-usage-of-LONG_BIT.patch} |  26 ++---
 package/lshw/lshw.hash                        |   2 +-
 package/lshw/lshw.mk                          |   2 +-
 6 files changed, 117 insertions(+), 136 deletions(-)
 create mode 100644 package/lshw/0001-Fix-musl-build-basename-is-in-libgen.h.patch
 delete mode 100644 package/lshw/0001-Makefile-allow-to-pass-additional-LIBS.patch
 delete mode 100644 package/lshw/0002-Fix-musl-build-basename-is-in-libgen.h.patch
 rename package/lshw/{0003-Fix-use-of-LONG_BIT.patch => 0002-Fix-musl-build-wrong-usage-of-LONG_BIT.patch} (53%)
package/lshw/0001-Fix-musl-build-basename-is-in-libgen.h.patch new file +101 -0
new file mode 100644
index 000000000000..0917260d4c9b
@@ -0,0 +1,101 @@
+From 6bc5abf99ef01e5aeea4f5bce5f5bff7f1b8ddd9 Mon Sep 17 00:00:00 2001
+From: Sergio Prado <[email protected]>
+Date: Sat, 4 Jul 2020 20:02:53 -0300
+Subject: [PATCH] Fix musl build: basename() is in libgen.h.
+
+Also, its argument is not const, so add const_cast.
+
+Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]>
+Signed-off-by: Sergio Prado <[email protected]>
+---
+ src/core/sysfs.cc | 19 ++++++++++---------
+ 1 file changed, 10 insertions(+), 9 deletions(-)
+
+diff --git a/src/core/sysfs.cc b/src/core/sysfs.cc
+index 32d65642f157..c2fa84fe8d0f 100644
+--- a/src/core/sysfs.cc
++++ b/src/core/sysfs.cc
+@@ -16,6 +16,7 @@
+ #include <sys/stat.h>
+ #include <sys/types.h>
+ #include <sys/mount.h>
++#include <libgen.h>
+ 
+ 
+ __ID("@(#) $Id$");
+@@ -100,7 +101,7 @@ static string sysfs_getbustype(const string & path)
+   {
+     devname =
+       string(fs.path + "/bus/") + string(namelist[i]->d_name) +
+-      "/devices/" + basename(path.c_str());
++      "/devices/" + basename(const_cast<char*>(path.c_str()));
+ 
+     if (samefile(devname, path))
+       return string(namelist[i]->d_name);
+@@ -140,7 +141,7 @@ static string sysfstobusinfo(const string & path)
+ 
+   if (bustype == "usb")
+   {
+-    string name = basename(path.c_str());
++    string name = basename(const_cast<char*>(path.c_str()));
+     if (matches(name, "^[0-9]+-[0-9]+(\\.[0-9]+)*:[0-9]+\\.[0-9]+$"))
+     {
+       size_t colon = name.rfind(":");
+@@ -151,7 +152,7 @@ static string sysfstobusinfo(const string & path)
+ 
+   if (bustype == "virtio")
+   {
+-    string name = basename(path.c_str());
++    string name = basename(const_cast<char*>(path.c_str()));
+     if (name.compare(0, 6, "virtio") == 0)
+       return "virtio@" + name.substr(6);
+     else
+@@ -159,10 +160,10 @@ static string sysfstobusinfo(const string & path)
+   }
+ 
+   if (bustype == "vio")
+-    return string("vio@") + basename(path.c_str());
++    return string("vio@") + basename(const_cast<char*>(path.c_str()));
+ 
+   if (bustype == "ccw")
+-    return string("ccw@") + basename(path.c_str());
++    return string("ccw@") + basename(const_cast<char*>(path.c_str()));
+ 
+   if (bustype == "ccwgroup")
+   {
+@@ -240,7 +241,7 @@ string entry::driver() const
+   string driverlink = This->devpath + "/driver";
+   if (!exists(driverlink))
+     return "";
+-  return basename(readlink(driverlink).c_str());
++  return basename(const_cast<char*>(readlink(driverlink).c_str()));
+ }
+ 
+ 
+@@ -328,7 +329,7 @@ string entry::name_in_class(const string & classname) const
+ 
+ string entry::name() const
+ {
+-  return basename(This->devpath.c_str());
++  return basename(const_cast<char*>(This->devpath.c_str()));
+ }
+ 
+ 
+@@ -340,12 +341,12 @@ entry entry::parent() const
+ 
+ string entry::classname() const
+ {
+-  return basename(dirname(This->devpath).c_str());
++  return basename(const_cast<char*>(dirname(This->devpath).c_str()));
+ }
+ 
+ bool entry::isvirtual() const
+ {
+-  return string(basename(dirname(dirname(This->devpath)).c_str())) == "virtual";
++  return string(basename(const_cast<char*>(dirname(dirname(This->devpath)).c_str()))) == "virtual";
+ }
+ 
+ string entry::string_attr(const string & name, const string & def) const
+-- 
+2.17.1
+
package/lshw/0001-Makefile-allow-to-pass-additional-LIBS.patch deleted +0 -44

44 lines not on this page · raw message

package/lshw/0002-Fix-musl-build-basename-is-in-libgen.h.patch deleted +0 -78

78 lines not on this page · raw message

package/lshw/0002-Fix-musl-build-wrong-usage-of-LONG_BIT.patch renamed from package/lshw/0003-Fix-use-of-LONG_BIT.patch +14 -12
similarity index 53%
rename from package/lshw/0003-Fix-use-of-LONG_BIT.patch
rename to package/lshw/0002-Fix-musl-build-wrong-usage-of-LONG_BIT.patch
index 7d8d73945282..dd8bdb5beb60 100644
@@ -1,7 +1,7 @@
-From 50284ac4400ac3d7562f4765726492caee8ff547 Mon Sep 17 00:00:00 2001
-From: "Arnout Vandecappelle (Essensium/Mind)" <[email protected]>
-Date: Sat, 27 Aug 2016 01:15:13 +0200
-Subject: [PATCH] Fix use of LONG_BIT
+From 246b9e07f22d551fae0718315273760c087b79ca Mon Sep 17 00:00:00 2001
+From: Sergio Prado <[email protected]>
+Date: Sat, 4 Jul 2020 20:28:26 -0300
+Subject: [PATCH] Fix musl build: wrong usage of LONG_BIT
 
 LONG_BIT is not a sysconf value, it is either 32 or 64. Using it as
 a sysconf value will give weird results.
@@ -12,25 +12,27 @@ equal to LONG_BIT: it's either compiled 32-bit or 64-bit so a runtime
 lookup doesn't make sense. For this reason, musl has removed the
 definition of _SC_LONG_BIT.
 
+Signed-off-by: Sergio Prado <[email protected]>
 Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]>
 ---
- src/core/abi.cc | 3 +--
- 1 file changed, 1 insertion(+), 2 deletions(-)
+ src/core/abi.cc | 4 +---
+ 1 file changed, 1 insertion(+), 3 deletions(-)
 
 diff --git a/src/core/abi.cc b/src/core/abi.cc
-index 76e5082..a13daaa 100644
+index adff7b55acfa..76c664c03ce7 100644
 --- a/src/core/abi.cc
 +++ b/src/core/abi.cc
-@@ -19,8 +19,7 @@ __ID("@(#) $Id: mem.cc 1352 2006-05-27 23:54:13Z ezix $");
- 
+@@ -20,9 +20,7 @@ __ID("@(#) $Id: mem.cc 1352 2006-05-27 23:54:13Z ezix $");
  bool scan_abi(hwNode & system)
  {
--  // are we compiled as 32- or 64-bit process ?
--  system.setWidth(sysconf(LONG_BIT));
+   // are we compiled as 32- or 64-bit process ?
+-  long sc = sysconf(LONG_BIT);
+-  if(sc==-1) sc = sysconf(_SC_LONG_BIT);
+-  if(sc!=-1) system.setWidth(sc);
 +  system.setWidth(LONG_BIT);
  
    pushd(PROC_SYS);
  
 -- 
-2.9.3
+2.17.1
 
package/lshw/lshw.hash +1 -1
index a8352d4283d0..0b60b3b5722e 100644
@@ -1,3 +1,3 @@
 # Locally calculated
-sha256  ae22ef11c934364be4fd2a0a1a7aadf4495a0251ec6979da280d342a89ca3c2f  lshw-B.02.18.tar.gz
+sha256  9bb347ac87142339a366a1759ac845e3dbb337ec000aa1b99b50ac6758a80f80  lshw-B.02.19.2.tar.gz
 sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
package/lshw/lshw.mk +1 -1
index 3e8cee2e2ede..9f1ff8938a7b 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LSHW_VERSION = 02.18
+LSHW_VERSION = 02.19.2
 LSHW_SITE = http://ezix.org/software/files
 LSHW_SOURCE = lshw-B.$(LSHW_VERSION).tar.gz
 LSHW_LICENSE = GPL-2.0
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 package/lshw: bump version to 02.19.2

Quoted 6 lines · On Sat, 4 Jul 2020 20:50:45 -0300 Sergio Prado <[email protected]>…

Remove patch 0001 (changes already upstream) and rework patches 0002 and 0003 (merge request sent upstream [1])

[1] https://github.com/lyonel/lshw/pull/56

Quoted 12 lines
---
 ...x-musl-build-basename-is-in-libgen.h.patch | 101 ++++++++++++++++++
 ...kefile-allow-to-pass-additional-LIBS.patch |  44 --------
 ...x-musl-build-basename-is-in-libgen.h.patch |  78 --------------
 ...-musl-build-wrong-usage-of-LONG_BIT.patch} |  26 ++---
 package/lshw/lshw.hash                        |   2 +-
 package/lshw/lshw.mk                          |   2 +-
 6 files changed, 117 insertions(+), 136 deletions(-)
 create mode 100644 package/lshw/0001-Fix-musl-build-basename-is-in-libgen.h.patch
 delete mode 100644 package/lshw/0001-Makefile-allow-to-pass-additional-LIBS.patch
 delete mode 100644 package/lshw/0002-Fix-musl-build-basename-is-in-libgen.h.patch
 rename package/lshw/{0003-Fix-use-of-LONG_BIT.patch => 0002-Fix-musl-build-wrong-usage-of-LONG_BIT.patch} (53%)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com