Skip to contentSkip to conversation

fscache: replace open-coded pr_warn_once() with actual call

PATCH In review Jason A. Donenfeld 2 participants 2 messages Jul 5, 2020 – Jul 6, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fscache: replace open-coded pr_warn_once() with actual call

There's no reason to open code this here, so instead replace it with pr_warn_once, which amounts to exactly the same thing.

---
 fs/fscache/page.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
fs/fscache/page.c +3 -8
index 26af6fdf1538..dc8dce79fa8d 100644
@@ -1173,14 +1173,9 @@ void fscache_mark_page_cached(struct fscache_retrieval *op, struct page *page)
 	trace_fscache_page(cookie, page, fscache_page_cached);
 
 	_debug("- mark %p{%lx}", page, page->index);
-	if (TestSetPageFsCache(page)) {
-		static bool once_only;
-		if (!once_only) {
-			once_only = true;
-			pr_warn("Cookie type %s marked page %lx multiple times\n",
-				cookie->def->name, page->index);
-		}
-	}
+	if (TestSetPageFsCache(page))
+		pr_warn_once("Cookie type %s marked page %lx multiple times\n",
+			     cookie->def->name, page->index);
 
 	if (cookie->def->mark_page_cached)
 		cookie->def->mark_page_cached(cookie->netfs_data,
Signature · 1 line
2.27.0