lib/igt_fb: remove extra parameters from igt_put_cairo_ctx
PATCH 1/1 lib/igt_fb: remove extra parameters from igt_put_cairo_ctx
The function igt_put_cairo_ctx currently requires three parameters, but only one of them is used in it. This patch removes the useless parameters, making the code more readable and cohesive. It also applies the change to all occurrences of the function in the code.
--- lib/igt_fb.c | 18 ++++++++---------- lib/igt_fb.h | 2 +- tests/amdgpu/amd_color.c | 4 ++-- tests/i915/i915_pm_dc.c | 2 +- tests/kms_atomic.c | 6 +++--- tests/kms_available_modes_crc.c | 4 ++-- tests/kms_ccs.c | 2 +- tests/kms_color_helper.c | 4 ++-- tests/kms_concurrent.c | 2 +- tests/kms_crtc_background_color.c | 2 +- tests/kms_cursor_crc.c | 22 ++++++++++------------ tests/kms_cursor_edge_walk.c | 2 +- tests/kms_flip.c | 2 +- tests/kms_hdr.c | 2 +- tests/kms_mmap_write_crc.c | 4 ++-- tests/kms_plane.c | 8 ++++---- tests/kms_plane_alpha_blend.c | 10 +++++----- tests/kms_plane_cursor.c | 4 ++-- tests/kms_plane_lowres.c | 2 +- tests/kms_plane_multiple.c | 2 +- tests/kms_psr.c | 2 +- tests/kms_psr2_su.c | 4 ++-- tests/kms_rotation_crc.c | 2 +- tests/kms_setmode.c | 2 +- tests/kms_vrr.c | 2 +- tests/testdisplay.c | 4 ++-- 26 files changed, 58 insertions(+), 62 deletions(-)
lib/igt_fb.c +8 -10
@@ -1697,7 +1697,7 @@ unsigned int igt_create_color_fb(int fd, int width, int height, cr =igt_get_cairo_ctx (fd, fb);igt_paint_color (cr,0 ,0 , width, height, r, g, b); -igt_put_cairo_ctx (fd, fb, cr); +igt_put_cairo_ctx (cr);return fb_id; }
@@ -1734,7 +1734,7 @@ unsigned int igt_create_pattern_fb(int fd, int width, int height, cr =igt_get_cairo_ctx (fd, fb);igt_paint_test_pattern (cr, width, height); -igt_put_cairo_ctx (fd, fb, cr); +igt_put_cairo_ctx (cr);return fb_id; }
@@ -1777,7 +1777,7 @@ unsigned int igt_create_color_pattern_fb(int fd, int width, int height, cr =igt_get_cairo_ctx (fd, fb);igt_paint_color (cr,0 ,0 , width, height, r, g, b);igt_paint_test_pattern (cr, width, height); -igt_put_cairo_ctx (fd, fb, cr); +igt_put_cairo_ctx (cr);return fb_id; }
@@ -1820,7 +1820,7 @@ unsigned int igt_create_image_fb(int fd, int width, int height, cr =igt_get_cairo_ctx (fd, fb);igt_paint_image (cr, filename,0 ,0 , width, height); -igt_put_cairo_ctx (fd, fb, cr); +igt_put_cairo_ctx (cr);return fb_id; }
@@ -1920,7 +1920,7 @@ unsigned int igt_create_stereo_fb(int drm_fd, drmModeModeInfo *mode, layout.right.x, layout.right.y, layout.right.width, layout.right.height); -igt_put_cairo_ctx (drm_fd, &fb, cr); +igt_put_cairo_ctx (cr);return fb_id; }
@@ -3578,15 +3578,13 @@ cairo_t *igt_get_cairo_ctx(int fd, struct igt_fb *fb)/** * igt_put_cairo_ctx: -* @fd: open i915 drm file descriptor -* @fb: pointer to an #igt_fb structure * @cr: the cairo context returned by igt_get_cairo_ctx. * * This releases the cairo surface @cr returned by igt_get_cairo_ctx() -* for @fb, and writes the changes out to the framebuffer if cairo doesn't +* for fb, and writes the changes out to the framebuffer if cairo doesn't * have native support for the format. */ -void igt_put_cairo_ctx (int fd,struct igt_fb *fb,cairo_t *cr) +void igt_put_cairo_ctx (cairo_t *cr) {cairo_status_t ret =cairo_status (cr);igt_assert_f (ret ==CAIRO_STATUS_SUCCESS ,"Cairo failed to draw with %s\n" ,cairo_status_to_string (ret));
@@ -3657,7 +3655,7 @@ unsigned int igt_fb_convert_with_stride(struct igt_fb *dst, struct igt_fb *src, cr =igt_get_cairo_ctx (dst->fd, dst);cairo_set_source_surface (cr, surf,0 ,0 );cairo_paint (cr); -igt_put_cairo_ctx (dst->fd, dst, cr); +igt_put_cairo_ctx (cr);cairo_surface_destroy (surf);
lib/igt_fb.h +1 -1
@@ -178,7 +178,7 @@ int igt_fb_ccs_to_main_plane(const struct igt_fb *fb, int ccs_plane);cairo_surface_t *igt_get_cairo_surface (int fd,struct igt_fb *fb);cairo_surface_t *igt_cairo_image_surface_create_from_png (const char *filename);cairo_t *igt_get_cairo_ctx (int fd,struct igt_fb *fb); -void igt_put_cairo_ctx (int fd,struct igt_fb *fb,cairo_t *cr); +void igt_put_cairo_ctx (cairo_t *cr);void igt_paint_color (cairo_t *cr,int x,int y,int w,int h,double r,double g,double b); void igt_paint_color_alpha(cairo_t *cr, int x, int y, int w, int h,
tests/amdgpu/amd_color.c +2 -2
@@ -134,7 +134,7 @@ static void draw_color(igt_fb_t *fb, double r, double g, double b)cairo_set_operator (cr,CAIRO_OPERATOR_SOURCE );igt_paint_color (cr,0 ,0 , fb->width, fb->height, r, g, b); -igt_put_cairo_ctx (fb->fd, fb, cr); +igt_put_cairo_ctx (cr); }/* Generates the gamma test pattern. */
@@ -148,7 +148,7 @@ static void draw_gamma_test(igt_fb_t *fb)igt_paint_color_gradient (cr,0 , gh *2 , fb->width, gh,0 ,1 ,0 );igt_paint_color_gradient (cr,0 , gh *3 , fb->width, gh,0 ,0 ,1 ); -igt_put_cairo_ctx (fb->fd, fb, cr); +igt_put_cairo_ctx (cr); }/* Sets the degamma LUT. */
tests/i915/i915_pm_dc.c +1 -1
@@ -131,7 +131,7 @@ static void paint_rectangles(data_t *data, colors[i -1 ].r, colors[i -1 ].g, colors[i - 1].b); -igt_put_cairo_ctx (data->drm_fd, fb, cr); +igt_put_cairo_ctx (cr); }static void setup_primary (data_t *data)
tests/kms_atomic.c +3 -3
@@ -309,7 +309,7 @@ plane_primary_overlay_mutable_zpos(igt_pipe_t *pipe, igt_output_t *output, w_overlay /2 , h_overlay /2 , 0.0, 0.0, 0.0, 0.0);cairo_set_operator (cr,CAIRO_OPERATOR_OVER ); -igt_put_cairo_ctx (pipe->display->drm_fd, &fb_overlay, cr); +igt_put_cairo_ctx (cr);igt_plane_set_fb (primary, &fb_primary);igt_plane_set_fb (overlay, &fb_overlay);
@@ -343,7 +343,7 @@ plane_primary_overlay_mutable_zpos(igt_pipe_t *pipe, igt_output_t *output, w_overlay, h_overlay, 0.0, 0.0, 0.0, 0.5);cairo_set_operator (cr,CAIRO_OPERATOR_OVER ); -igt_put_cairo_ctx (pipe->display->drm_fd, &fb_primary, cr); +igt_put_cairo_ctx (cr);igt_info ("Committing with a hole in the primary through " \"which the underlay should be seen\n" );
@@ -398,7 +398,7 @@ plane_immutable_zpos(igt_display_t *display, igt_pipe_t *pipe,igt_assert (cairo_status (cr) ==0 );igt_paint_color (cr,0 ,0 , w_lower, h_lower,0.0 ,0.0 ,1.0 );igt_paint_color (cr, w_upper /2 , h_upper /2 , w_upper, h_upper,1.0 ,1.0 ,0.0 ); -igt_put_cairo_ctx (display->drm_fd, &fb_ref, cr); +igt_put_cairo_ctx (cr);igt_plane_set_fb (primary, &fb_ref);igt_display_commit2 (display,COMMIT_ATOMIC );
tests/kms_available_modes_crc.c +2 -2
@@ -96,7 +96,7 @@ static void generate_comparison_crc_list(data_t *data, igt_output_t *output) 0.0, 0.0, 0.0);igt_paint_color (cr,0 ,0 , w, h,1.0 ,1.0 ,1.0 );igt_assert (cairo_status (cr) ==0 ); -igt_put_cairo_ctx (data->gfx_fd, &data->primary_fb, cr); +igt_put_cairo_ctx (cr); primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY );igt_plane_set_fb (primary, &data->primary_fb);
@@ -108,7 +108,7 @@ static void generate_comparison_crc_list(data_t *data, igt_output_t *output) cr =igt_get_cairo_ctx (data->gfx_fd, &data->primary_fb);igt_paint_color (cr,0 ,0 , mode->hdisplay, mode->vdisplay,1.0 ,1.0 ,1.0 ); -igt_put_cairo_ctx (data->gfx_fd, &data->primary_fb, cr); +igt_put_cairo_ctx (cr);igt_plane_set_fb (primary, &data->primary_fb);igt_display_commit2 (&data->display, data->commit);
tests/kms_ccs.c +1 -1
@@ -246,7 +246,7 @@ static void generate_fb(data_t *data, struct igt_fb *fb, cr =igt_get_cairo_ctx (data->drm_fd, fb);igt_paint_color (cr,0 ,0 , width, height, colors[c].r, colors[c].g, colors[c].b); -igt_put_cairo_ctx (data->drm_fd, fb, cr); +igt_put_cairo_ctx (cr); } ret =drmIoctl (data->drm_fd,LOCAL_DRM_IOCTL_MODE_ADDFB2 , &f);
tests/kms_color_helper.c +2 -2
@@ -57,7 +57,7 @@ void paint_gradient_rectangles(data_t *data, colors[i-1 ].g, colors[i-1].b); -igt_put_cairo_ctx (data->drm_fd, fb, cr); +igt_put_cairo_ctx (cr); } void paint_rectangles(data_t *data,
@@ -79,7 +79,7 @@ void paint_rectangles(data_t *data,igt_paint_color (cr, i * l,0 , rows_remaining, mode->vdisplay, colors[i-1 ].r, colors[i-1 ].g, colors[i-1 ].b); -igt_put_cairo_ctx (data->drm_fd, fb, cr); +igt_put_cairo_ctx (cr); }gamma_lut_t *alloc_lut (int lut_size)
tests/kms_concurrent.c +1 -1
@@ -126,7 +126,7 @@ create_fb_for_mode_position(data_t *data, drmModeModeInfo *mode, rect_w[i], rect_h[i], 0.0, 0.0, 0.0); } -igt_put_cairo_ctx (data->drm_fd, &data->fb[primary->index], cr); +igt_put_cairo_ctx (cr); } static void
tests/kms_crtc_background_color.c +1 -1
@@ -69,7 +69,7 @@ paint_background(data_t *data, struct igt_fb *fb, drmModeModeInfo *mode, b = (double ) ((background &0xFF0000 ) >>16 ) /255.0 ;igt_paint_color_alpha (cr,0 ,0 , w, h, r, g, b, alpha); -igt_put_cairo_ctx (data->gfx_fd, &data->fb, cr); +igt_put_cairo_ctx (cr); } static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe,
tests/kms_cursor_crc.c +10 -12
@@ -167,8 +167,7 @@ static void restore_image(data_t *data)cairo_set_source_surface (cr, data->surface,0 ,0 );cairo_rectangle (cr,0 ,0 , data->screenw, data->screenh);cairo_fill (cr); -igt_put_cairo_ctx (data->drm_fd, - &data->primary_fb[FRONTBUFFER ], cr); +igt_put_cairo_ctx (cr); }igt_dirty_fb (data->drm_fd, &data->primary_fb[FRONTBUFFER ]); }
@@ -235,7 +234,7 @@ static void do_single_test(data_t *data, int x, int y)/* Now render the same in software and collect crc */ cr =igt_get_cairo_ctx (data->drm_fd, &data->primary_fb[FRONTBUFFER ]);draw_cursor (cr, x, y, data->curw, data->curh,1.0 ); -igt_put_cairo_ctx (data->drm_fd, &data->primary_fb[FRONTBUFFER ], cr); +igt_put_cairo_ctx (cr);igt_display_commit (display);igt_dirty_fb (data->drm_fd, &data->primary_fb[FRONTBUFFER ]);/* Extra vblank wait is because nonblocking cursor ioctl */
@@ -451,8 +450,7 @@ static void prepare_crtc(data_t *data, igt_output_t *output, &data->primary_fb[RESTOREBUFFER]);cairo_set_operator (cr,CAIRO_OPERATOR_SOURCE );igt_paint_test_pattern (cr, data->screenw, data->screenh); -igt_put_cairo_ctx (data->drm_fd, - &data->primary_fb[RESTOREBUFFER ], cr); +igt_put_cairo_ctx (cr); data->drmibo[FRONTBUFFER] = gem_handle_to_libdrm_bo(data->bufmgr, data->drm_fd,
@@ -493,7 +491,7 @@ static void test_cursor_alpha(data_t *data, double a)igt_assert (fb_id); cr =igt_get_cairo_ctx (data->drm_fd, &data->fb);igt_paint_color_alpha (cr,0 ,0 , curw, curh,1.0 ,1.0 ,1.0 , a); -igt_put_cairo_ctx (data->drm_fd, &data->fb, cr); +igt_put_cairo_ctx (cr);/*Hardware Test*/ cursor_enable (data);
@@ -506,7 +504,7 @@ static void test_cursor_alpha(data_t *data, double a)/*Software Test*/ cr =igt_get_cairo_ctx (data->drm_fd, &data->primary_fb[FRONTBUFFER ]);igt_paint_color_alpha (cr,0 ,0 , curw, curh,1.0 ,1.0 ,1.0 , a); -igt_put_cairo_ctx (data->drm_fd, &data->primary_fb[FRONTBUFFER ], cr); +igt_put_cairo_ctx (cr);igt_display_commit (display);igt_wait_for_vblank (data->drm_fd, data->pipe);
@@ -517,7 +515,7 @@ static void test_cursor_alpha(data_t *data, double a) cr =igt_get_cairo_ctx (data->drm_fd, &data->primary_fb[FRONTBUFFER ]);igt_paint_color (cr,0 ,0 , data->screenw, data->screenh,0.0 ,0.0 ,0.0 ); -igt_put_cairo_ctx (data->drm_fd, &data->primary_fb[FRONTBUFFER ], cr); +igt_put_cairo_ctx (cr); }static void test_cursor_transparent (data_t *data)
@@ -559,7 +557,7 @@ static void create_cursor_fb(data_t *data, int cur_w, int cur_h) cr =igt_get_cairo_ctx (data->drm_fd, &data->fb);draw_cursor (cr,0 ,0 , cur_w, cur_h,1.0 ); -igt_put_cairo_ctx (data->drm_fd, &data->fb, cr); +igt_put_cairo_ctx (cr); }static bool has_nonsquare_cursors (data_t *data)
@@ -605,7 +603,7 @@ static void test_cursor_size(data_t *data)/* Use a solid white rectangle as the cursor */ cr =igt_get_cairo_ctx (data->drm_fd, &data->fb);igt_paint_color_alpha (cr,0 ,0 , cursor_max_size, cursor_max_size,1.0 ,1.0 ,1.0 ,1.0 ); -igt_put_cairo_ctx (data->drm_fd, &data->fb, cr); +igt_put_cairo_ctx (cr);/* Hardware test loop */ cursor_enable (data);
@@ -625,7 +623,7 @@ static void test_cursor_size(data_t *data)/* Now render the same in software and collect crc */ cr =igt_get_cairo_ctx (data->drm_fd, &data->primary_fb[FRONTBUFFER ]);igt_paint_color_alpha (cr,0 ,0 , size, size,1.0 ,1.0 ,1.0 ,1.0 ); -igt_put_cairo_ctx (data->drm_fd, &data->primary_fb[FRONTBUFFER ], cr); +igt_put_cairo_ctx (cr);igt_display_commit (display);igt_wait_for_vblank (data->drm_fd, data->pipe);
@@ -634,7 +632,7 @@ static void test_cursor_size(data_t *data) cr =igt_get_cairo_ctx (data->drm_fd, &data->primary_fb[FRONTBUFFER ]);igt_paint_color (cr,0 ,0 , data->screenw, data->screenh,0.0 ,0.0 ,0.0 ); -igt_put_cairo_ctx (data->drm_fd, &data->primary_fb[FRONTBUFFER ], cr); +igt_put_cairo_ctx (cr);igt_assert_crc_equal (&crc[i], &ref_crc); } }
tests/kms_cursor_edge_walk.c +1 -1
@@ -78,7 +78,7 @@ static void create_cursor_fb(data_t *data, int cur_w, int cur_h)else igt_paint_color_alpha (cr,0 ,0 , data->fb.width, data->fb.height,0.0 ,0.0 ,0.0 ,0.0 ); -igt_put_cairo_ctx (data->drm_fd, &data->fb, cr); +igt_put_cairo_ctx (cr); }static void cursor_move (data_t *data,int x,int y,int i)
tests/kms_flip.c +1 -1
@@ -983,7 +983,7 @@ static void paint_flip_mode(struct igt_fb *fb, bool odd_frame)cairo_set_source_rgb (cr,1 ,1 ,1 );cairo_fill (cr); -igt_put_cairo_ctx (drm_fd, fb, cr); +igt_put_cairo_ctx (cr); }static bool fb_is_bound (struct test_output *o,int fb)
tests/kms_hdr.c +1 -1
@@ -141,7 +141,7 @@ static void draw_hdr_pattern(igt_fb_t *fb)igt_paint_color (cr,0 ,0 , fb->width, fb->height,1.0 ,1.0 ,1.0 );igt_paint_test_pattern (cr, fb->width, fb->height); -igt_put_cairo_ctx (fb->fd, fb, cr); +igt_put_cairo_ctx (cr); }/* Prepare test data. */
tests/kms_mmap_write_crc.c +2 -2
@@ -92,7 +92,7 @@ static void test(data_t *data) cr =igt_get_cairo_ctx (data->drm_fd, fb);igt_paint_test_pattern (cr, fb->width, fb->height); -igt_put_cairo_ctx (data->drm_fd, fb, cr); +igt_put_cairo_ctx (cr);/* flip to it to make it UC/WC and fully flushed */ igt_plane_set_fb (data->primary, fb);
@@ -135,7 +135,7 @@ static void test(data_t *data)* fully flushed */ cr =igt_get_cairo_ctx (data->drm_fd, fb);igt_paint_test_pattern (cr, fb->width, fb->height); -igt_put_cairo_ctx (data->drm_fd, fb, cr); +igt_put_cairo_ctx (cr);igt_plane_set_fb (data->primary, fb);igt_display_commit (display);
tests/kms_plane.c +4 -4
@@ -149,7 +149,7 @@ create_fb_for_mode__position(data_t *data, drmModeModeInfo *mode,igt_paint_color (cr,0 ,0 , mode->hdisplay, mode->vdisplay,0.0 ,1.0 ,0.0 );igt_paint_color (cr, rect_x, rect_y, rect_w, rect_h,0.0 ,0.0 ,0.0 ); -igt_put_cairo_ctx (data->drm_fd, fb, cr); +igt_put_cairo_ctx (cr); }enum {
@@ -284,7 +284,7 @@ create_fb_for_mode__panning(data_t *data, drmModeModeInfo *mode, mode->hdisplay, mode->vdisplay, 0.0, 0.0, 1.0); -igt_put_cairo_ctx (data->drm_fd, fb, cr); +igt_put_cairo_ctx (cr); }enum {
@@ -460,7 +460,7 @@ static void prepare_format_color(data_t *data, enum pipe pipe,igt_paint_color (cr,0 ,0 , width, height, c->red, c->green, c->blue); -igt_put_cairo_ctx (data->drm_fd, fb, cr); +igt_put_cairo_ctx (cr); }else { igt_create_fb_with_bo_size(data->drm_fd, width + data->crop * 2,
@@ -485,7 +485,7 @@ static void prepare_format_color(data_t *data, enum pipe pipe, width, height, c->red, c->green, c->blue); -igt_put_cairo_ctx (data->drm_fd, fb, cr); +igt_put_cairo_ctx (cr); }igt_plane_set_fb (plane, fb);
tests/kms_plane_alpha_blend.c +5 -5
@@ -60,7 +60,7 @@ static void draw_gradient(struct igt_fb *fb, int w, int h, double a)__draw_gradient (fb, w, h, a, cr); -igt_put_cairo_ctx (fb->fd, fb, cr); +igt_put_cairo_ctx (cr); }static void draw_gradient_coverage (struct igt_fb *fb,int w,int h,uint8_t a)
@@ -76,7 +76,7 @@ static void draw_gradient_coverage(struct igt_fb *fb, int w, int h, uint8_t a)for (i =0 ; i < w; i++) data[i *4 +3 ] = a; -igt_put_cairo_ctx (fb->fd, fb, cr); +igt_put_cairo_ctx (cr); }static void draw_squares (struct igt_fb *fb,int w,int h,double a)
@@ -90,7 +90,7 @@ static void draw_squares(struct igt_fb *fb, int w, int h, double a)igt_paint_color_alpha (cr, w /2 , h /2 , w /4 , h /2 ,1. ,1. ,1. , a);igt_paint_color_alpha (cr,3 * w /4 , h /2 , w /4 , h /2 ,0. ,0. ,0. , a); -igt_put_cairo_ctx (fb->fd, fb, cr); +igt_put_cairo_ctx (cr); }static void draw_squares_coverage (struct igt_fb *fb,int w,int h,uint8_t as)
@@ -120,7 +120,7 @@ static void draw_squares_coverage(struct igt_fb *fb, int w, int h, uint8_t as) data[j * stride + i] = a; } -igt_put_cairo_ctx (fb->fd, fb, cr); +igt_put_cairo_ctx (cr); }static void reset_alpha (igt_display_t *display,enum pipe pipe)
@@ -200,7 +200,7 @@ static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe) cr =igt_get_cairo_ctx (data->gfx_fd, &data->argb_fb_0);cairo_set_operator (cr,CAIRO_OPERATOR_SOURCE );igt_paint_color_alpha (cr,0 ,0 , w, h,0. ,0. ,0. ,0.0 ); -igt_put_cairo_ctx (data->gfx_fd, &data->argb_fb_0, cr); +igt_put_cairo_ctx (cr); igt_create_fb(data->gfx_fd, w, h, DRM_FORMAT_ARGB8888, LOCAL_DRM_FORMAT_MOD_NONE,
tests/kms_plane_cursor.c +2 -2
@@ -102,7 +102,7 @@ static void draw_color(igt_fb_t *fb, double r, double g, double b)cairo_set_operator (cr,CAIRO_OPERATOR_SOURCE );igt_paint_color (cr,0 ,0 , fb->width, fb->height, r, g, b); -igt_put_cairo_ctx (fb->fd, fb, cr); +igt_put_cairo_ctx (cr); }/*
@@ -129,7 +129,7 @@ static void test_cursor_pos(data_t *data, igt_fb_t *pfb, igt_fb_t *ofb,igt_paint_color (cr, or->x, or->y, or->w, or->h,0.5 ,0.5 ,0.5 );igt_paint_color (cr, x, y, cw, ch,1.0 ,0.0 ,1.0 ); -igt_put_cairo_ctx (pfb->fd, pfb, cr); +igt_put_cairo_ctx (cr);igt_plane_set_fb (data->overlay,NULL );igt_plane_set_fb (data->cursor,NULL );
tests/kms_plane_lowres.c +1 -1
@@ -158,7 +158,7 @@ static void create_ref_fb(data_t *data, uint64_t modifier, cr =igt_get_cairo_ctx (data->drm_fd, fb);blit (data, cr, &data->fb_primary,0 ,0 );blit (data, cr, &data->fb_plane[0 ], data->x, data->y); -igt_put_cairo_ctx (data->drm_fd, fb, cr); +igt_put_cairo_ctx (cr); } static unsigned
tests/kms_plane_multiple.c +1 -1
@@ -159,7 +159,7 @@ create_fb_for_mode_position(data_t *data, igt_output_t *output, drmModeModeInfo rect_w[i], rect_h[i], 0.0, 0.0, 0.0); } -igt_put_cairo_ctx (data->drm_fd, &data->fb[primary->index], cr); +igt_put_cairo_ctx (cr); }
tests/kms_psr.c +1 -1
@@ -88,7 +88,7 @@ static void create_cursor_fb(data_t *data) cr =igt_get_cairo_ctx (data->drm_fd, &data->fb_white);igt_paint_color_alpha (cr,0 ,0 ,64 ,64 ,1.0 ,1.0 ,1.0 ,1.0 ); -igt_put_cairo_ctx (data->drm_fd, &data->fb_white, cr); +igt_put_cairo_ctx (cr); }static void setup_output (data_t *data)
tests/kms_psr2_su.c +2 -2
@@ -132,7 +132,7 @@ static void prepare(data_t *data)/* paint a white square */ igt_paint_color_alpha (cr,0 ,0 ,SQUARE_SIZE ,SQUARE_SIZE ,1.0 ,1.0 ,1.0 ,1.0 ); -igt_put_cairo_ctx (data->drm_fd, &data->fb[1 ], cr); +igt_put_cairo_ctx (cr); }else if (data->op ==FRONTBUFFER ) { data->cr =igt_get_cairo_ctx (data->drm_fd, &data->fb[0 ]); }
@@ -226,7 +226,7 @@ static void cleanup(data_t *data)if (data->op ==PAGE_FLIP )igt_remove_fb (data->drm_fd, &data->fb[1 ]);else if (data->op ==FRONTBUFFER ) -igt_put_cairo_ctx (data->drm_fd, &data->fb[0 ], data->cr); +igt_put_cairo_ctx (data->cr);igt_remove_fb (data->drm_fd, &data->fb[0 ]); }
tests/kms_rotation_crc.c +1 -1
@@ -148,7 +148,7 @@ paint_squares(data_t *data, igt_rotation_t rotation,igt_paint_color (cr,0 , h /2 , w /2 , h /2 ,RGB_COLOR (bl));igt_paint_color (cr, w /2 , h /2 , w /2 , h /2 ,RGB_COLOR (br)); -igt_put_cairo_ctx (data->gfx_fd, fb, cr); +igt_put_cairo_ctx (cr); }static void remove_fbs (data_t *data)
tests/kms_setmode.c +1 -1
@@ -161,7 +161,7 @@ static int paint_fb(struct igt_fb *fb, const char *test_name, crtc_str[i]); } -igt_put_cairo_ctx (drm_fd, fb, cr); +igt_put_cairo_ctx (cr);return 0 ; }
tests/kms_vrr.c +1 -1
@@ -186,7 +186,7 @@ static void prepare_test(data_t *data, igt_output_t *output, enum pipe pipe)igt_paint_color (cr,0 ,0 , mode.hdisplay /10 , mode.vdisplay /10 ,1.00 ,0.00 ,0.00 ); -igt_put_cairo_ctx (data->drm_fd, &data->fb0, cr); +igt_put_cairo_ctx (cr);/* Take care of any required modesetting before the test begins. */ primary =igt_output_get_plane_type (output,DRM_PLANE_TYPE_PRIMARY );
tests/testdisplay.c +2 -2
@@ -232,7 +232,7 @@ paint_color_key(struct igt_fb *fb_info)cairo_set_source_rgb (cr,.8 ,.8 ,.8 );cairo_fill (cr); -igt_put_cairo_ctx (drm_fd, fb_info, cr); +igt_put_cairo_ctx (cr); }static void paint_image (cairo_t *cr,const char *file)
@@ -317,7 +317,7 @@ static void paint_output_info(struct connector *c, struct igt_fb *fb)if (qr_code)paint_image (cr,"pass.png" ); -igt_put_cairo_ctx (drm_fd, fb, cr); +igt_put_cairo_ctx (cr); }static void sighandler (int signo)
Signature · 6 lines
2.27.0 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for lib/igt_fb: remove extra parameters from igt_put_cairo_ctx
== Series Details ==
== Series Details ==
Series: lib/igt_fb: remove extra parameters from igt_put_cairo_ctx
URL : https://patchwork.freedesktop.org/series/79162/
State : success
== Summary ==
CI Bug Log - changes from IGT_5725 -> IGTPW_4743
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/index.html
Known issues
------------
Here are the changes found in IGTPW_4743 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/fi-bsw-kefka/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/fi-bsw-kefka/igt@[email protected]
* igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/fi-tgl-y/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/fi-tgl-y/igt@[email protected]
* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- fi-icl-u2: [PASS][5] -> [DMESG-WARN][6] ([i915#1982]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/fi-icl-u2/igt@kms_flip@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/fi-icl-u2/igt@kms_flip@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-u2: [FAIL][7] ([i915#1888]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/fi-tgl-u2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/fi-tgl-u2/igt@[email protected]
* igt@gem_flink_basic@basic:
- fi-tgl-y: [DMESG-WARN][9] ([i915#402]) -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/fi-tgl-y/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/fi-tgl-y/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- {fi-kbl-7560u}: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/fi-kbl-7560u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/fi-kbl-7560u/igt@[email protected]
- {fi-tgl-dsi}: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/fi-tgl-dsi/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/fi-tgl-dsi/igt@[email protected]
#### Warnings ####
* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][15] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][16] ([i915#62] / [i915#92]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/fi-kbl-x1275/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/fi-kbl-x1275/igt@[email protected]
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][17] ([i915#62] / [i915#92]) -> [DMESG-WARN][18] ([i915#62] / [i915#92] / [i915#95]) +6 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/fi-kbl-x1275/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/fi-kbl-x1275/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (43 -> 37)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5725 -> IGTPW_4743
CI-20190529: 20190529
CI_DRM_8708: 170e94a1430fd0a4f0841ad0f7366904d52e49be @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4743: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/index.html
IGT_5725: d31a5ba83d7f548c86d0e5486f1f44a5563020d6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for lib/igt_fb: remove extra parameters from igt_put_cairo_ctx
In reply to Melissa Wen== Series Details ==
== Series Details ==
Series: lib/igt_fb: remove extra parameters from igt_put_cairo_ctx
URL : https://patchwork.freedesktop.org/series/79162/
State : success
== Summary ==
CI Bug Log - changes from IGT_5725_full -> IGTPW_4743_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/index.html
Known issues
------------
Here are the changes found in IGTPW_4743_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_reloc@basic-wc-cpu-noreloc:
- shard-apl: [PASS][1] -> [DMESG-WARN][2] ([i915#1635] / [i915#95]) +29 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-apl7/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-apl1/igt@[email protected]
* igt@kms_addfb_basic@too-wide:
- shard-hsw: [PASS][3] -> [TIMEOUT][4] ([i915#1958] / [i915#2119]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-hsw2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-hsw1/igt@[email protected]
* igt@kms_atomic_transition@2x-modeset-transitions-nonblocking:
- shard-hsw: [PASS][5] -> [TIMEOUT][6] ([i915#1320] / [i915#1958] / [i915#2119])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-hsw4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-hsw1/igt@[email protected]
* igt@kms_big_fb@linear-64bpp-rotate-180:
- shard-apl: [PASS][7] -> [DMESG-WARN][8] ([i915#1982]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-apl8/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-apl4/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-256x85-offscreen:
- shard-kbl: [PASS][9] -> [DMESG-FAIL][10] ([i915#54] / [i915#95])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-kbl7/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-kbl6/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-dpms:
- shard-snb: [PASS][11] -> [TIMEOUT][12] ([i915#1958] / [i915#2119]) +4 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-snb6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-snb1/igt@[email protected]
* igt@kms_cursor_legacy@pipe-b-torture-bo:
- shard-tglb: [PASS][13] -> [DMESG-WARN][14] ([i915#128])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-tglb7/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-tglb8/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-xtiled:
- shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([i915#93] / [i915#95]) +44 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-kbl3/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-kbl6/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb2101010-render-xtiled:
- shard-iclb: [PASS][17] -> [FAIL][18] ([i915#52] / [i915#54])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-iclb3/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-iclb7/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][19] -> [FAIL][20] ([i915#1525])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-apl1/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-apl4/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#79])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-glk5/igt@kms_flip@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-glk8/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-tglb: [PASS][23] -> [INCOMPLETE][24] ([i915#456])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-tglb3/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-tglb3/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-render:
- shard-tglb: [PASS][25] -> [DMESG-WARN][26] ([i915#1982])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-tglb6/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-tglb2/igt@[email protected]
* igt@kms_panel_fitting@atomic-fastset:
- shard-tglb: [PASS][27] -> [FAIL][28] ([i915#83])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-tglb8/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-tglb6/igt@[email protected]
- shard-iclb: [PASS][29] -> [FAIL][30] ([i915#83])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-iclb6/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-iclb3/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- shard-apl: [PASS][31] -> [DMESG-FAIL][32] ([i915#1635] / [i915#95]) +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-apl7/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-apl6/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][33] -> [DMESG-FAIL][34] ([i915#95]) +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-kbl6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-kbl1/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [PASS][35] -> [DMESG-WARN][36] ([i915#180]) +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-kbl6/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-kbl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-mid:
- shard-kbl: [PASS][37] -> [DMESG-FAIL][38] ([fdo#108145] / [i915#95])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-kbl4/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-kbl3/igt@[email protected]
- shard-apl: [PASS][39] -> [DMESG-FAIL][40] ([fdo#108145] / [i915#1635] / [i915#95])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-apl6/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-apl2/igt@[email protected]
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-iclb: [PASS][41] -> [FAIL][42] ([i915#1779])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-iclb6/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-iclb7/igt@[email protected]
* igt@kms_psr2_su@page_flip:
- shard-tglb: [PASS][43] -> [SKIP][44] ([i915#1911])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-tglb1/igt@kms_psr2_su@page_flip.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-tglb1/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][45] -> [SKIP][46] ([fdo#109441])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-iclb7/igt@kms_psr@psr2_sprite_plane_move.html
#### Possible fixes ####
* igt@gem_exec_whisper@basic-fds-all:
- shard-glk: [DMESG-WARN][47] ([i915#118] / [i915#95]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-glk3/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-glk7/igt@[email protected]
* igt@gem_userptr_blits@invalid-mmap-offset-unsync@gtt:
- shard-iclb: [INCOMPLETE][49] ([i915#2119]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-iclb2/igt@gem_userptr_blits@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-iclb1/igt@gem_userptr_blits@[email protected]
* igt@gem_userptr_blits@stress-mm-invalidate-close:
- shard-hsw: [TIMEOUT][51] ([i915#1958] / [i915#2119]) -> [PASS][52] +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-hsw7/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-hsw2/igt@[email protected]
* igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
- shard-apl: [DMESG-WARN][53] ([i915#1635] / [i915#95]) -> [PASS][54] +37 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-apl7/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-apl8/igt@[email protected]
* igt@kms_big_fb@y-tiled-64bpp-rotate-180:
- shard-glk: [DMESG-FAIL][55] ([i915#118] / [i915#95]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-glk8/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-glk6/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen:
- shard-kbl: [DMESG-FAIL][57] ([i915#54] / [i915#95]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-kbl4/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-kbl1/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen:
- shard-kbl: [FAIL][59] ([i915#54]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-kbl6/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-kbl2/igt@[email protected]
- shard-apl: [FAIL][61] ([i915#54]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-apl4/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-apl6/igt@[email protected]
- shard-glk: [FAIL][63] ([i915#54]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-glk8/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-glk7/igt@[email protected]
* igt@kms_flip@2x-modeset-vs-vblank-race@ab-hdmi-a1-hdmi-a2:
- shard-glk: [DMESG-WARN][65] ([i915#1982]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-glk1/igt@kms_flip@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-glk3/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][67] ([i915#180]) -> [PASS][68] +6 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-kbl3/igt@kms_flip@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-kbl1/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
- shard-tglb: [DMESG-WARN][69] ([i915#1982]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-tglb1/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-tglb3/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-rte:
- shard-glk: [FAIL][71] ([i915#49]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-glk3/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-glk4/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-kbl: [DMESG-FAIL][73] ([fdo#108145] / [i915#95]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-kbl2/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-kbl3/igt@[email protected]
- shard-apl: [DMESG-FAIL][75] ([fdo#108145] / [i915#1635] / [i915#95]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-apl6/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-apl2/igt@[email protected]
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][77] ([fdo#109441]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_vblank@pipe-a-wait-forked-busy-hang:
- shard-snb: [TIMEOUT][79] ([i915#1958] / [i915#2119]) -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-snb6/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-snb6/igt@[email protected]
* igt@kms_vblank@pipe-c-accuracy-idle:
- shard-apl: [DMESG-WARN][81] ([i915#1982]) -> [PASS][82] +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-apl2/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-apl2/igt@[email protected]
* igt@kms_vblank@pipe-c-wait-forked:
- shard-kbl: [DMESG-WARN][83] ([i915#93] / [i915#95]) -> [PASS][84] +45 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-kbl4/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-kbl2/igt@[email protected]
* igt@perf@blocking-parameterized:
- shard-iclb: [FAIL][85] ([i915#1542]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-iclb1/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-iclb4/igt@[email protected]
#### Warnings ####
* igt@gem_exec_reloc@basic-spin-others@vcs0:
- shard-snb: [WARN][87] ([i915#2021]) -> [WARN][88] ([i915#2036])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-snb5/igt@gem_exec_reloc@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-snb6/igt@gem_exec_reloc@[email protected]
* igt@kms_atomic_transition@2x-modeset-transitions-nonblocking:
- shard-snb: [SKIP][89] ([fdo#109271]) -> [TIMEOUT][90] ([i915#1958] / [i915#2119])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-snb5/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-snb1/igt@[email protected]
* igt@kms_chamelium@hdmi-edid-read:
- shard-apl: [SKIP][91] ([fdo#109271] / [fdo#111827] / [i915#1635]) -> [SKIP][92] ([fdo#109271] / [fdo#111827])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-apl4/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-apl4/igt@[email protected]
* igt@kms_color_chamelium@pipe-b-ctm-0-5:
- shard-apl: [SKIP][93] ([fdo#109271] / [fdo#111827]) -> [SKIP][94] ([fdo#109271] / [fdo#111827] / [i915#1635])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-apl8/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-apl1/igt@[email protected]
* igt@kms_concurrent@pipe-c:
- shard-snb: [TIMEOUT][95] ([i915#1958] / [i915#2119]) -> [SKIP][96] ([fdo#109271]) +2 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-snb6/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-snb2/igt@[email protected]
* igt@kms_content_protection@lic:
- shard-kbl: [TIMEOUT][97] ([i915#1319] / [i915#2119]) -> [TIMEOUT][98] ([i915#1319] / [i915#1958] / [i915#2119])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-kbl3/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-kbl4/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [DMESG-WARN][99] ([i915#180]) -> [FAIL][100] ([i915#64])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-kbl7/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-kbl4/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render:
- shard-hsw: [SKIP][101] ([fdo#109271]) -> [TIMEOUT][102] ([i915#1958] / [i915#2119])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-hsw2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-shrfb-scaledprimary:
- shard-hsw: [TIMEOUT][103] ([i915#1958] / [i915#2119]) -> [SKIP][104] ([fdo#109271]) +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-hsw7/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-hsw4/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-pwrite:
- shard-apl: [SKIP][105] ([fdo#109271]) -> [SKIP][106] ([fdo#109271] / [i915#1635]) +9 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-apl2/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-apl4/igt@[email protected]
* igt@kms_plane_cursor@pipe-d-viewport-size-128:
- shard-apl: [SKIP][107] ([fdo#109271] / [i915#1635]) -> [SKIP][108] ([fdo#109271]) +19 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-apl4/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-apl1/igt@[email protected]
* igt@kms_setmode@basic:
- shard-apl: [DMESG-FAIL][109] ([i915#1635] / [i915#31] / [i915#95]) -> [FAIL][110] ([i915#31])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-apl7/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-apl6/igt@[email protected]
- shard-kbl: [DMESG-WARN][111] ([i915#93] / [i915#95]) -> [FAIL][112] ([i915#31])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-kbl7/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-kbl4/igt@[email protected]
* igt@runner@aborted:
- shard-apl: ([FAIL][113], [FAIL][114]) ([i915#1610] / [i915#1635] / [i915#2110]) -> [FAIL][115] ([i915#1635] / [i915#2110])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-apl2/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5725/shard-apl6/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/shard-apl8/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#128]: https://gitlab.freedesktop.org/drm/intel/issues/128
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1320]: https://gitlab.freedesktop.org/drm/intel/issues/1320
[i915#1525]: https://gitlab.freedesktop.org/drm/intel/issues/1525
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1779]: https://gitlab.freedesktop.org/drm/intel/issues/1779
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2021]: https://gitlab.freedesktop.org/drm/intel/issues/2021
[i915#2036]: https://gitlab.freedesktop.org/drm/intel/issues/2036
[i915#2110]: https://gitlab.freedesktop.org/drm/intel/issues/2110
[i915#2119]: https://gitlab.freedesktop.org/drm/intel/issues/2119
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#64]: https://gitlab.freedesktop.org/drm/intel/issues/64
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#83]: https://gitlab.freedesktop.org/drm/intel/issues/83
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (8 -> 8)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5725 -> IGTPW_4743
CI-20190529: 20190529
CI_DRM_8708: 170e94a1430fd0a4f0841ad0f7366904d52e49be @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4743: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/index.html
IGT_5725: d31a5ba83d7f548c86d0e5486f1f44a5563020d6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4743/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 6 lines · Melissa Wen
The function
igt_put_cairo_ctxcurrently requires three parameters, but only one of them is used in it. This patch removes the useless parameters, making the code more readable and cohesive. It also applies the change to all occurrences of the function in the code.Signed-off-by Melissa Wen <[email protected]>
Thanks for the patch, it's merged now :-)
For similar refactors you may find coccinelle[0] handy.
There's some examples in lib/igt.cocci + a few people use that tool to do the changes and posted the cocci patch as a part of the commit message. e.g.: 7ff35cc1d0b3 ("lib/igt_buf: Extend igt_buf to include two color surfaces")
[0]: http://coccinelle.lip6.fr/
Signature · 6 lines
Cheers, Arek _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 11 lines · Arkadiusz Hiler
Quoted 6 lines · Melissa Wen
The function
igt_put_cairo_ctxcurrently requires three parameters, but only one of them is used in it. This patch removes the useless parameters, making the code more readable and cohesive. It also applies the change to all occurrences of the function in the code.Signed-off-by Melissa Wen <[email protected]>Reviewed-by Arkadiusz Hiler <[email protected]>Thanks for the patch, it's merged now :-)
Quoted 8 lines
For similar refactors you may find coccinelle[0] handy.
There's some examples in
lib/igt.cocci+ a few people use that tool to do the changes and posted the cocci patch as a part of the commit message. e.g.:7ff35cc1d0b3("lib/igt_buf: Extendigt_bufto include two color surfaces")
Hi Arek,
Thanks for reviewing. I'll try Coccinelle next time.
I sent two other patchsets (one for documentation and another with minor fixes in the kms_cursor_crc test) that stuck. They succeeded at CI.BAT and failed at CI.IGT; however, the failures look like a false positive.
https://patchwork.freedesktop.org/series/78814/
https://patchwork.freedesktop.org/series/78813/
Do you mind taking a look and giving me some feedback?
Thanks in advance,
Melissa
Quoted 8 lines
Signature · 7 lines
Cheers, Arek -- You received this message because you are subscribed to the Google Groups "Kernel USP" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/kernel-usp/20200707150750.62zmal6s45njyxet%40ahiler-desk1.fi.intel.com.
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev