Skip to contentSkip to conversation

Revert "riscv: sifive: fu540: Add gpio-restart support"

PATCH New Tom Rini 1 participant 2 messages Jul 6, 2020 – Jul 7, 2020 SiFive drivers

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

PATCH 1/1 Revert "riscv: sifive: fu540: Add gpio-restart support"

As part of merging the next branch in to master, the sifive_fu540 will fail to link:
riscv64-linux-ld.bfd: lib/built-in.o: in function `panic_finish':
lib/panic.c:28: undefined reference to `do_reset'
make[2]: *** [spl/u-boot-spl] Error 1
make[1]: *** [spl/u-boot-spl] Error 2
make: *** [sub-make] Error 2

And while the "fix the build" option of enabling CONFIG_SPL_SYSRESET may solve the issue, it is unclear that it is the correct path exactly. For the moment, I am reverting this commit and take a "revert the revert" and proper fix as soon as it's available.

This reverts commit cdae446461191714d692190da1ad4344398adc57.

Cc Paul Walmsley <[email protected]>
Cc Palmer Dabbelt <[email protected]>
Cc Anup Patel <[email protected]>
Cc Atish Patra <[email protected]>
Cc Bin Meng <[email protected]>
---
 board/sifive/fu540/Kconfig | 2 --
 1 file changed, 2 deletions(-)
board/sifive/fu540/Kconfig +0 -2
index 6f6568196561..86193d7668be 100644
@@ -65,7 +65,5 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	imply SMP
 	imply MISC
 	imply SIFIVE_OTP
-	imply SYSRESET
-	imply SYSRESET_GPIO
 
 endif
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 1/1 Revert "riscv: sifive: fu540: Add gpio-restart support"

Quoted 13 lines · Tom Rini

As part of merging the next branch in to master, the sifive_fu540 will fail to link:
riscv64-linux-ld.bfd: lib/built-in.o: in function `panic_finish':
lib/panic.c:28: undefined reference to `do_reset'
make[2]: *** [spl/u-boot-spl] Error 1
make[1]: *** [spl/u-boot-spl] Error 2
make: *** [sub-make] Error 2

And while the "fix the build" option of enabling CONFIG_SPL_SYSRESET may solve the issue, it is unclear that it is the correct path exactly. For the moment, I am reverting this commit and take a "revert the revert" and proper fix as soon as it's available.

Quoted 8 lines

This reverts commit cdae446461191714d692190da1ad4344398adc57.

Cc Paul Walmsley <[email protected]>
Cc Palmer Dabbelt <[email protected]>
Cc Anup Patel <[email protected]>
Cc Atish Patra <[email protected]>
Cc Bin Meng <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200707/f5a7ec27/attachment.sig>