Skip to contentSkip to conversation

configure: support ipset version 7 with kernel version 5

PATCH In review Tony Ambardar 2 participants 3 messages Jul 7, 2020 – Jul 9, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configure: support ipset version 7 with kernel version 5

The configure script checks for ipset v6 availability but doesn't test for v7, which is backward compatible and used on kernel v5.x systems. Update the script to test for both ipset versions. Without this change, the tc ematch function em_ipset will be disabled.

---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index f415bf49..307912aa 100755
@@ -208,7 +208,7 @@ typedef unsigned short ip_set_id_t;
 #include <linux/netfilter/xt_set.h>
 
 struct xt_set_info info;
-#if IPSET_PROTOCOL == 6
+#if IPSET_PROTOCOL == 6 || IPSET_PROTOCOL == 7
 int main(void)
 {
 	return IPSET_MAXNAMELEN;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 6 lines · On Tue, 7 Jul 2020 00:58:33 -0700 Tony Ambardar <[email protected]>…

The configure script checks for ipset v6 availability but doesn't test for v7, which is backward compatible and used on kernel v5.x systems. Update the script to test for both ipset versions. Without this change, the tc ematch function em_ipset will be disabled.

Sure applied. Maybe it should just check for > 6 to be future proof.

#2 lore raw
Quoted 4 lines · Stephen Hemminger

On Tue, 7 Jul 2020 00:58:33 -0700
Tony Ambardar <[email protected]> wrote:

Quoted 8 lines
Quoted 6 lines

The configure script checks for ipset v6 availability but doesn't test for v7, which is backward compatible and used on kernel v5.x systems. Update the script to test for both ipset versions. Without this change, the tc ematch function em_ipset will be disabled.

Sure applied. Maybe it should just check for > 6 to be future proof.

Thank you. I kept the test as is since I couldn't confirm ipset backward compatibility in
the future. If you have more insight, please let me know and I'll update it.