ipv6: Fix use of anycast address with loopback
Subsystems (3)
David Ahern
maintainerPATCH 1/1 ipv6: Fix use of anycast address with loopback
Thomas reported a regression with IPv6 and anycast using the following reproducer:
echo 1 > /proc/sys/net/ipv6/conf/all/forwarding ip -6 a add fc12::1/16 dev lo
sleep 2
echo "pinging lo"
ping6 -c 2 fc12::
The conversion of addrconf_f6i_alloc to use ip6_route_info_create missed the use of fib6_is_reject which checks addresses added to the loopback interface and sets the REJECT flag as needed. Update fib6_is_reject for loopback checks to handle RTF_ANYCAST addresses.
--- net/ipv6/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv6/route.c +1 -1
@@ -3405,7 +3405,7 @@ static bool fib6_is_reject(u32 flags, struct net_device *dev, int addr_type)if ((flags &RTF_REJECT ) || (dev && (dev->flags &IFF_LOOPBACK ) && !(addr_type &IPV6_ADDR_LOOPBACK ) && - !(flags &RTF_LOCAL ))) + !(flags & (RTF_ANYCAST |RTF_LOCAL ))))return true;return false;
Signature · 1 line
2.17.1
From: David Ahern <[email protected]>
Date: Tue, 7 Jul 2020 07:39:24 -0600
Quoted 9 lines
Thomas reported a regression with IPv6 and anycast using the following reproducer:
echo 1 >
/proc/sys/net/ipv6/conf/all/forwardingip -6 a add fc12::1/16 dev lo
sleep 2
echo "pinging lo"
ping6 -c 2 fc12::
Quoted 8 lines
The conversion of
addrconf_f6i_allocto useip6_route_info_createmissed the use offib6_is_rejectwhich checks addresses added to the loopback interface and sets the REJECT flag as needed. Updatefib6_is_rejectfor loopback checks to handleRTF_ANYCASTaddresses.Fixes c7a1ce397ada ("ipv6: Change addrconf_f6i_alloc to use ip6_route_info_create")Reported-by [email protected]Signed-off-by David Ahern <[email protected]>
Applied, and queued up for -stable, thanks David.