Skip to contentSkip to conversation

drivers/input/touchscreen/edt-ft5x06.c:291 edt_ft5x06_register_write() warn: ignoring unreachable code.

PATCH In review Dan Carpenter 1 participant 1 message Jul 7, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 232/560 drivers/input/touchscreen/edt-ft5x06.c:291 edt_ft5x06_register_write() warn: ignoring unreachable code.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git testing/fallthrough
head:   d7f10c2411ed9283df8d763139de9468b88c89ce
commit: fd4bfbc7288bb10bad29069582680658042795ac [232/560] Input: Use fallthrough pseudo-keyword
config: i386-randconfig-m021-20200703 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0

If you fix the issue, kindly add following tag as appropriate

smatch warnings:
drivers/input/touchscreen/edt-ft5x06.c:291 edt_ft5x06_register_write() warn: ignoring unreachable code.

# https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/commit/?id=fd4bfbc7288bb10bad29069582680658042795ac
git remote add gustavoars-linux https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git
git remote update gustavoars-linux
git checkout fd4bfbc7288bb10bad29069582680658042795ac
vim +291 drivers/input/touchscreen/edt-ft5x06.c

43c4d13e901a8f Simon Budig         2012-07-24  278  static int edt_ft5x06_register_write(struct edt_ft5x06_ts_data *tsdata,
43c4d13e901a8f Simon Budig         2012-07-24  279  				     u8 addr, u8 value)
43c4d13e901a8f Simon Budig         2012-07-24  280  {
43c4d13e901a8f Simon Budig         2012-07-24  281  	u8 wrbuf[4];
43c4d13e901a8f Simon Budig         2012-07-24  282  
fd335ab04b3f1b Lothar Waßmann      2014-03-28  283  	switch (tsdata->version) {
169110c3645621 Simon Budig         2017-10-09  284  	case EDT_M06:
43c4d13e901a8f Simon Budig         2012-07-24  285  		wrbuf[0] = tsdata->factory_mode ? 0xf3 : 0xfc;
43c4d13e901a8f Simon Budig         2012-07-24  286  		wrbuf[1] = tsdata->factory_mode ? addr & 0x7f : addr & 0x3f;
43c4d13e901a8f Simon Budig         2012-07-24  287  		wrbuf[2] = value;
43c4d13e901a8f Simon Budig         2012-07-24  288  		wrbuf[3] = wrbuf[0] ^ wrbuf[1] ^ wrbuf[2];
fd335ab04b3f1b Lothar Waßmann      2014-03-28  289  		return edt_ft5x06_ts_readwrite(tsdata->client, 4,
                                                                ^^^^^^

fd335ab04b3f1b Lothar Waßmann 2014-03-28 290 wrbuf, 0, NULL);
fd4bfbc7288bb1 Gustavo A. R. Silva 2020-07-02 @291 fallthrough;

                                                                ^^^^^^^^^^^
169110c3645621 Simon Budig         2017-10-09  292  	case EDT_M09:
aed5d0ee77c007 Simon Budig         2017-10-09  293  	case EDT_M12:
a2f39dac0decd9 Marco Felsch        2019-01-13  294  	case EV_FT:
169110c3645621 Simon Budig         2017-10-09  295  	case GENERIC_FT:
fd335ab04b3f1b Lothar Waßmann      2014-03-28  296  		wrbuf[0] = addr;
fd335ab04b3f1b Lothar Waßmann      2014-03-28  297  		wrbuf[1] = value;
fd335ab04b3f1b Lothar Waßmann      2014-03-28  298  
cc071acaa2cf7b Robert Woerle       2014-06-07  299  		return edt_ft5x06_ts_readwrite(tsdata->client, 2,
fd335ab04b3f1b Lothar Waßmann      2014-03-28  300  					wrbuf, 0, NULL);
43c4d13e901a8f Simon Budig         2012-07-24  301  
fd335ab04b3f1b Lothar Waßmann      2014-03-28  302  	default:
fd335ab04b3f1b Lothar Waßmann      2014-03-28  303  		return -EINVAL;
fd335ab04b3f1b Lothar Waßmann      2014-03-28  304  	}

43c4d13e901a8f Simon Budig 2012-07-24 305 }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org