infoblock: Make output mutually exclusive
PATCH 1/1 infoblock: Make output mutually exclusive
Patch fixes checking output filter option (-o <file> or -c) of write-infoblock command to be mutually exclusive.
--- ndctl/namespace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ndctl/namespace.c +1 -1
@@ -440,7 +440,7 @@ static const char *parse_namespace_options(int argc, const char **argv, rc = -EINVAL ; } -if (action ==ACTION_WRITE_INFOBLOCK && (param.outfile || param.std_out) +if (action ==ACTION_WRITE_INFOBLOCK && (param.outfile && param.std_out) && argc) {error ("specify only one of a namespace filter, --output, or --stdout\n" ); rc = -EINVAL ;
Signature · 4 lines
2.26.2 _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
Quoted 4 lines · Harish
Patch fixes checking output filter option (-o <file> or -c) of write-infoblock command to be mutually exclusive.
Signed-off-by Harish <[email protected]>
Looks reasonable to me.
Quoted 22 lines
--- ndctl/namespace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)ndctl/namespace.c +1
-1@@ -440,7 +440,7 @@ static const char *parse_namespace_options(int argc, const char **argv, rc = -EINVAL ; } -if (action ==ACTION_WRITE_INFOBLOCK && (param.outfile || param.std_out) +if (action ==ACTION_WRITE_INFOBLOCK && (param.outfile && param.std_out) && argc) {error ("specify only one of a namespace filter, --output, or --stdout\n" ); rc = -EINVAL ;Signature · 4 lines
2.26.2 _______________________________________________ Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
_______________________________________________
Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]
This patch can be dropped as the error specifies namespace filter also is mutually exclusive with these options, so this is not needed. The usage confused me as it portrays namespace filtering to be mandatory as opposed to the Documentation.
Command line:
usage: ndctl write-infoblock <namespace> [<options>]
Sorry for the noise.
- Harish
Quoted 13 lines · Harish
Patch fixes checking output filter option (-o <file> or -c) of write-infoblock command to be mutually exclusive.
Signed-off-by Harish <[email protected]>--- ndctl/namespace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)ndctl/namespace.c +0
-0
ndctl/namespace.c static const char *parse_namespace_options(int argc, const char **argv, · line 446
Quoted 8 lines
ndctl/namespace.c +1
-1@@ -440,7 +440,7 @@ static const char *parse_namespace_options(int argc, const char **argv, rc = -EINVAL ; } -if (action ==ACTION_WRITE_INFOBLOCK && (param.outfile || param.std_out) +if (action ==ACTION_WRITE_INFOBLOCK && (param.outfile && param.std_out) && argc) {error ("specify only one of a namespace filter, --output, or --stdout\n" ); rc = -EINVAL ;
_______________________________________________
Linux-nvdimm mailing list -- [email protected] To unsubscribe send an email to [email protected]