package/python-greenlet: fix build for i386 and x86_64 archs
PATCH v2 1/1 package/python-greenlet: fix build for i386 and x86_64 archs
BR2_x86 doesn't exist in buildroot which should be BR2_i386.
BR2_x86_64 was missed in 30f1decec2ca190deea072f4d490a8de830ac9a3.
---
Changes v1 -> v2:
- also fix BR2_i386
--- package/python-greenlet/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/python-greenlet/Config.in +1 -1
@@ -8,7 +8,7 @@ config BR2_PACKAGE_PYTHON_GREENLET_ARCH_SUPPORTS default y if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le default y if BR2_riscv default y if BR2_sparc || BR2_sparc64 - default y if BR2_x86 + default y if BR2_i386 || BR2_x86_64 config BR2_PACKAGE_PYTHON_GREENLET bool "python-greenlet"
Signature · 1 line
2.25.1
PATCH v2 1/1 package/python-greenlet: fix build for i386 and x86_64 archs
On 2020-07-07 14:04 -0600, James Hilliard spake thusly:
Quoted 3 lines
BR2_x86doesn't exist in buildroot which should beBR2_i386.
BR2_x86_64was missed in30f1decec2ca190deea072f4d490a8de830ac9a3.
So, these are twi different changes:
- the first is a fix, and should be its own patch, so it can be backported to the latest stable branch, 2020.05.x
- the second is a new feature, enabling a new arch, so should be a second, separate patch.
As a consequence, the commit log is misleading: we're not "fixing" build for x86_64; instead, we're enabling it. And in all theory, wer're not "fixing" the build for i386 either, because the build is not really broken as there actually is no build going on...
I've split them, fixed commit logs, and applied to master, thanks
Regards,
Yann E. MORIN.
Quoted 28 lines
Signed-off-by James Hilliard <[email protected]>---
Changes v1 -> v2:
- also fixBR2_i386--- package/python-greenlet/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/python-greenlet/Config.in +1
-1@@ -8,7 +8,7 @@ config BR2_PACKAGE_PYTHON_GREENLET_ARCH_SUPPORTS default y if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le default y if BR2_riscv default y if BR2_sparc || BR2_sparc64 - default y if BR2_x86 + default y if BR2_i386 || BR2_x86_64 config BR2_PACKAGE_PYTHON_GREENLET bool "python-greenlet"Signature · 6 lines
2.25.1 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/1 package/python-greenlet: fix build for i386 and x86_64 archs
Quoted 10 lines · Yann E. MORIN
On 2020-07-07 14:04 -0600, James Hilliard spake thusly:
Quoted 3 lines
BR2_x86doesn't exist in buildroot which should beBR2_i386.
BR2_x86_64was missed in30f1decec2ca190deea072f4d490a8de830ac9a3.So, these are twi different changes:
- the first is a fix, and should be its own patch, so it can be backported to the latest stable branch, 2020.05.x
We should backport both.
Quoted 3 lines
- the second is a new feature, enabling a new arch, so should be a second, separate patch.
It's kinda a bugfix since it should have always been enabled, I think the intention
might have been for the BR2_x86 option to have enabled both.
Quoted 47 lines
As a consequence, the commit log is misleading: we're not "fixing" build for
x86_64; instead, we're enabling it. And in all theory, wer're not "fixing" the build for i386 either, because the build is not really broken as there actually is no build going on...I've split them, fixed commit logs, and applied to master, thanks
Regards,
Yann E. MORIN.Quoted 24 lines
Signed-off-by James Hilliard <[email protected]>---
Changes v1 -> v2:
- also fixBR2_i386--- package/python-greenlet/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/python-greenlet/Config.in +1
-2@@ -8,7 +8,7 @@ config BR2_PACKAGE_PYTHON_GREENLET_ARCH_SUPPORTS default y if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le default y if BR2_riscv default y if BR2_sparc || BR2_sparc64 - default y if BR2_x86 + default y if BR2_i386 || BR2_x86_64 config BR2_PACKAGE_PYTHON_GREENLET bool "python-greenlet" --2.25.1
Quoted 4 lines
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot--
.-----------------.--------------------.------------------.--------------------.| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |'------------------------------^-------^------------------^--------------------'