Skip to contentSkip to conversation

mfd: axp20x: Use #ifdef for checking CONFIG_ACPI

PATCH In review Krzysztof Kozlowski 2 participants 2 messages Jul 8, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: axp20x: Use #ifdef for checking CONFIG_ACPI

Use #ifdef directive to check whether config symbol is defined and to fix warning:

    drivers/mfd/axp20x-i2c.c:82:5: warning: "CONFIG_ACPI" is not defined [-Wundef]
---
 drivers/mfd/axp20x-i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/axp20x-i2c.c +1 -1
index bd271fbe1ec1..3c930316d48b 100644
@@ -79,7 +79,7 @@ static const struct i2c_device_id axp20x_i2c_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
 
-#if CONFIG_ACPI
+#ifdef CONFIG_ACPI
 static const struct acpi_device_id axp20x_i2c_acpi_match[] = {
 	{
 		.id = "INT33F4",
Signature · 1 line
2.17.1
#1 lore raw
Quoted 9 lines · Krzysztof Kozlowski

Use #ifdef directive to check whether config symbol is defined and to fix warning:

    drivers/mfd/axp20x-i2c.c:82:5: warning: "CONFIG_ACPI" is not defined [-Wundef]
---
 drivers/mfd/axp20x-i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This is already fixed (3 times now). :)

Thanks anyway.

Quoted 13 lines
drivers/mfd/axp20x-i2c.c +1 -1
index bd271fbe1ec1..3c930316d48b 100644
@@ -79,7 +79,7 @@ static const struct i2c_device_id axp20x_i2c_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
 
-#if CONFIG_ACPI
+#ifdef CONFIG_ACPI
 static const struct acpi_device_id axp20x_i2c_acpi_match[] = {
 	{
 		.id = "INT33F4",
Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog