Skip to contentSkip to conversation

drm/amd/display: add dmcub check on RENOIR

PATCH In review Aaron Ma 3 participants 3 messages Jul 8, 2020

Subsystems (3)
lore
Share & tools
lore

Aaron Ma

author
#0 lore raw

PATCH 1/1 drm/amd/display: add dmcub check on RENOIR

RENOIR loads dmub fw not dmcu, check dmcu only will prevent loading iram, it breaks backlight control.

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -1
index 10ac8076d4f2..db5e0bb0d935 100644
@@ -1358,7 +1358,7 @@ static int dm_late_init(void *handle)
 	struct dmcu *dmcu = NULL;
 	bool ret;
 
-	if (!adev->dm.fw_dmcu)
+	if (!adev->dm.fw_dmcu && !adev->dm.dmub_fw)
 		return detect_mst_link_for_all_connectors(adev->ddev);
 
 	dmcu = adev->dm.dc->res_pool->dmcu;
Signature · 1 line
2.25.1
maintainer Acked-by on v1 1/1
#1 lore raw

[AMD Public Use]

________________________________
From: Aaron Ma <[email protected]>
Sent: Wednesday, July 8, 2020 4:16 AM
To: Wentland, Harry <[email protected]>; Li, Sun peng (Leo) <[email protected]>; Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
Subject: [PATCH] drm/amd/display: add dmcub check on RENOIR

RENOIR loads dmub fw not dmcu, check dmcu only will prevent loading iram, it breaks backlight control.

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -1
index 10ac8076d4f2..db5e0bb0d935 100644
@@ -1358,7 +1358,7 @@ static int dm_late_init(void *handle)
         struct dmcu *dmcu = NULL;
         bool ret;
 
-       if (!adev->dm.fw_dmcu)
+       if (!adev->dm.fw_dmcu && !adev->dm.dmub_fw)
                 return detect_mst_link_for_all_connectors(adev->ddev);
 
         dmcu = adev->dm.dc->res_pool->dmcu;

--
2.25.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#2 lore raw

Looks good to me.

Regards,
Nicholas Kazlauskas

Quoted 43 lines · Alexander

[AMD Public Use]

[AMD Public Use]

------------------------------------------------------------------------
*From:* Aaron Ma <[email protected]>
*Sent:* Wednesday, July 8, 2020 4:16 AM
*To:* Wentland, Harry <[email protected]>; Li, Sun peng (Leo) <[email protected]>; Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]> *Subject:* [PATCH] drm/amd/display: add dmcub check on RENOIR
RENOIR loads dmub fw not dmcu, check dmcu only will prevent loading iram,
it breaks backlight control.

Bug https://bugzilla.kernel.org/show_bug.cgi?id=208277 <https://bugzilla.kernel.org/show_bug.cgi?id=208277>
---
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -1
index 10ac8076d4f2..db5e0bb0d935 100644
@@ -1358,7 +1358,7 @@ static int dm_late_init(void *handle)
          struct dmcu *dmcu = NULL;
          bool ret;
 
-       if (!adev->dm.fw_dmcu)
+       if (!adev->dm.fw_dmcu && !adev->dm.dmub_fw)
                  return detect_mst_link_for_all_connectors(adev->ddev);
 
          dmcu = adev->dm.dc->res_pool->dmcu;
Signature · 7 lines
2.25.1


_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel