drm/amd/display: add dmcub check on RENOIR
Subsystems (3)
PATCH 1/1 drm/amd/display: add dmcub check on RENOIR
RENOIR loads dmub fw not dmcu, check dmcu only will prevent loading iram, it breaks backlight control.
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -1
@@ -1358,7 +1358,7 @@ static int dm_late_init(void *handle)struct dmcu *dmcu =NULL ;bool ret; -if (!adev->dm.fw_dmcu) +if (!adev->dm.fw_dmcu && !adev->dm.dmub_fw)return detect_mst_link_for_all_connectors (adev->ddev); dmcu = adev->dm.dc->res_pool->dmcu;
Signature · 1 line
2.25.1
[AMD Public Use]
________________________________
From: Aaron Ma <[email protected]>
Sent: Wednesday, July 8, 2020 4:16 AM
To: Wentland, Harry <[email protected]>; Li, Sun peng (Leo) <[email protected]>; Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
Subject: [PATCH] drm/amd/display: add dmcub check on RENOIR
RENOIR loads dmub fw not dmcu, check dmcu only will prevent loading iram, it breaks backlight control.
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1 -1
@@ -1358,7 +1358,7 @@ static int dm_late_init(void *handle)struct dmcu *dmcu =NULL ;bool ret; -if (!adev->dm.fw_dmcu) +if (!adev->dm.fw_dmcu && !adev->dm.dmub_fw)return detect_mst_link_for_all_connectors (adev->ddev); dmcu = adev->dm.dc->res_pool->dmcu;
--
2.25.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Kazlauskas, Nicholas
Reviewed-byLooks good to me.
Regards,
Nicholas Kazlauskas
Quoted 43 lines · Alexander
[AMD Public Use]
[AMD Public Use]
Acked-by Alex Deucher <[email protected]>------------------------------------------------------------------------
*From:* Aaron Ma <[email protected]>
*Sent:* Wednesday, July 8, 2020 4:16 AM
*To:* Wentland, Harry <[email protected]>; Li, Sun peng (Leo) <[email protected]>; Deucher, Alexander <[email protected]>; Koenig, Christian <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]> *Subject:* [PATCH] drm/amd/display: add dmcub check on RENOIR
RENOIR loads dmub fw not dmcu, check dmcu only will prevent loading iram,
it breaks backlight control.Bug https://bugzilla.kernel.org/show_bug.cgi?id=208277 <https://bugzilla.kernel.org/show_bug.cgi?id=208277>Signed-off-by Aaron Ma <[email protected]>--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +1
-1@@ -1358,7 +1358,7 @@ static int dm_late_init(void *handle) struct dmcu *dmcu = NULL; bool ret; - if (!adev->dm.fw_dmcu) + if (!adev->dm.fw_dmcu && !adev->dm.dmub_fw) return detect_mst_link_for_all_connectors(adev->ddev); dmcu = adev->dm.dc->res_pool->dmcu;Signature · 7 lines
2.25.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel