drm/i915/hdcp: Update CP as per the kernel internal state
Subsystems (3)
PATCH v3 1/1 drm/i915/hdcp: Update CP as per the kernel internal state
Content Protection property should be updated as per the kernel internal state. Let's say if Content protection is disabled by userspace, CP property should be set to UNDESIRED so that reauthentication will not happen until userspace request it again, but when kernel disables the HDCP due to any DDI disabling sequences like modeset/DPMS operation, kernel should set the property to DESIRED, so that when opportunity arises, kernel will start the HDCP authentication on its own.
Somewhere in the line, state machine to set content protection to DESIRED from kernel was broken and IGT coverage was missing for it. This patch fixes it.
v2:
- Fixing hdcp CP state in connector atomic check function intel_hdcp_atomic_check(). [Maarten]
This will require to check hdcp->value in intel_hdcp_update_pipe() in order to avoid enabling hdcp, if it was already enabled.
v3:
- Rebased.
--- drivers/gpu/drm/i915/display/intel_hdcp.c | 27 +++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/display/intel_hdcp.c +23 -4
@@ -2086,6 +2086,7 @@ void intel_hdcp_update_pipe(struct intel_atomic_state *state, (conn_state->hdcp_content_type != hdcp->content_type && conn_state->content_protection !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED ); +bool desired_and_not_enabled = false;/* * During the HDCP encryption session if Type change is requested,
@@ -2108,8 +2109,15 @@ void intel_hdcp_update_pipe(struct intel_atomic_state *state, }if (conn_state->content_protection == -DRM_MODE_CONTENT_PROTECTION_DESIRED || - content_protection_type_changed) +DRM_MODE_CONTENT_PROTECTION_DESIRED ) { +mutex_lock (&hdcp->mutex); +/* Avoid enabling hdcp, if it already ENABLED */ + desired_and_not_enabled = + hdcp->value !=DRM_MODE_CONTENT_PROTECTION_ENABLED ; +mutex_unlock (&hdcp->mutex); + } + +if (desired_and_not_enabled || content_protection_type_changed)intel_hdcp_enable (connector, crtc_state->cpu_transcoder, (u8 )conn_state->hdcp_content_type);
@@ -2158,6 +2166,19 @@ void intel_hdcp_atomic_check(struct drm_connector *connector,return ; } + crtc_state =drm_atomic_get_new_crtc_state (new_state->state, + new_state->crtc); +/* +* Fix the HDCP uapi content protection state in case of modeset. +* FIXME: As per HDCP content protection property uapi doc, an uevent() +* need to be sent if there is transition from ENABLED->DESIRED. +*/ +if (drm_atomic_crtc_needs_modeset (crtc_state) && + (old_cp ==DRM_MODE_CONTENT_PROTECTION_ENABLED && + new_cp !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED )) + new_state->content_protection = +DRM_MODE_CONTENT_PROTECTION_DESIRED ; +/* * Nothing to do if the state didn't change, or HDCP was activated since * the last commit. And also no change in hdcp content type.
@@ -2170,8 +2191,6 @@ void intel_hdcp_atomic_check(struct drm_connector *connector,return ; } - crtc_state =drm_atomic_get_new_crtc_state (new_state->state, - new_state->crtc); crtc_state->mode_changed = true; }
Signature · 6 lines
2.26.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Uma, is the R-b still valid? It's been a while.
BR,
Jani.
Quoted 90 lines · Anshuman Gupta
Content Protection property should be updated as per the kernel internal state. Let's say if Content protection is disabled by userspace, CP property should be set to UNDESIRED so that reauthentication will not happen until userspace request it again, but when kernel disables the HDCP due to any DDI disabling sequences like modeset/DPMS operation, kernel should set the property to DESIRED, so that when opportunity arises, kernel will start the HDCP authentication on its own.
Somewhere in the line, state machine to set content protection to DESIRED from kernel was broken and IGT coverage was missing for it. This patch fixes it.
v2:
- Fixing hdcp CP state in connector atomic check functionintel_hdcp_atomic_check(). [Maarten]
This will require to checkhdcp->valueinintel_hdcp_update_pipe()in order to avoid enabling hdcp, if it was already enabled.v3:
- Rebased.Cc Ramalingam C <[email protected]>Cc Maarten Lankhorst <[email protected]>Reviewed-by Uma Shankar <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>--- drivers/gpu/drm/i915/display/intel_hdcp.c | 27 +++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/intel_hdcp.c +23
-4@@ -2086,6 +2086,7 @@ void intel_hdcp_update_pipe(struct intel_atomic_state *state, (conn_state->hdcp_content_type != hdcp->content_type && conn_state->content_protection !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED ); +bool desired_and_not_enabled = false;/* * During the HDCP encryption session if Type change is requested, @@ -2108,8 +2109,15 @@ void intel_hdcp_update_pipe(struct intel_atomic_state *state, }if (conn_state->content_protection == -DRM_MODE_CONTENT_PROTECTION_DESIRED || - content_protection_type_changed) +DRM_MODE_CONTENT_PROTECTION_DESIRED ) { +mutex_lock (&hdcp->mutex); +/* Avoid enabling hdcp, if it already ENABLED */ + desired_and_not_enabled = + hdcp->value !=DRM_MODE_CONTENT_PROTECTION_ENABLED ; +mutex_unlock (&hdcp->mutex); + } + +if (desired_and_not_enabled || content_protection_type_changed)intel_hdcp_enable (connector, crtc_state->cpu_transcoder, (u8 )conn_state->hdcp_content_type);@@ -2158,6 +2166,19 @@ void intel_hdcp_atomic_check(struct drm_connector *connector,return ; } + crtc_state =drm_atomic_get_new_crtc_state (new_state->state, + new_state->crtc); +/* +* Fix the HDCP uapi content protection state in case of modeset. +* FIXME: As per HDCP content protection property uapi doc, an uevent() +* need to be sent if there is transition from ENABLED->DESIRED. +*/ +if (drm_atomic_crtc_needs_modeset (crtc_state) && + (old_cp ==DRM_MODE_CONTENT_PROTECTION_ENABLED && + new_cp !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED )) + new_state->content_protection = +DRM_MODE_CONTENT_PROTECTION_DESIRED ; +/* * Nothing to do if the state didn't change, or HDCP was activated since * the last commit. And also no change in hdcp content type. @@ -2170,8 +2191,6 @@ void intel_hdcp_atomic_check(struct drm_connector *connector,return ; } - crtc_state =drm_atomic_get_new_crtc_state (new_state->state, - new_state->crtc); crtc_state->mode_changed = true; }
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 12 lines
-----Original Message-----
From: Jani Nikula <[email protected]>
Sent: Tuesday, June 30, 2020 3:30 PM
To: Gupta, Anshuman <[email protected]>; intel- [email protected]
Cc: Shankar, Uma <[email protected]>
Subject: Re: [Intel-gfx] [PATCH v3] drm/i915/hdcp: Update CP as per the kernel internal state
Quoted 1 line
Uma, is the R-b still valid? It's been a while.
Yeah Jani, the changes look good. Will need a rebase and fresh CI results though.
Regards,
Uma Shankar
Quoted 100 lines
BR,
Jani.drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_update_pipe(struct
Quoted 41 lines · Anshuman Gupta
Content Protection property should be updated as per the kernel internal state. Let's say if Content protection is disabled by userspace, CP property should be set to UNDESIRED so that reauthentication will not happen until userspace request it again, but when kernel disables the HDCP due to any DDI disabling sequences like modeset/DPMS operation, kernel should set the property to DESIRED, so that when opportunity arises, kernel will start the HDCP authentication on its own.
Somewhere in the line, state machine to set content protection to DESIRED from kernel was broken and IGT coverage was missing for it. This patch fixes it.
v2:
- Fixing hdcp CP state in connector atomic check functionintel_hdcp_atomic_check(). [Maarten]
This will require to checkhdcp->valueinintel_hdcp_update_pipe()in order to avoid enabling hdcp, if it was already enabled.v3:
- Rebased.Cc Ramalingam C <[email protected]>Cc Maarten Lankhorst <[email protected]>Reviewed-by Uma Shankar <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>Link:
https://patchwork.freedesktop.org/patch/350962/?series=72664&rev=2 #v1 Link:
https://patchwork.freedesktop.org/patch/359396/?series=72251&rev=3 #v2--- drivers/gpu/drm/i915/display/intel_hdcp.c | 27 +++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/intel_hdcp.c +0
-0@@ -2086,6 +2086,7 @@ void intel_hdcp_update_pipe(struct
intel_atomic_state*state,drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_update_pipe(struct
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +1
-0(conn_state->hdcp_content_type != hdcp->content_type && conn_state->content_protection !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED ); +bool desired_and_not_enabled = false;/* * During the HDCP encryption session if Type change is requested, @@ -2108,8 +2109,15 @@ void intel_hdcp_update_pipe(struct
intel_atomic_state*state,drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_update_pipe(struct intel_atomic_state *state,
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +5
-2}if (conn_state->content_protection == -DRM_MODE_CONTENT_PROTECTION_DESIRED || - content_protection_type_changed) +DRM_MODE_CONTENT_PROTECTION_DESIRED ) { +mutex_lock (&hdcp->mutex); +/* Avoid enabling hdcp, if it already ENABLED */ + desired_and_not_enabled = + hdcp->value !=
DRM_MODE_CONTENT_PROTECTION_ENABLED;drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_atomic_check(struct
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +4
-0+mutex_unlock (&hdcp->mutex); + } + +if (desired_and_not_enabled || content_protection_type_changed)intel_hdcp_enable (connector, crtc_state->cpu_transcoder, (u8 )conn_state->hdcp_content_type);@@ -2158,6 +2166,19 @@ void intel_hdcp_atomic_check(struct
drm_connector*connector,drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_atomic_check(struct drm_connector
Quoted 20 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +13
-0return ; } + crtc_state =drm_atomic_get_new_crtc_state (new_state->state, + new_state->crtc); +/* +* Fix the HDCP uapi content protection state in case of modeset. +* FIXME: As per HDCP content protection property uapi doc, an uevent() +* need to be sent if there is transition from ENABLED->DESIRED. +*/ +if (drm_atomic_crtc_needs_modeset (crtc_state) && + (old_cp ==DRM_MODE_CONTENT_PROTECTION_ENABLED && + new_cp !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED )) + new_state->content_protection = +DRM_MODE_CONTENT_PROTECTION_DESIRED ; +/* * Nothing to do if the state didn't change, or HDCP was activated since * the last commit. And also no change in hdcp content type. @@ -2170,8 +2191,6 @@ void intel_hdcp_atomic_check(struct drm_connector*connector,
Quoted 3 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +0
-0return ; }
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_atomic_check(struct drm_connector *connector, · line 2195
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +0
-2- crtc_state =drm_atomic_get_new_crtc_state (new_state->state, - new_state->crtc); crtc_state->mode_changed = true; }--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 10 lines
Quoted 10 lines
-----Original Message-----
From: Jani Nikula <[email protected]>
Sent: Tuesday, June 30, 2020 3:30 PM
To: Gupta, Anshuman <[email protected]>; intel- [email protected]
Cc: Shankar, Uma <[email protected]>
Subject: Re: [Intel-gfx] [PATCH v3] drm/i915/hdcp: Update CP as per the kernel internal state
Quoted 3 lines
Quoted 1 line
Uma, is the R-b still valid? It's been a while.
Yeah Jani, the changes look good. Will need a rebase and fresh CI results though.
Seems the CI results are already out and we are clean.
Quoted 113 lines
Regards,
Uma ShankarQuoted 103 lines
BR,
Jani.drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_update_pipe(struct
Quoted 43 lines · Anshuman Gupta
Content Protection property should be updated as per the kernel internal state. Let's say if Content protection is disabled by userspace, CP property should be set to UNDESIRED so that reauthentication will not happen until userspace request it again, but when kernel disables the HDCP due to any DDI disabling sequences like modeset/DPMS operation, kernel should set the property to DESIRED, so that when opportunity arises, kernel will start the HDCP authentication on its own.
Somewhere in the line, state machine to set content protection to DESIRED from kernel was broken and IGT coverage was missing for it. This patch fixes it.
v2:
- Fixing hdcp CP state in connector atomic check functionintel_hdcp_atomic_check(). [Maarten]
This will require to checkhdcp->valueinintel_hdcp_update_pipe()in order to avoid enabling hdcp, if it was already enabled.v3:
- Rebased.Cc Ramalingam C <[email protected]>Cc Maarten Lankhorst <[email protected]>Reviewed-by Uma Shankar <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>Link:
https://patchwork.freedesktop.org/patch/350962/?series=72664&rev=2
#v1
Link:
https://patchwork.freedesktop.org/patch/359396/?series=72251&rev=3
#v2--- drivers/gpu/drm/i915/display/intel_hdcp.c | 27 +++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/intel_hdcp.c +0
-0@@ -2086,6 +2086,7 @@ void intel_hdcp_update_pipe(struct
intel_atomic_state*state,drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_update_pipe(struct
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +1
-0(conn_state->hdcp_content_type != hdcp->content_type && conn_state->content_protection !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED ); +bool desired_and_not_enabled = false;/* * During the HDCP encryption session if Type change is requested, @@ -2108,8 +2109,15 @@ void intel_hdcp_update_pipe(struct
intel_atomic_state*state,drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_update_pipe(struct intel_atomic_state *state,
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +5
-2}if (conn_state->content_protection == -DRM_MODE_CONTENT_PROTECTION_DESIRED || - content_protection_type_changed) +DRM_MODE_CONTENT_PROTECTION_DESIRED ) { +mutex_lock (&hdcp->mutex); +/* Avoid enabling hdcp, if it already ENABLED */ + desired_and_not_enabled = + hdcp->value !=
DRM_MODE_CONTENT_PROTECTION_ENABLED;drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_atomic_check(struct
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +4
-0+mutex_unlock (&hdcp->mutex); + } + +if (desired_and_not_enabled || content_protection_type_changed)intel_hdcp_enable (connector, crtc_state->cpu_transcoder, (u8 )conn_state->hdcp_content_type);@@ -2158,6 +2166,19 @@ void intel_hdcp_atomic_check(struct
drm_connector*connector,Quoted 20 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +13
-0return ; } + crtc_state =drm_atomic_get_new_crtc_state (new_state->state, + new_state->crtc); +/* +* Fix the HDCP uapi content protection state in case of modeset. +* FIXME: As per HDCP content protection property uapi doc, an uevent() +* need to be sent if there is transition from ENABLED->DESIRED. +*/ +if (drm_atomic_crtc_needs_modeset (crtc_state) && + (old_cp ==DRM_MODE_CONTENT_PROTECTION_ENABLED && + new_cp !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED )) + new_state->content_protection = +DRM_MODE_CONTENT_PROTECTION_DESIRED ; +/* * Nothing to do if the state didn't change, or HDCP was activated since * the last commit. And also no change in hdcp content type. @@ -2170,8 +2191,6 @@ void intel_hdcp_atomic_check(structQuoted 1 line
drm_connector*connector,
Quoted 3 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +0
-0return ; }Quoted 7 lines
drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_atomic_check(struct drm_connector *connector, · line 2195
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +0
-2- crtc_state =drm_atomic_get_new_crtc_state (new_state->state, - new_state->crtc); crtc_state->mode_changed = true; }--
Jani Nikula, Intel Open Source Graphics Center
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 10 lines · Uma
Quoted 10 lines
Quoted 10 lines
-----Original Message-----
From: Jani Nikula <[email protected]>
Sent: Tuesday, June 30, 2020 3:30 PM
To: Gupta, Anshuman <[email protected]>; intel- [email protected]
Cc: Shankar, Uma <[email protected]>
Subject: Re: [Intel-gfx] [PATCH v3] drm/i915/hdcp: Update CP as per the kernel internal state
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Uma, is the R-b still valid? It's been a while.
Yeah Jani, the changes look good. Will need a rebase and fresh CI results though.
Seems the CI results are already out and we are clean.
Hi Ram ,
CI results are clean for this rebase patch,
Could you please help with merging,
I belive your RB's are valid either-way wrt to your comment. Thanks,
Anshuman Gupta.
Quoted 114 lines
Quoted 114 lines
Regards,
Uma ShankarQuoted 110 lines
BR,
Jani.drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_update_pipe(struct
Quoted 43 lines · Anshuman Gupta
Content Protection property should be updated as per the kernel internal state. Let's say if Content protection is disabled by userspace, CP property should be set to UNDESIRED so that reauthentication will not happen until userspace request it again, but when kernel disables the HDCP due to any DDI disabling sequences like modeset/DPMS operation, kernel should set the property to DESIRED, so that when opportunity arises, kernel will start the HDCP authentication on its own.
Somewhere in the line, state machine to set content protection to DESIRED from kernel was broken and IGT coverage was missing for it. This patch fixes it.
v2:
- Fixing hdcp CP state in connector atomic check functionintel_hdcp_atomic_check(). [Maarten]
This will require to checkhdcp->valueinintel_hdcp_update_pipe()in order to avoid enabling hdcp, if it was already enabled.v3:
- Rebased.Cc Ramalingam C <[email protected]>Cc Maarten Lankhorst <[email protected]>Reviewed-by Uma Shankar <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>Link:
https://patchwork.freedesktop.org/patch/350962/?series=72664&rev=2
#v1
Link:
https://patchwork.freedesktop.org/patch/359396/?series=72251&rev=3
#v2--- drivers/gpu/drm/i915/display/intel_hdcp.c | 27 +++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/intel_hdcp.c +0
-0@@ -2086,6 +2086,7 @@ void intel_hdcp_update_pipe(struct
intel_atomic_state*state,drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_update_pipe(struct
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +1
-0(conn_state->hdcp_content_type != hdcp->content_type && conn_state->content_protection !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED ); +bool desired_and_not_enabled = false;/* * During the HDCP encryption session if Type change is requested, @@ -2108,8 +2109,15 @@ void intel_hdcp_update_pipe(struct
intel_atomic_state*state,drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_update_pipe(struct intel_atomic_state *state,
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +5
-2}if (conn_state->content_protection == -DRM_MODE_CONTENT_PROTECTION_DESIRED || - content_protection_type_changed) +DRM_MODE_CONTENT_PROTECTION_DESIRED ) { +mutex_lock (&hdcp->mutex); +/* Avoid enabling hdcp, if it already ENABLED */ + desired_and_not_enabled = + hdcp->value !=
DRM_MODE_CONTENT_PROTECTION_ENABLED;drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_atomic_check(struct
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +4
-0+mutex_unlock (&hdcp->mutex); + } + +if (desired_and_not_enabled || content_protection_type_changed)intel_hdcp_enable (connector, crtc_state->cpu_transcoder, (u8 )conn_state->hdcp_content_type);@@ -2158,6 +2166,19 @@ void intel_hdcp_atomic_check(struct
drm_connector*connector,Quoted 20 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +13
-0return ; } + crtc_state =drm_atomic_get_new_crtc_state (new_state->state, + new_state->crtc); +/* +* Fix the HDCP uapi content protection state in case of modeset. +* FIXME: As per HDCP content protection property uapi doc, an uevent() +* need to be sent if there is transition from ENABLED->DESIRED. +*/ +if (drm_atomic_crtc_needs_modeset (crtc_state) && + (old_cp ==DRM_MODE_CONTENT_PROTECTION_ENABLED && + new_cp !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED )) + new_state->content_protection = +DRM_MODE_CONTENT_PROTECTION_DESIRED ; +/* * Nothing to do if the state didn't change, or HDCP was activated since * the last commit. And also no change in hdcp content type. @@ -2170,8 +2191,6 @@ void intel_hdcp_atomic_check(structQuoted 1 line
drm_connector*connector,
drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_atomic_check(struct drm_connector *connector, · line 2195
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +0
-2return ; } - crtc_state =drm_atomic_get_new_crtc_state (new_state->state, - new_state->crtc); crtc_state->mode_changed = true; }--
Jani Nikula, Intel Open Source Graphics Center
Quoted 4 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Anshuman Gupta
Quoted 10 lines · Uma
Quoted 10 lines
Quoted 10 lines
-----Original Message-----
From: Jani Nikula <[email protected]>
Sent: Tuesday, June 30, 2020 3:30 PM
To: Gupta, Anshuman <[email protected]>; intel- [email protected]
Cc: Shankar, Uma <[email protected]>
Subject: Re: [Intel-gfx] [PATCH v3] drm/i915/hdcp: Update CP as per the kernel internal state
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Uma, is the R-b still valid? It's been a while.
Yeah Jani, the changes look good. Will need a rebase and fresh CI results though.
Seems the CI results are already out and we are clean.
Hi Ram ,
CI results are clean for this rebase patch,
Could you please help with merging,
Pushed into dinq. Thanks for the change.
-Ram
Quoted 122 lines
I belive your RB's are valid either-way wrt to your comment. Thanks,
Anshuman Gupta.Quoted 118 lines
Quoted 118 lines
Regards,
Uma ShankarQuoted 103 lines
BR,
Jani.drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_update_pipe(struct
Quoted 43 lines · Anshuman Gupta
Content Protection property should be updated as per the kernel internal state. Let's say if Content protection is disabled by userspace, CP property should be set to UNDESIRED so that reauthentication will not happen until userspace request it again, but when kernel disables the HDCP due to any DDI disabling sequences like modeset/DPMS operation, kernel should set the property to DESIRED, so that when opportunity arises, kernel will start the HDCP authentication on its own.
Somewhere in the line, state machine to set content protection to DESIRED from kernel was broken and IGT coverage was missing for it. This patch fixes it.
v2:
- Fixing hdcp CP state in connector atomic check functionintel_hdcp_atomic_check(). [Maarten]
This will require to checkhdcp->valueinintel_hdcp_update_pipe()in order to avoid enabling hdcp, if it was already enabled.v3:
- Rebased.Cc Ramalingam C <[email protected]>Cc Maarten Lankhorst <[email protected]>Reviewed-by Uma Shankar <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>Link:
https://patchwork.freedesktop.org/patch/350962/?series=72664&rev=2
#v1
Link:
https://patchwork.freedesktop.org/patch/359396/?series=72251&rev=3
#v2--- drivers/gpu/drm/i915/display/intel_hdcp.c | 27 +++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/intel_hdcp.c +0
-0@@ -2086,6 +2086,7 @@ void intel_hdcp_update_pipe(struct
intel_atomic_state*state,drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_update_pipe(struct
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +1
-0(conn_state->hdcp_content_type != hdcp->content_type && conn_state->content_protection !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED ); +bool desired_and_not_enabled = false;/* * During the HDCP encryption session if Type change is requested, @@ -2108,8 +2109,15 @@ void intel_hdcp_update_pipe(struct
intel_atomic_state*state,drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_update_pipe(struct intel_atomic_state *state,
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +5
-2}if (conn_state->content_protection == -DRM_MODE_CONTENT_PROTECTION_DESIRED || - content_protection_type_changed) +DRM_MODE_CONTENT_PROTECTION_DESIRED ) { +mutex_lock (&hdcp->mutex); +/* Avoid enabling hdcp, if it already ENABLED */ + desired_and_not_enabled = + hdcp->value !=
DRM_MODE_CONTENT_PROTECTION_ENABLED;drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_atomic_check(struct
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +4
-0+mutex_unlock (&hdcp->mutex); + } + +if (desired_and_not_enabled || content_protection_type_changed)intel_hdcp_enable (connector, crtc_state->cpu_transcoder, (u8 )conn_state->hdcp_content_type);@@ -2158,6 +2166,19 @@ void intel_hdcp_atomic_check(struct
drm_connector*connector,Quoted 20 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +13
-0return ; } + crtc_state =drm_atomic_get_new_crtc_state (new_state->state, + new_state->crtc); +/* +* Fix the HDCP uapi content protection state in case of modeset. +* FIXME: As per HDCP content protection property uapi doc, an uevent() +* need to be sent if there is transition from ENABLED->DESIRED. +*/ +if (drm_atomic_crtc_needs_modeset (crtc_state) && + (old_cp ==DRM_MODE_CONTENT_PROTECTION_ENABLED && + new_cp !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED )) + new_state->content_protection = +DRM_MODE_CONTENT_PROTECTION_DESIRED ; +/* * Nothing to do if the state didn't change, or HDCP was activated since * the last commit. And also no change in hdcp content type. @@ -2170,8 +2191,6 @@ void intel_hdcp_atomic_check(structQuoted 1 line
drm_connector*connector,
Quoted 3 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +0
-0return ; }Quoted 7 lines
drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_atomic_check(struct drm_connector *connector, · line 2195
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +0
-2- crtc_state =drm_atomic_get_new_crtc_state (new_state->state, - new_state->crtc); crtc_state->mode_changed = true; }--
Jani Nikula, Intel Open Source Graphics Center_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Sean, Ram, good to go?
BR,
Jani.
Quoted 90 lines · Anshuman Gupta
Content Protection property should be updated as per the kernel internal state. Let's say if Content protection is disabled by userspace, CP property should be set to UNDESIRED so that reauthentication will not happen until userspace request it again, but when kernel disables the HDCP due to any DDI disabling sequences like modeset/DPMS operation, kernel should set the property to DESIRED, so that when opportunity arises, kernel will start the HDCP authentication on its own.
Somewhere in the line, state machine to set content protection to DESIRED from kernel was broken and IGT coverage was missing for it. This patch fixes it.
v2:
- Fixing hdcp CP state in connector atomic check functionintel_hdcp_atomic_check(). [Maarten]
This will require to checkhdcp->valueinintel_hdcp_update_pipe()in order to avoid enabling hdcp, if it was already enabled.v3:
- Rebased.Cc Ramalingam C <[email protected]>Cc Maarten Lankhorst <[email protected]>Reviewed-by Uma Shankar <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>--- drivers/gpu/drm/i915/display/intel_hdcp.c | 27 +++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/intel_hdcp.c +23
-4@@ -2086,6 +2086,7 @@ void intel_hdcp_update_pipe(struct intel_atomic_state *state, (conn_state->hdcp_content_type != hdcp->content_type && conn_state->content_protection !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED ); +bool desired_and_not_enabled = false;/* * During the HDCP encryption session if Type change is requested, @@ -2108,8 +2109,15 @@ void intel_hdcp_update_pipe(struct intel_atomic_state *state, }if (conn_state->content_protection == -DRM_MODE_CONTENT_PROTECTION_DESIRED || - content_protection_type_changed) +DRM_MODE_CONTENT_PROTECTION_DESIRED ) { +mutex_lock (&hdcp->mutex); +/* Avoid enabling hdcp, if it already ENABLED */ + desired_and_not_enabled = + hdcp->value !=DRM_MODE_CONTENT_PROTECTION_ENABLED ; +mutex_unlock (&hdcp->mutex); + } + +if (desired_and_not_enabled || content_protection_type_changed)intel_hdcp_enable (connector, crtc_state->cpu_transcoder, (u8 )conn_state->hdcp_content_type);@@ -2158,6 +2166,19 @@ void intel_hdcp_atomic_check(struct drm_connector *connector,return ; } + crtc_state =drm_atomic_get_new_crtc_state (new_state->state, + new_state->crtc); +/* +* Fix the HDCP uapi content protection state in case of modeset. +* FIXME: As per HDCP content protection property uapi doc, an uevent() +* need to be sent if there is transition from ENABLED->DESIRED. +*/ +if (drm_atomic_crtc_needs_modeset (crtc_state) && + (old_cp ==DRM_MODE_CONTENT_PROTECTION_ENABLED && + new_cp !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED )) + new_state->content_protection = +DRM_MODE_CONTENT_PROTECTION_DESIRED ; +/* * Nothing to do if the state didn't change, or HDCP was activated since * the last commit. And also no change in hdcp content type. @@ -2170,8 +2191,6 @@ void intel_hdcp_atomic_check(struct drm_connector *connector,return ; } - crtc_state =drm_atomic_get_new_crtc_state (new_state->state, - new_state->crtc); crtc_state->mode_changed = true; }
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 45 lines · Anshuman Gupta
Content Protection property should be updated as per the kernel internal state. Let's say if Content protection is disabled by userspace, CP property should be set to UNDESIRED so that reauthentication will not happen until userspace request it again, but when kernel disables the HDCP due to any DDI disabling sequences like modeset/DPMS operation, kernel should set the property to DESIRED, so that when opportunity arises, kernel will start the HDCP authentication on its own.
Somewhere in the line, state machine to set content protection to DESIRED from kernel was broken and IGT coverage was missing for it. This patch fixes it.
v2:
- Fixing hdcp CP state in connector atomic check functionintel_hdcp_atomic_check(). [Maarten]
This will require to checkhdcp->valueinintel_hdcp_update_pipe()in order to avoid enabling hdcp, if it was already enabled.v3:
- Rebased.Cc Ramalingam C <[email protected]>Cc Maarten Lankhorst <[email protected]>Reviewed-by Uma Shankar <[email protected]>Signed-off-by Anshuman Gupta <[email protected]>--- drivers/gpu/drm/i915/display/intel_hdcp.c | 27 +++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/display/intel_hdcp.c +1
-0@@ -2086,6 +2086,7 @@ void intel_hdcp_update_pipe(struct intel_atomic_state *state, (conn_state->hdcp_content_type != hdcp->content_type && conn_state->content_protection !=DRM_MODE_CONTENT_PROTECTION_UNDESIRED ); +bool desired_and_not_enabled = false;/* * During the HDCP encryption session if Type change is requested,
drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_update_pipe(struct intel_atomic_state *state, · line 2116
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +5
-2@@ -2108,8 +2109,15 @@ void intel_hdcp_update_pipe(struct intel_atomic_state *state, }if (conn_state->content_protection == -DRM_MODE_CONTENT_PROTECTION_DESIRED || - content_protection_type_changed) +DRM_MODE_CONTENT_PROTECTION_DESIRED ) { +mutex_lock (&hdcp->mutex); +/* Avoid enabling hdcp, if it already ENABLED */ + desired_and_not_enabled = + hdcp->value !=DRM_MODE_CONTENT_PROTECTION_ENABLED ;
It will be good to move before the hdcp->value modification as below, if (content_protection_type_changed)
hdcp->value = DRM_MODE_CONTENT_PROTECTION_DESIRED;
But this will impact only when content_protection_type_changed is true. But when content_protection_type_changed is true we dont care the state of desired_and_not_enabled as we use them in logical OR.
Either way. looks good to me.
Quoted 9 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +4
-0+mutex_unlock (&hdcp->mutex); + } + +if (desired_and_not_enabled || content_protection_type_changed)intel_hdcp_enable (connector, crtc_state->cpu_transcoder, (u8 )conn_state->hdcp_content_type);@@ -2158,6 +2166,19 @@ void intel_hdcp_atomic_check(struct drm_connector *connector,return ;
drivers/gpu/drm/i915/display/intel_hdcp.c void intel_hdcp_atomic_check(struct drm_connector *connector, · line 2176
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +8
-0} + crtc_state =drm_atomic_get_new_crtc_state (new_state->state, + new_state->crtc); +/* +* Fix the HDCP uapi content protection state in case of modeset. +* FIXME: As per HDCP content protection property uapi doc, an uevent() +* need to be sent if there is transition from ENABLED->DESIRED. +*/ + if (drm_atomic_crtc_needs_modeset(crtc_state) &&
Based on the IGT test result I infer needs_modeset status wont change from No->yes after this point.
-ram
Quoted 20 lines
drivers/gpu/drm/i915/display/intel_hdcp.c +5
-2+ (old_cp ==DRM_MODE_CONTENT_PROTECTION_ENABLED && + new_cp != DRM_MODE_CONTENT_PROTECTION_UNDESIRED)) + new_state->content_protection = +DRM_MODE_CONTENT_PROTECTION_DESIRED ; +/* * Nothing to do if the state didn't change, or HDCP was activated since * the last commit. And also no change in hdcp content type. @@ -2170,8 +2191,6 @@ void intel_hdcp_atomic_check(struct drm_connector *connector,return ; } - crtc_state =drm_atomic_get_new_crtc_state (new_state->state, - new_state->crtc); crtc_state->mode_changed = true; }Signature · 1 line
2.26.2
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: Update CP as per the kernel internal state (rev5)
In reply to Anshuman Gupta== Series Details ==
== Series Details ==
Series: drm/i915/hdcp: Update CP as per the kernel internal state (rev5)
URL : https://patchwork.freedesktop.org/series/72251/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8678 -> Patchwork_18042
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/index.html
Known issues
------------
Here are the changes found in Patchwork_18042 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [PASS][1] -> [FAIL][2] ([i915#1888])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/fi-tgl-u2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/fi-tgl-u2/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-byt-j1900: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/fi-byt-j1900/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/fi-byt-j1900/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-tgl-u2: [PASS][5] -> [DMESG-WARN][6] ([i915#402])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/fi-tgl-u2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/fi-tgl-u2/igt@[email protected]
#### Possible fixes ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/fi-bsw-kefka/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/fi-bsw-kefka/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-glk-dsi: [DMESG-WARN][9] ([i915#1982]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/fi-glk-dsi/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/fi-glk-dsi/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-n3050: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/fi-bsw-n3050/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/fi-bsw-n3050/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:
- fi-icl-u2: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/fi-icl-u2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/fi-icl-u2/igt@[email protected]
#### Warnings ####
* igt@kms_force_connector_basic@prune-stale-modes:
- fi-kbl-x1275: [DMESG-WARN][15] ([i915#62] / [i915#92]) -> [DMESG-WARN][16] ([i915#62] / [i915#92] / [i915#95]) +5 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/fi-kbl-x1275/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/fi-kbl-x1275/igt@[email protected]
* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- fi-kbl-x1275: [DMESG-WARN][17] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][18] ([i915#62] / [i915#92])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/fi-kbl-x1275/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/fi-kbl-x1275/igt@[email protected]
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (44 -> 37)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8678 -> Patchwork_18042
CI-20190529: 20190529
CI_DRM_8678: 7cafa8aeca728d8abd1bc9d31d2fca60757a00c4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5718: af1ef32bfae90bcdbaf1b5d84c61ff4e04368505 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18042: b97d79fa049ee3f3da673cd51616695c69da60c2 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b97d79fa049e drm/i915/hdcp: Update CP as per the kernel internal state
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hdcp: Update CP as per the kernel internal state (rev5)
In reply to Anshuman Gupta== Series Details ==
== Series Details ==
Series: drm/i915/hdcp: Update CP as per the kernel internal state (rev5)
URL : https://patchwork.freedesktop.org/series/72251/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8678_full -> Patchwork_18042_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_18042_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@nop:
- shard-apl: [PASS][1] -> [DMESG-WARN][2] ([i915#1635] / [i915#95]) +15 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-apl2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-apl4/igt@[email protected]
* igt@kms_addfb_basic@invalid-set-prop:
- shard-tglb: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-tglb7/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-tglb3/igt@[email protected]
* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-skl: [PASS][5] -> [DMESG-WARN][6] ([i915#1982]) +11 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-skl4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-skl10/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-64x64-random:
- shard-kbl: [PASS][7] -> [DMESG-WARN][8] ([i915#93] / [i915#95]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-kbl1/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-kbl1/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([i915#180]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-kbl6/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-kbl6/igt@[email protected]
* igt@kms_flip@2x-flip-vs-rmfb-interruptible@ab-vga1-hdmi-a1:
- shard-hsw: [PASS][11] -> [DMESG-WARN][12] ([i915#1982])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-hsw4/igt@kms_flip@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-hsw6/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-absolute-wf_vblank@b-edp1:
- shard-skl: [PASS][13] -> [FAIL][14] ([i915#1928])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-skl9/igt@kms_flip@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-skl2/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt:
- shard-tglb: [PASS][15] -> [DMESG-WARN][16] ([i915#1982])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-tglb8/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-tglb2/igt@[email protected]
* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#1188])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-skl3/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-skl4/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][19] -> [FAIL][20] ([fdo#108145] / [i915#265])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-skl9/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-skl2/igt@[email protected]
* igt@kms_plane_scaling@pipe-c-scaler-with-clipping-clamping:
- shard-iclb: [PASS][21] -> [DMESG-WARN][22] ([i915#1982])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-iclb4/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-iclb3/igt@[email protected]
* igt@kms_prime@basic-crc@second-to-first:
- shard-kbl: [PASS][23] -> [DMESG-FAIL][24] ([i915#95])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-kbl2/igt@kms_prime@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-kbl1/igt@kms_prime@[email protected]
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-tglb: [PASS][25] -> [SKIP][26] ([i915#668]) +5 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-tglb3/igt@kms_psr@psr2_primary_mmap_gtt.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-tglb5/igt@kms_psr@psr2_primary_mmap_gtt.html
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-iclb7/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_vblank@pipe-b-query-idle-hang:
- shard-apl: [PASS][29] -> [DMESG-WARN][30] ([i915#1982]) +2 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-apl4/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-apl2/igt@[email protected]
* igt@perf@blocking-parameterized:
- shard-iclb: [PASS][31] -> [FAIL][32] ([i915#1542])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-iclb4/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-iclb8/igt@[email protected]
- shard-tglb: [PASS][33] -> [FAIL][34] ([i915#1542])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-tglb5/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-tglb7/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_balancer@bonded-slice:
- shard-iclb: [INCOMPLETE][35] -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-iclb1/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-iclb5/igt@[email protected]
* igt@gem_exec_whisper@basic-contexts-priority-all:
- shard-glk: [DMESG-WARN][37] ([i915#118] / [i915#95]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-glk3/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-glk4/igt@[email protected]
* igt@gem_mmap_offset@bad-flags:
- shard-kbl: [DMESG-WARN][39] ([i915#93] / [i915#95]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-kbl2/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-kbl7/igt@[email protected]
* igt@i915_pm_rpm@modeset-non-lpsp:
- shard-apl: [DMESG-WARN][41] ([i915#1635] / [i915#95]) -> [PASS][42] +14 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-apl1/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-apl3/igt@[email protected]
* igt@kms_big_fb@linear-64bpp-rotate-0:
- shard-glk: [DMESG-FAIL][43] ([i915#118] / [i915#95]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-glk8/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-glk1/igt@[email protected]
* igt@kms_color@pipe-c-ctm-green-to-red:
- shard-skl: [DMESG-WARN][45] ([i915#1982]) -> [PASS][46] +10 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-skl8/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-skl3/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-skl: [INCOMPLETE][47] ([i915#300]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-skl2/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-skl10/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1:
- shard-glk: [FAIL][49] ([i915#79]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-glk5/igt@kms_flip@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-glk3/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [FAIL][51] ([i915#79]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-skl4/igt@kms_flip@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-skl10/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-skl: [FAIL][53] ([i915#46]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-skl8/igt@kms_flip@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-skl3/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-kbl: [DMESG-WARN][55] ([i915#180]) -> [PASS][56] +8 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-kbl3/igt@kms_flip@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-kbl4/igt@kms_flip@[email protected]
* igt@kms_flip@modeset-vs-vblank-race-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][57] ([i915#1982]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-kbl7/igt@kms_flip@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-kbl2/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack:
- shard-tglb: [DMESG-WARN][59] ([i915#1982]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-tglb7/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-tglb6/igt@[email protected]
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][61] ([i915#1188]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-skl5/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-skl6/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-skl: [INCOMPLETE][63] ([CI#80] / [i915#69]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-skl8/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-skl6/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-glk: [DMESG-WARN][65] ([i915#1982]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-glk8/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-glk1/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-skl: [INCOMPLETE][67] ([i915#69]) -> [PASS][68] +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-skl6/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-skl8/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][69] ([fdo#108145] / [i915#265]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-skl1/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-skl5/igt@[email protected]
* igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
- shard-iclb: [DMESG-WARN][71] ([i915#1982]) -> [PASS][72] +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-iclb3/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-iclb4/igt@[email protected]
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][73] ([i915#173]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-iclb1/igt@kms_psr@no_drrs.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-iclb5/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][75] ([fdo#109441]) -> [PASS][76] +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_gtt.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@perf@polling-parameterized:
- shard-iclb: [FAIL][77] ([i915#1542]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-iclb6/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-iclb8/igt@[email protected]
#### Warnings ####
* igt@gem_exec_reloc@basic-spin-others@vcs0:
- shard-snb: [WARN][79] ([i915#2021]) -> [WARN][80] ([i915#2036])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-snb6/igt@gem_exec_reloc@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-snb2/igt@gem_exec_reloc@[email protected]
* igt@gem_render_copy@y-tiled-mc-ccs-to-y-tiled-ccs:
- shard-apl: [SKIP][81] ([fdo#109271]) -> [SKIP][82] ([fdo#109271] / [i915#1635]) +8 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-apl2/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-apl4/igt@[email protected]
* igt@kms_content_protection@srm:
- shard-kbl: [TIMEOUT][83] ([i915#1319]) -> [TIMEOUT][84] ([i915#1319] / [i915#1958])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-kbl2/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-kbl1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [DMESG-WARN][85] ([i915#180] / [i915#93] / [i915#95]) -> [DMESG-WARN][86] ([i915#93] / [i915#95])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-kbl6/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-kbl6/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-rte:
- shard-apl: [SKIP][87] ([fdo#109271] / [i915#1635]) -> [SKIP][88] ([fdo#109271]) +5 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8678/shard-apl3/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/shard-apl6/igt@[email protected]
[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1928]: https://gitlab.freedesktop.org/drm/intel/issues/1928
[i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2021]: https://gitlab.freedesktop.org/drm/intel/issues/2021
[i915#2036]: https://gitlab.freedesktop.org/drm/intel/issues/2036
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#46]: https://gitlab.freedesktop.org/drm/intel/issues/46
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8678 -> Patchwork_18042
CI-20190529: 20190529
CI_DRM_8678: 7cafa8aeca728d8abd1bc9d31d2fca60757a00c4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5718: af1ef32bfae90bcdbaf1b5d84c61ff4e04368505 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18042: b97d79fa049ee3f3da673cd51616695c69da60c2 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18042/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx