net: dsa: loop: Print when registration is successful
Subsystems (3)
PATCH 1/1 net: dsa: loop: Print when registration is successful
We have a number of error conditions that can lead to the driver not probing successfully, move the print when we are sure dsa_register_switch() has suceeded. This avoids repeated prints in case of probe deferral for instance.
--- drivers/net/dsa/dsa_loop.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
drivers/net/dsa/dsa_loop.c +7 -4
@@ -280,13 +280,11 @@ static int dsa_loop_drv_probe(struct mdio_device *mdiodev)struct dsa_loop_pdata *pdata = mdiodev->dev.platform_data;struct dsa_loop_priv *ps;struct dsa_switch *ds; +int ret;if (!pdata)return -ENODEV ; -dev_info (&mdiodev->dev,"%s: 0x%0x\n" , - pdata->name, pdata->enabled_ports); - ds =devm_kzalloc (&mdiodev->dev,sizeof (*ds),GFP_KERNEL );if (!ds)return -ENOMEM ;
@@ -311,7 +309,12 @@ static int dsa_loop_drv_probe(struct mdio_device *mdiodev)dev_set_drvdata (&mdiodev->dev, ds); -return dsa_register_switch (ds); + ret =dsa_register_switch (ds); +if (!ret) +dev_info (&mdiodev->dev,"%s: 0x%0x\n" , + pdata->name, pdata->enabled_ports); + +return ret; }static void dsa_loop_drv_remove (struct mdio_device *mdiodev)
Signature · 1 line
2.25.1
Quoted 6 lines · Florian Fainelli
We have a number of error conditions that can lead to the driver not probing successfully, move the print when we are sure
dsa_register_switch()has suceeded. This avoids repeated prints in case of probe deferral for instance.Signed-off-by Florian Fainelli <[email protected]>
Andrew
Quoted 6 lines · Florian Fainelli
We have a number of error conditions that can lead to the driver not probing successfully, move the print when we are sure
dsa_register_switch()has suceeded. This avoids repeated prints in case of probe deferral for instance.Signed-off-by Florian Fainelli <[email protected]>
From: Florian Fainelli <[email protected]>
Date: Tue, 7 Jul 2020 21:45:13 -0700
Quoted 6 lines
We have a number of error conditions that can lead to the driver not probing successfully, move the print when we are sure
dsa_register_switch()has suceeded. This avoids repeated prints in case of probe deferral for instance.Signed-off-by Florian Fainelli <[email protected]>
Applied.