ARM: dts: stm32: Correct spi4 pins in stm32mp15-pinctrl.dtsi
Subsystems (2)
PATCH 1/1 ARM: dts: stm32: Correct spi4 pins in stm32mp15-pinctrl.dtsi
Move spi4_pins_a nodes from pinctrl_z to pinctrl
as the associated pins are not in BANK Z.
Fixes 498a7014989dfdd9a47864b55704dc829ed0dc90
Signed-off-by Patrick Delaunay <[email protected]>
---
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 28 ++++++++++++------------ 1 file changed, 14 insertions(+), 14 deletions(-)
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +14 -14
@@ -1574,6 +1574,20 @@ }; }; + spi4_pins_a: spi4-0 { + pins { + pinmux = <STM32_PINMUX('E', 12, AF5)>, /* SPI4_SCK */ + <STM32_PINMUX('E', 6, AF5)>; /* SPI4_MOSI */ + bias-disable; + drive-push-pull; + slew-rate = <1>; + }; + pins2 { + pinmux = <STM32_PINMUX('E', 13, AF5)>; /* SPI4_MISO */ + bias-disable; + }; + }; + usart2_pins_a: usart2-0 { pins1 { pinmux = <STM32_PINMUX('F', 5, AF7)>, /* USART2_TX */
@@ -1776,18 +1790,4 @@ bias-disable; }; }; - - spi4_pins_a: spi4-0 { - pins { - pinmux = <STM32_PINMUX('E', 12, AF5)>, /* SPI4_SCK */ - <STM32_PINMUX('E', 6, AF5)>; /* SPI4_MOSI */ - bias-disable; - drive-push-pull; - slew-rate = <1>; - }; - pins2 { - pinmux = <STM32_PINMUX('E', 13, AF5)>; /* SPI4_MISO */ - bias-disable; - }; - }; };
Signature · 1 line
2.17.1
Quoted 3 lines · Patrick Delaunay
Move
spi4_pins_anodes frompinctrl_zto pinctrl
as the associated pins are not in BANK Z.
Yikes, that's a nasty misplacement! Thanks for fixing.
Quoted 1 line
Fixes 498a7014989dfdd9a47864b55704dc829ed0dc90
Fixes tag should be of below:
Fixes 498a7014989d ("ARM: dts: stm32: Add missing pinctrl entries for STM32MP15")
Quoted 1 line
Signed-off-by Patrick Delaunay <[email protected]>
Reviewed-by Manivannan Sadhasivam <[email protected]>
Thanks,
Mani
Quoted 52 lines
---
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 28 ++++++++++++------------ 1 file changed, 14 insertions(+), 14 deletions(-)arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +14
-14@@ -1574,6 +1574,20 @@ }; }; + spi4_pins_a: spi4-0 { + pins { + pinmux = <STM32_PINMUX('E', 12, AF5)>, /* SPI4_SCK */ + <STM32_PINMUX('E', 6, AF5)>; /* SPI4_MOSI */ + bias-disable; + drive-push-pull; + slew-rate = <1>; + }; + pins2 { + pinmux = <STM32_PINMUX('E', 13, AF5)>; /* SPI4_MISO */ + bias-disable; + }; + }; + usart2_pins_a: usart2-0 { pins1 { pinmux = <STM32_PINMUX('F', 5, AF7)>, /* USART2_TX */@@ -1776,18 +1790,4 @@ bias-disable; }; }; - - spi4_pins_a: spi4-0 { - pins { - pinmux = <STM32_PINMUX('E', 12, AF5)>, /* SPI4_SCK */ - <STM32_PINMUX('E', 6, AF5)>; /* SPI4_MOSI */ - bias-disable; - drive-push-pull; - slew-rate = <1>; - }; - pins2 { - pinmux = <STM32_PINMUX('E', 13, AF5)>; /* SPI4_MISO */ - bias-disable; - }; - }; };Signature · 1 line
2.17.1
Hi Patrick
Quoted 7 lines · Patrick Delaunay
Move
spi4_pins_anodes frompinctrl_zto pinctrl
as the associated pins are not in BANK Z.Fixes 498a7014989dfdd9a47864b55704dc829ed0dc90Signed-off-by Patrick Delaunay <[email protected]>---
Applied on stm32-next by updating Fixes tag.
Thanks
Alex
Quoted 48 lines
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 28 ++++++++++++------------ 1 file changed, 14 insertions(+), 14 deletions(-)arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +14
-14@@ -1574,6 +1574,20 @@ }; }; + spi4_pins_a: spi4-0 { + pins { + pinmux = <STM32_PINMUX('E', 12, AF5)>, /* SPI4_SCK */ + <STM32_PINMUX('E', 6, AF5)>; /* SPI4_MOSI */ + bias-disable; + drive-push-pull; + slew-rate = <1>; + }; + pins2 { + pinmux = <STM32_PINMUX('E', 13, AF5)>; /* SPI4_MISO */ + bias-disable; + }; + }; + usart2_pins_a: usart2-0 { pins1 { pinmux = <STM32_PINMUX('F', 5, AF7)>, /* USART2_TX */@@ -1776,18 +1790,4 @@ bias-disable; }; }; - - spi4_pins_a: spi4-0 { - pins { - pinmux = <STM32_PINMUX('E', 12, AF5)>, /* SPI4_SCK */ - <STM32_PINMUX('E', 6, AF5)>; /* SPI4_MOSI */ - bias-disable; - drive-push-pull; - slew-rate = <1>; - }; - pins2 { - pinmux = <STM32_PINMUX('E', 13, AF5)>; /* SPI4_MISO */ - bias-disable; - }; - }; };