net/bnxt: fix build issue
PATCH 1/1 net/bnxt: fix build issue
In existing build env, RTE_LIBRTE_BNXT_PMD_SYSTEM is unset. Testing against a n value does not work and we end up with a link issue:
/usr/bin/ld: tf_core/tf_em_common.o: in function `tf_em_ext_common_alloc':.../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1040: undefined reference
to `tf_em_ext_alloc'/usr/bin/ld: tf_core/tf_em_common.o: in function `tf_em_ext_common_free':.../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1047: undefined reference
to `tf_em_ext_free'
collect2: error: ld returned 1 exit status
gmake[4]: *** [.../dpdk/mk/rte.lib.mk:95: librte_pmd_bnxt.so.20.0.3]
Error 1
gmake[3]: *** [.../dpdk/mk/rte.subdir.mk:35: bnxt] Error 2
--- drivers/net/bnxt/tf_core/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/bnxt/tf_core/Makefile +3 -3
@@ -16,10 +16,10 @@ SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_msg.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_tbl.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_common.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_internal.c -ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM), n) -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c +ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM),y) +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_system.c else -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM) += tf_core/tf_em_system.c +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c endif SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_session.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_device.c
Signature · 1 line
2.23.0
Quoted 30 lines · David Marchand
In existing build env,
RTE_LIBRTE_BNXT_PMD_SYSTEMis unset. Testing against a n value does not work and we end up with a link issue:
/usr/bin/ld:tf_core/tf_em_common.o: in function `tf_em_ext_common_alloc':.../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1040: undefined reference
to `tf_em_ext_alloc'/usr/bin/ld:tf_core/tf_em_common.o: in function `tf_em_ext_common_free':.../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1047: undefined reference
to `tf_em_ext_free'
collect2: error: ld returned 1 exit status
gmake[4]: *** [.../dpdk/mk/rte.lib.mk:95: librte_pmd_bnxt.so.20.0.3]
Error 1
gmake[3]: *** [.../dpdk/mk/rte.subdir.mk:35: bnxt] Error 2Fixes b2da02480cb7 ("net/bnxt: support EEM system memory")Signed-off-by David Marchand <[email protected]>--- drivers/net/bnxt/tf_core/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/net/bnxt/tf_core/Makefile +0
-0@@ -16,10 +16,10 @@ SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_msg.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_tbl.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_common.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_internal.c
drivers/net/bnxt/tf_core/Makefile SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_msg.c · line 25
Quoted 10 lines
drivers/net/bnxt/tf_core/Makefile +3
-3-ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM), n) -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c +ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM),y) +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_system.c else -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM) += tf_core/tf_em_system.c +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c endif SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_session.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_device.c
Functionally this is same so no objection to the change, but I wonder why 'RTE_LIBRTE_BNXT_PMD_SYSTEM' is unset.
"CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM=n" is added to 'config/common_base' in the same patch that updates the Makefile, so it should be set.
Btw, @Ajit, @Peter, how this new flagged managed via meson?
Quoted 50 lines · Ferruh Yigit
Quoted 4 lines · David Marchand
In existing build env,
RTE_LIBRTE_BNXT_PMD_SYSTEMis unset. Testing against a n value does not work and we end up with a link issue:
/usr/bin/ld:tf_core/tf_em_common.o: in function`tf_em_ext_common_alloc':
Quoted 1 line
.../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1040: undefinedreference
Quoted 3 lines
to `tf_em_ext_alloc'
/usr/bin/ld:tf_core/tf_em_common.o: in function `tf_em_ext_common_free':.../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1047: undefinedreference
Quoted 6 lines
to `tf_em_ext_free'
collect2: error: ld returned 1 exit status
gmake[4]: *** [.../dpdk/mk/rte.lib.mk:95: librte_pmd_bnxt.so.20.0.3]
Error 1
gmake[3]: *** [.../dpdk/mk/rte.subdir.mk:35: bnxt] Error 2Review
Quoted 8 lines
Fixes b2da02480cb7 ("net/bnxt: support EEM system memory")Signed-off-by David Marchand <[email protected]>--- drivers/net/bnxt/tf_core/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)(quoted diff) +0
-0b/drivers/net/bnxt/tf_core/Makefile
drivers/net/bnxt/tf_core/Makefile SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) +=
Quoted 4 lines
index
b4fbdd00fc..806471427c100644drivers/net/bnxt/tf_core/Makefile +0
-0@@ -16,10 +16,10 @@ SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) +=
tf_core/tf_msg.cQuoted 4 lines
drivers/net/bnxt/tf_core/Makefile +0
-0SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_tbl.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_common.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_internal.cdrivers/net/bnxt/tf_core/Makefile SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_msg.c · line 25
Quoted 10 lines
drivers/net/bnxt/tf_core/Makefile +3
-3-ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM), n) -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c +ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM),y) +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_system.c else -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM) += tf_core/tf_em_system.c +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c endif SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_session.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_device.cFunctionally this is same so no objection to the change, but I wonder why '
RTE_LIBRTE_BNXT_PMD_SYSTEM' is unset.
Quoted 7 lines
"
CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM=n" is added to 'config/common_base' in the
same patch that updates theMakefile, so it should be set.Btw, @Ajit, @Peter, how this new flagged managed via meson?
I will sync with Peter and others in the team and we will get back on this.
Quoted 14 lines · David Marchand
In existing build env,
RTE_LIBRTE_BNXT_PMD_SYSTEMis unset. Testing against a n value does not work and we end up with a link issue:
/usr/bin/ld:tf_core/tf_em_common.o: in function `tf_em_ext_common_alloc':.../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1040: undefined reference
to `tf_em_ext_alloc'/usr/bin/ld:tf_core/tf_em_common.o: in function `tf_em_ext_common_free':.../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1047: undefined reference
to `tf_em_ext_free'
collect2: error: ld returned 1 exit status
gmake[4]: *** [.../dpdk/mk/rte.lib.mk:95: librte_pmd_bnxt.so.20.0.3]
Error 1
gmake[3]: *** [.../dpdk/mk/rte.subdir.mk:35: bnxt] Error 2
Quoted 4 lines
Fixes b2da02480cb7 ("net/bnxt: support EEM system memory")Signed-off-by David Marchand <[email protected]>
Quoted 27 lines
--- drivers/net/bnxt/tf_core/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/net/bnxt/tf_core/Makefile +3
-4@@ -16,10 +16,10 @@ SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_msg.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_tbl.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_common.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_internal.c -ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM), n) -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c +ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM),y) +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_system.c else -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM) += tf_core/tf_em_system.c +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c endif SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_session.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_device.c --2.23.0
Quoted 19 lines · Ajit Khaparde
Quoted 14 lines · David Marchand
In existing build env,
RTE_LIBRTE_BNXT_PMD_SYSTEMis unset. Testing against a n value does not work and we end up with a link issue:
/usr/bin/ld:tf_core/tf_em_common.o: in function `tf_em_ext_common_alloc':.../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1040: undefined reference
to `tf_em_ext_alloc'/usr/bin/ld:tf_core/tf_em_common.o: in function `tf_em_ext_common_free':.../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1047: undefined reference
to `tf_em_ext_free'
collect2: error: ld returned 1 exit status
gmake[4]: *** [.../dpdk/mk/rte.lib.mk:95: librte_pmd_bnxt.so.20.0.3]
Error 1
gmake[3]: *** [.../dpdk/mk/rte.subdir.mk:35: bnxt] Error 2
Quoted 6 lines
Quoted 4 lines
Fixes b2da02480cb7 ("net/bnxt: support EEM system memory")Signed-off-by David Marchand <[email protected]>Acked-by Ajit Khaparde <[email protected]>
Patch applied to dpdk-next-net-brcm. Thanks
Quoted 29 lines
Quoted 29 lines
--- drivers/net/bnxt/tf_core/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/net/bnxt/tf_core/Makefile +3
-4@@ -16,10 +16,10 @@ SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_msg.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_tbl.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_common.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_internal.c -ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM), n) -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c +ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM),y) +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_system.c else -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM) += tf_core/tf_em_system.c +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c endif SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_session.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_device.c --2.23.0
Quoted 14 lines · David Marchand
In existing build env,
RTE_LIBRTE_BNXT_PMD_SYSTEMis unset. Testing against a n value does not work and we end up with a link issue:
/usr/bin/ld:tf_core/tf_em_common.o: in function `tf_em_ext_common_alloc':.../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1040: undefined reference
to `tf_em_ext_alloc'/usr/bin/ld:tf_core/tf_em_common.o: in function `tf_em_ext_common_free':.../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1047: undefined reference
to `tf_em_ext_free'
collect2: error: ld returned 1 exit status
gmake[4]: *** [.../dpdk/mk/rte.lib.mk:95: librte_pmd_bnxt.so.20.0.3]
Error 1
gmake[3]: *** [.../dpdk/mk/rte.subdir.mk:35: bnxt] Error 2
Quoted 4 lines
Fixes b2da02480cb7 ("net/bnxt: support EEM system memory")Signed-off-by David Marchand <[email protected]>
David,
I have submitted a patch [1]. With that memory management for Extended Exact Match is simplified. We won't need any config or meson option with that change.
[1] https://patchwork.dpdk.org/patch/74964/
Quoted 27 lines
--- drivers/net/bnxt/tf_core/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/net/bnxt/tf_core/Makefile +3
-4@@ -16,10 +16,10 @@ SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_msg.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_tbl.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_common.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_internal.c -ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM), n) -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c +ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM),y) +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_system.c else -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM) += tf_core/tf_em_system.c +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c endif SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_session.c SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_device.c --2.23.0
Hello Ajit,
Quoted 4 lines · Ajit Khaparde
I have submitted a patch [1]. With that memory management for Extended Exact Match is simplified. We won't need any config or meson option with that change.
Thanks for removing a build option :-).
You can drop my patch then.
Signature · 1 line
David Marchand