scsi: lpfc: Fix a condition in lpfc_dmp_dbg()
Subsystems (3)
PATCH 1/1 scsi: lpfc: Fix a condition in lpfc_dmp_dbg()
These variables are unsigned so the result of the subtraction is also unsigned and thus can't be negative. Change it to a comparison and remove the subtraction.
--- drivers/scsi/lpfc/lpfc_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/lpfc/lpfc_init.c +1 -1
@@ -14152,7 +14152,7 @@ void lpfc_dmp_dbg(struct lpfc_hba *phba)if ((start_idx + dbg_cnt) > (DBG_LOG_SZ -1 )) { temp_idx = (start_idx + dbg_cnt) %DBG_LOG_SZ ; }else { -if ((start_idx - dbg_cnt) <0 ) { +if (start_idx > dbg_cnt) { start_idx =DBG_LOG_SZ - (dbg_cnt - start_idx); temp_idx =0 ; }else {
Signature · 1 line
2.27.0
Quoted 15 lines · Dan Carpenter
These variables are unsigned so the result of the subtraction is also unsigned and thus can't be negative. Change it to a comparison and remove the subtraction.
Fixes 372c187b8a70 ("scsi: lpfc: Add an internal trace log buffer")Signed-off-by Dan Carpenter <[email protected]>--- drivers/scsi/lpfc/lpfc_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/scsi/lpfc/lpfc_init.c +0
-0
drivers/scsi/lpfc/lpfc_init.c void lpfc_dmp_dbg(struct lpfc_hba *phba) · line 14155
Quoted 5 lines
drivers/scsi/lpfc/lpfc_init.c +1
-1@@ -14152,7 +14152,7 @@ void lpfc_dmp_dbg(struct lpfc_hba *phba)if ((start_idx + dbg_cnt) > (DBG_LOG_SZ -1 )) { temp_idx = (start_idx + dbg_cnt) %DBG_LOG_SZ ; }else { -if ((start_idx - dbg_cnt) <0 ) { +if (start_idx > dbg_cnt) {
Nope. That's reversed. I'm dumb. Let me resend.
regards,
dan carpenter
PATCH v2 1/1 scsi: lpfc: Fix a condition in lpfc_dmp_dbg()
These variables are unsigned so the result of the subtraction is also unsigned and thus can't be negative. Change it to a comparison and remove the subtraction.
---
v2: I reverse the if statement in v1
drivers/scsi/lpfc/lpfc_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/lpfc/lpfc_init.c +1 -1
@@ -14152,7 +14152,7 @@ void lpfc_dmp_dbg(struct lpfc_hba *phba)if ((start_idx + dbg_cnt) > (DBG_LOG_SZ -1 )) { temp_idx = (start_idx + dbg_cnt) %DBG_LOG_SZ ; }else { -if ((start_idx - dbg_cnt) <0 ) { +if (start_idx < dbg_cnt) { start_idx =DBG_LOG_SZ - (dbg_cnt - start_idx); temp_idx =0 ; }else {
Signature · 1 line
2.27.0
Quoted 17 lines · Dan Carpenter
These variables are unsigned so the result of the subtraction is also unsigned and thus can't be negative. Change it to a comparison and remove the subtraction.
Fixes 372c187b8a70 ("scsi: lpfc: Add an internal trace log buffer")Signed-off-by Dan Carpenter <[email protected]>---
v2: I reverse the if statement in v1drivers/scsi/lpfc/lpfc_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/scsi/lpfc/lpfc_init.c +0
-0
drivers/scsi/lpfc/lpfc_init.c void lpfc_dmp_dbg(struct lpfc_hba *phba) · line 14158
Quoted 8 lines
drivers/scsi/lpfc/lpfc_init.c +1
-1@@ -14152,7 +14152,7 @@ void lpfc_dmp_dbg(struct lpfc_hba *phba)if ((start_idx + dbg_cnt) > (DBG_LOG_SZ -1 )) { temp_idx = (start_idx + dbg_cnt) %DBG_LOG_SZ ; }else { -if ((start_idx - dbg_cnt) <0 ) { +if (start_idx < dbg_cnt) { start_idx =DBG_LOG_SZ - (dbg_cnt - start_idx); temp_idx =0 ; }else {
Already resolved/accepted.
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?idwdd7d7b3442
Thank you though.
-- james