Skip to contentSkip to conversation

generic/530: Require metadata journaling

PATCH In review Jan Kara 2 participants 2 messages Jul 9, 2020

lore
Share & tools
lore

Jan Kara

author
#0 lore raw

PATCH 1/1 generic/530: Require metadata journaling

Test generic/530 doesn't make sence without metadata journalling as in that case, there's no way to recover shutdown fs besides fsck. ext4 can be configured without a journal and it supports shutdown ioctl even in that mode which makes this test fail for that configuration. Add requirement for metadata journalling to this test so that it's properly skipped.

---
 tests/generic/530 | 1 +
 1 file changed, 1 insertion(+)
tests/generic/530 +1 -0
index cb874ace902b..153a045dca87 100755
@@ -33,6 +33,7 @@ _supported_fs generic
 _supported_os Linux
 _require_scratch
 _require_scratch_shutdown
+_require_metadata_journaling
 _require_test_program "t_open_tmpfiles"
 
 rm -f $seqres.full
Signature · 1 line
2.16.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Jan Kara

Test generic/530 doesn't make sence without metadata journalling as in that case, there's no way to recover shutdown fs besides fsck. ext4 can be configured without a journal and it supports shutdown ioctl even in that mode which makes this test fail for that configuration. Add requirement for metadata journalling to this test so that it's properly skipped.

<shudder> Right, I forgot about that...

--D

Quoted 19 lines
---
 tests/generic/530 | 1 +
 1 file changed, 1 insertion(+)
tests/generic/530 +1 -0
index cb874ace902b..153a045dca87 100755
@@ -33,6 +33,7 @@ _supported_fs generic
 _supported_os Linux
 _require_scratch
 _require_scratch_shutdown
+_require_metadata_journaling
 _require_test_program "t_open_tmpfiles"
 
 rm -f $seqres.full
Signature · 1 line
2.16.4