IB/hfi1: Remove unnecessary fall-through markings
Subsystems (2)
PATCH 1/1 IB/hfi1: Remove unnecessary fall-through markings
Reorganize the code a bit in a more standard way[1] and remove unnecessary fall-through markings.
[1] https://lore.kernel.org/lkml/20200708054703.GR207186@unreal/
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/infiniband/hw/hfi1/chip.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/infiniband/hw/hfi1/chip.c +6 -6
@@ -7317,11 +7317,11 @@ static u16 link_width_to_bits(struct hfi1_devdata *dd, u16 width)case 1 :return OPA_LINK_WIDTH_1X ;case 2 :return OPA_LINK_WIDTH_2X ;case 3 :return OPA_LINK_WIDTH_3X ; +case 4 :return OPA_LINK_WIDTH_4X ;default :dd_dev_info (dd,"%s: invalid width %d, using 4\n" , __func__, width); -/* fall through */ -case 4 :return OPA_LINK_WIDTH_4X ; +return OPA_LINK_WIDTH_4X ; } }
@@ -12898,10 +12898,6 @@ u32 chip_to_opa_pstate(struct hfi1_devdata *dd, u32 chip_pstate) {/* look at the HFI meta-states only */ switch (chip_pstate &0xf0 ) { -default : -dd_dev_err (dd,"Unexpected chip physical state of 0x%x\n" , - chip_pstate); -/* fall through */ case PLS_DISABLED :return IB_PORTPHYSSTATE_DISABLED ;case PLS_OFFLINE :
@@ -12914,6 +12910,10 @@ u32 chip_to_opa_pstate(struct hfi1_devdata *dd, u32 chip_pstate)return IB_PORTPHYSSTATE_LINKUP ;case PLS_PHYTEST :return IB_PORTPHYSSTATE_PHY_TEST ; +default : +dd_dev_err (dd,"Unexpected chip physical state of 0x%x\n" , + chip_pstate); +return IB_PORTPHYSSTATE_DISABLED ; } }
Signature · 1 line
2.27.0