vhost-vdpa :Fix Coverity CID 1430270 / CID 1420267
PATCH v2 1/1 vhost-vdpa :Fix Coverity CID 1430270 / CID 1420267
In the function vhost_vdpa_dma_map/unmap, The struct msg was not initialized all its fields.
--- hw/virtio/vhost-vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
hw/virtio/vhost-vdpa.c +2 -2
@@ -38,7 +38,7 @@ static bool vhost_vdpa_listener_skipped_section(MemoryRegionSection *section)static int vhost_vdpa_dma_map (struct vhost_vdpa *v,hwaddr iova,hwaddr size,void *vaddr,bool readonly) { -struct vhost_msg_v2 msg; +struct vhost_msg_v2 msg = {};int fd = v->device_fd;int ret =0 ;
@@ -61,7 +61,7 @@ static int vhost_vdpa_dma_map(struct vhost_vdpa *v, hwaddr iova, hwaddr size,static int vhost_vdpa_dma_unmap (struct vhost_vdpa *v,hwaddr iova,hwaddr size) { -struct vhost_msg_v2 msg; +struct vhost_msg_v2 msg = {};int fd = v->device_fd;int ret =0 ;
Signature · 1 line
2.21.1
Quoted 8 lines · Cindy Lu
In the function vhost_vdpa_dma_map/unmap, The struct msg was not initialized all its fields.
Signed-off-by Cindy Lu <[email protected]>--- hw/virtio/vhost-vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
thanks
-- PMM
Quoted 3 lines · Cindy Lu
In the function vhost_vdpa_dma_map/unmap, The struct msg was not initialized all its fields.
Signed-off-by Cindy Lu <[email protected]>
Quoted 26 lines
--- hw/virtio/vhost-vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)hw/virtio/vhost-vdpa.c +2
-2@@ -38,7 +38,7 @@ static bool vhost_vdpa_listener_skipped_section(MemoryRegionSection *section)static int vhost_vdpa_dma_map (struct vhost_vdpa *v,hwaddr iova,hwaddr size,void *vaddr,bool readonly) { -struct vhost_msg_v2 msg; +struct vhost_msg_v2 msg = {};int fd = v->device_fd;int ret =0 ;@@ -61,7 +61,7 @@ static int vhost_vdpa_dma_map(struct vhost_vdpa *v, hwaddr iova, hwaddr size,static int vhost_vdpa_dma_unmap (struct vhost_vdpa *v,hwaddr iova,hwaddr size) { -struct vhost_msg_v2 msg; +struct vhost_msg_v2 msg = {};int fd = v->device_fd;int ret =0 ;
Quoted 4 lines · Cindy Lu <[email protected]> 于2020年7月10日周五 下午2:47写道:
In the function vhost_vdpa_dma_map/unmap, The struct msg was not initialized all its fields.
Signed-off-by Cindy Lu <[email protected]>
Quoted 30 lines
--- hw/virtio/vhost-vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)hw/virtio/vhost-vdpa.c +2
-3@@ -38,7 +38,7 @@ static bool vhost_vdpa_listener_skipped_section(MemoryRegionSection *section)static int vhost_vdpa_dma_map (struct vhost_vdpa *v,hwaddr iova,hwaddr size,void *vaddr,bool readonly) { -struct vhost_msg_v2 msg; +struct vhost_msg_v2 msg = {};int fd = v->device_fd;int ret =0 ;@@ -61,7 +61,7 @@ static int vhost_vdpa_dma_map(struct vhost_vdpa *v, hwaddr iova, hwaddr size,static int vhost_vdpa_dma_unmap (struct vhost_vdpa *v,hwaddr iova,hwaddr size) { -struct vhost_msg_v2 msg; +struct vhost_msg_v2 msg = {};int fd = v->device_fd;int ret =0 ; --2.21.1
(trimming down the rather exuberant CC list)
Quoted 7 lines · Cindy Lu
In the function vhost_vdpa_dma_map/unmap, The struct msg was not initialized all its fields.
Signed-off-by Cindy Lu <[email protected]>--- hw/virtio/vhost-vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Michael, I guess this should go via your tree ?
thanks
-- PMM
Quoted 11 lines · Peter Maydell
(trimming down the rather exuberant CC list)
Quoted 7 lines · Cindy Lu
In the function vhost_vdpa_dma_map/unmap, The struct msg was not initialized all its fields.
Signed-off-by Cindy Lu <[email protected]>--- hw/virtio/vhost-vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 4 lines
Michael, I guess this should go via your tree ?
thanks
-- PMM
Queues, thanks!