perf-probe: Fix GNU IFUNC probe issue etc.
cover perf-probe: Fix GNU IFUNC probe issue etc.
Hi,
Here are patches to fix some issues of probing on GNU IFUNC, duplicated symbols, and memory leak, which were reported by Andi.
Andi reported that some issues on probing memcpy function in glibc, which was related to GNU IFUNC (indirect function). As I described in the patch [4/4], it is hard to support probing on the functions which are selected by GNU indirect function because those are chosen at runtime. I think we need a user-mode helper in uprobes to find which one is chosen at runtime. (Oleg, Srikar, would you have any idea?)
While cleaning up the patches, I also found a memory leak problem so fixed it ([3/4]).
Thank you,
---
Masami Hiramatsu (4):
perf-probe: Avoid setting probes on same address on same event
perf-probe: Fix wrong variable warning when the probe point is not found
perf-probe: Fix memory leakage when the probe point is not found
perf-probe: Warn if the target function is GNU Indirect function
tools/perf/util/probe-event.c | 14 ++++++++++++++ tools/perf/util/probe-finder.c | 5 ++++- 2 files changed, 18 insertions(+), 1 deletion(-)
--
Masami Hiramatsu (Linaro) <[email protected]>
PATCH 1/4 perf-probe: Avoid setting probes on same address on same event
There is a case that the several same-name symbols points same address. In that case, perf probe returns an error.
E.g.
perf probe -x /lib64/libc-2.30.so -v -a "memcpy arg1=%di" probe-definition(0): memcpy arg1=%di
symbol:memcpy file:(null) line:0 offset:0 return:0 lazy:(null)
parsing arg: arg1=%di into name:arg1 %di
1 arguments
symbol:setjmp file:(null) line:0 offset:0 return:0 lazy:(null)
symbol:longjmp file:(null) line:0 offset:0 return:0 lazy:(null) symbol:longjmp_target file:(null) line:0 offset:0 return:0 lazy:(null) symbol:lll_lock_wait_private file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_mallopt_arena_max file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_mallopt_arena_test file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_tunable_tcache_max_bytes file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_tunable_tcache_count file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_tunable_tcache_unsorted_limit file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_mallopt_trim_threshold file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_mallopt_top_pad file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_mallopt_mmap_threshold file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_mallopt_mmap_max file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_mallopt_perturb file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_mallopt_mxfast file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_heap_new file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_arena_reuse_free_list file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_arena_reuse file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_arena_reuse_wait file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_arena_new file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_arena_retry file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_sbrk_less file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_heap_free file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_heap_less file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_tcache_double_free file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_heap_more file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_sbrk_more file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_malloc_retry file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_memalign_retry file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_mallopt_free_dyn_thresholds file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_realloc_retry file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_calloc_retry file:(null) line:0 offset:0 return:0 lazy:(null) symbol:memory_mallopt file:(null) line:0 offset:0 return:0 lazy:(null)
Open Debuginfo file: /usr/lib/debug/usr/lib64/libc-2.30.so.debug
Try to find probe point from debuginfo.
Opening /sys/kernel/debug/tracing//README write=0
Failed to find the location of the '%di' variable at this address.
Perhaps it has been optimized out.
Use -V with the --range option to show '%di' location range.
An error occurred in debuginfo analysis (-2).
Trying to use symbols.
Opening /sys/kernel/debug/tracing//uprobe_events write=1
Writing event: p:probe_libc/memcpy /usr/lib64/libc-2.30.so:0x914c0 arg1=%di Writing event: p:probe_libc/memcpy /usr/lib64/libc-2.30.so:0x914c0 arg1=%di Failed to write event: File exists
Error: Failed to add events. Reason: File exists (Code: -17)
You can see the perf tried to write completely same probe definition twice, which caused an error.
To fix this issue, check the symbol list and drop duplicated symbols (which has same symbol name and address) from it.
With this patch;
# perf probe -x /lib64/libc-2.30.so -a "memcpy arg1=%di"
Failed to find the location of the '%di' variable at this address.
Perhaps it has been optimized out.
Use -V with the --range option to show '%di' location range.
Added new events:
probe_libc:memcpy (on memcpy in /usr/lib64/libc-2.30.so with arg1=%di)
probe_libc:memcpy (on memcpy in /usr/lib64/libc-2.30.so with arg1=%di)You can now use it in all perf tools, such as:
perf record -e probe_libc:memcpy -aR sleep 1
--- tools/perf/util/probe-event.c | 9 +++++++++ 1 file changed, 9 insertions(+)
tools/perf/util/probe-event.c +9 -0
@@ -2968,6 +2968,15 @@ static int find_probe_trace_events_from_map(struct perf_probe_event *pev,for (j =0 ; j < num_matched_functions; j++) { sym = syms[j]; +/* There can be duplicated symbols in the map */ +for (i =0 ; i < j; i++) +if (sym->start == syms[i]->start) { +pr_debug ("find duplicated symbol %s @ %lx\n" , sym->name, sym->start); +break ; + } +if (i != j) +continue ; + tev = (*tevs) + ret; tp = &tev->point;if (ret == num_matched_functions) {
Re: [PATCH 1/4] perf-probe: Avoid setting probes on same address on same event
Quoted 15 lines · Masami Hiramatsu
There is a case that the several same-name symbols points same address. In that case, perf probe returns an error.
E.g.
With this patch;
# perf probe -x /lib64/libc-2.30.so -a "memcpy arg1=%di" Failed to find the location of the '%di' variable at this address. Perhaps it has been optimized out. Use -V with the --range option to show '%di' location range. Added new events: probe_libc:memcpy (on memcpy in /usr/lib64/libc-2.30.so with arg1=%di) probe_libc:memcpy (on memcpy in /usr/lib64/libc-2.30.so with arg1=%di)
Quoted 7 lines
You can now use it in all perf tools, such as:
perf record -e probe_libc:memcpy -aR sleep 1
Reported-by Andi Kleen <[email protected]>Signed-off-by Masami Hiramatsu <[email protected]>
One small nit:
Quoted 9 lines
--- tools/perf/util/probe-event.c | 9 +++++++++ 1 file changed, 9 insertions(+)tools/perf/util/probe-event.c +0
-0
tools/perf/util/probe-event.c static int find_probe_trace_events_from_map(struct perf_probe_event *pev, · line 2974
Quoted 7 lines
tools/perf/util/probe-event.c +4
-0@@ -2968,6 +2968,15 @@ static int find_probe_trace_events_from_map(struct perf_probe_event *pev,for (j =0 ; j < num_matched_functions; j++) { sym = syms[j]; +/* There can be duplicated symbols in the map */ +for (i =0 ; i < j; i++) +if (sym->start == syms[i]->start) { +pr_debug ("find duplicated symbol %s @ %lx\n" , sym->name, sym->start);
Would "Found" sound better than "find"?
tools/perf/util/probe-event.c static int find_probe_trace_events_from_map(struct perf_probe_event *pev, · line 2979
Quoted 5 lines
tools/perf/util/probe-event.c +5
-0+break ; + } +if (i != j) +continue ; +
Quoted 4 lines
tools/perf/util/probe-event.c +0
-0tev = (*tevs) + ret; tp = &tev->point;if (ret == num_matched_functions) {
Signature · 2 lines
Thanks and Regards Srikar Dronamraju
Re: [PATCH 1/4] perf-probe: Avoid setting probes on same address on same event
Quoted 39 lines · On Fri, 10 Jul 2020 16:48:47 +0530 Srikar Dronamraju…
Quoted 15 lines · Masami Hiramatsu
There is a case that the several same-name symbols points same address. In that case, perf probe returns an error.
E.g.
With this patch;
# perf probe -x /lib64/libc-2.30.so -a "memcpy arg1=%di" Failed to find the location of the '%di' variable at this address. Perhaps it has been optimized out. Use -V with the --range option to show '%di' location range. Added new events: probe_libc:memcpy (on memcpy in /usr/lib64/libc-2.30.so with arg1=%di) probe_libc:memcpy (on memcpy in /usr/lib64/libc-2.30.so with arg1=%di)Quoted 7 lines
You can now use it in all perf tools, such as:
perf record -e probe_libc:memcpy -aR sleep 1
Reported-by Andi Kleen <[email protected]>Signed-off-by Masami Hiramatsu <[email protected]>One small nit:
Quoted 12 lines
--- tools/perf/util/probe-event.c | 9 +++++++++ 1 file changed, 9 insertions(+)tools/perf/util/probe-event.c +0
-0@@ -2968,6 +2968,15 @@ static int find_probe_trace_events_from_map(struct perf_probe_event *pev,for (j =0 ; j < num_matched_functions; j++) { sym = syms[j];
Quoted 6 lines
tools/perf/util/probe-event.c static int find_probe_trace_events_from_map(struct perf_probe_event *pev, · line 2974
Quoted 4 lines
tools/perf/util/probe-event.c +4
-0+/* There can be duplicated symbols in the map */ +for (i =0 ; i < j; i++) +if (sym->start == syms[i]->start) { +pr_debug ("find duplicated symbol %s @ %lx\n" , sym->name, sym->start);Would "Found" sound better than "find"?
OK.
Quoted 8 lines
tools/perf/util/probe-event.c static int find_probe_trace_events_from_map(struct perf_probe_event *pev, · line 2979
Quoted 6 lines
tools/perf/util/probe-event.c +5
-0+break ; + } +if (i != j) +continue ; +Reviewed-by Srikar Dronamraju <[email protected]>
Thank you!
Quoted 10 lines
Quoted 6 lines
tools/perf/util/probe-event.c +0
-0tev = (*tevs) + ret; tp = &tev->point;if (ret == num_matched_functions) {Signature · 2 lines
Thanks and Regards Srikar Dronamraju
Signature · 1 line
Masami Hiramatsu <[email protected]>
PATCH 2/4 perf-probe: Fix wrong variable warning when the probe point is not found
In reply to Masami HiramatsuFix a wrong "variable not found" warning when the probe point is not found in the debuginfo.
Since the debuginfo__find_probes() can return 0 even if it does not find given probe point in the debuginfo, fill_empty_trace_arg() can be called with tf.ntevs == 0 and it can warn a wrong warning. To fix this, reject ntevs == 0 in fill_empty_trace_arg().
E.g. without this patch;
# perf probe -x /lib64/libc-2.30.so -a "memcpy arg1=%di"
Failed to find the location of the '%di' variable at this address.
Perhaps it has been optimized out.
Use -V with the --range option to show '%di' location range.
Added new events:
probe_libc:memcpy (on memcpy in /usr/lib64/libc-2.30.so with arg1=%di)
probe_libc:memcpy (on memcpy in /usr/lib64/libc-2.30.so with arg1=%di)You can now use it in all perf tools, such as:
perf record -e probe_libc:memcpy -aR sleep 1
With this;
# perf probe -x /lib64/libc-2.30.so -a "memcpy arg1=%di"
Added new events:
probe_libc:memcpy (on memcpy in /usr/lib64/libc-2.30.so with arg1=%di)
probe_libc:memcpy (on memcpy in /usr/lib64/libc-2.30.so with arg1=%di)You can now use it in all perf tools, such as:
perf record -e probe_libc:memcpy -aR sleep 1
--- tools/perf/util/probe-finder.c | 3 +++ 1 file changed, 3 insertions(+)
tools/perf/util/probe-finder.c +3 -0
@@ -1408,6 +1408,9 @@ static int fill_empty_trace_arg(struct perf_probe_event *pev,char *type;int i, j, ret; +if (!ntevs) +return -ENOENT ; +for (i =0 ; i < pev->nargs; i++) { type =NULL ;for (j =0 ; j < ntevs; j++) {
Re: [PATCH 2/4] perf-probe: Fix wrong variable warning when the probe point is not found
Quoted 30 lines · Masami Hiramatsu
Fix a wrong "variable not found" warning when the probe point is not found in the debuginfo.
Since thedebuginfo__find_probes()can return 0 even if it does not find given probe point in the debuginfo,fill_empty_trace_arg()can be called with tf.ntevs == 0 and it can warn a wrong warning. To fix this, reject ntevs == 0 infill_empty_trace_arg().E.g. without this patch;
# perf probe -x /lib64/libc-2.30.so -a "memcpy arg1=%di" Failed to find the location of the '%di' variable at this address. Perhaps it has been optimized out. Use -V with the --range option to show '%di' location range. Added new events: probe_libc:memcpy (on memcpy in /usr/lib64/libc-2.30.so with arg1=%di) probe_libc:memcpy (on memcpy in /usr/lib64/libc-2.30.so with arg1=%di)You can now use it in all perf tools, such as:
perf record -e probe_libc:memcpy -aR sleep 1
With this;
# perf probe -x /lib64/libc-2.30.so -a "memcpy arg1=%di" Added new events: probe_libc:memcpy (on memcpy in /usr/lib64/libc-2.30.so with arg1=%di) probe_libc:memcpy (on memcpy in /usr/lib64/libc-2.30.so with arg1=%di)You can now use it in all perf tools, such as:
Quoted 7 lines
perf record -e probe_libc:memcpy -aR sleep 1
Reported-by Andi Kleen <[email protected]>Fixes cb4027308570 ("perf probe: Trace a magic number if variable is not found")Signed-off-by Masami Hiramatsu <[email protected]>
Except for the minor nit on the message all patches look good to me.
-Andi
Re: [PATCH 2/4] perf-probe: Fix wrong variable warning when the probe point is not found
In reply to Masami HiramatsuQuoted 9 lines · Masami Hiramatsu
Fix a wrong "variable not found" warning when the probe point is not found in the debuginfo.
Since thedebuginfo__find_probes()can return 0 even if it does not find given probe point in the debuginfo,fill_empty_trace_arg()can be called with tf.ntevs == 0 and it can warn a wrong warning. To fix this, reject ntevs == 0 infill_empty_trace_arg().
Quoted 4 lines
Reported-by Andi Kleen <[email protected]>Fixes cb4027308570 ("perf probe: Trace a magic number if variable is not found")Signed-off-by Masami Hiramatsu <[email protected]>
Looks good to me.
Quoted 19 lines
--- tools/perf/util/probe-finder.c | 3 +++ 1 file changed, 3 insertions(+)tools/perf/util/probe-finder.c +3
-0@@ -1408,6 +1408,9 @@ static int fill_empty_trace_arg(struct perf_probe_event *pev,char *type;int i, j, ret; +if (!ntevs) +return -ENOENT ; +for (i =0 ; i < pev->nargs; i++) { type =NULL ;for (j =0 ; j < ntevs; j++) {
Signature · 2 lines
Thanks and Regards Srikar Dronamraju
PATCH 3/4 perf-probe: Fix memory leakage when the probe point is not found
In reply to Masami HiramatsuFix the memory leakage in debuginfo__find_trace_events() when the probe point is not found in the debuginfo. If there is no probe point found in the debuginfo, debuginfo__find_probes() will NOT return -ENOENT, but 0. Thus the caller of debuginfo__find_probes() must check the tf.ntevs and release the allocated memory for the array of struct probe_trace_event.
The current code releases the memory only if the debuginfo__find_probes() hits an error but not checks tf.ntevs. In the result, the memory allocated on *tevs are not released if tf.ntevs == 0.
This fixes the memory leakage by checking tf.ntevs == 0 in addition to ret < 0.
--- tools/perf/util/probe-finder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/probe-finder.c +1 -1
@@ -1467,7 +1467,7 @@ int debuginfo__find_trace_events(struct debuginfo *dbg,if (ret >=0 && tf.pf.skip_empty_arg) ret =fill_empty_trace_arg (pev, tf.tevs, tf.ntevs); -if (ret <0 ) { +if (ret <0 || tf.ntevs ==0 ) {for (i =0 ; i < tf.ntevs; i++)clear_probe_trace_event (&tf.tevs[i]);zfree (tevs);
Re: [PATCH 3/4] perf-probe: Fix memory leakage when the probe point is not found
Quoted 10 lines · Masami Hiramatsu
Fix the memory leakage in
debuginfo__find_trace_events()when the probe point is not found in the debuginfo. If there is no probe point found in the debuginfo,debuginfo__find_probes()will NOT return-ENOENT, but 0. Thus the caller ofdebuginfo__find_probes()must check the tf.ntevs and release the allocated memory for the array of structprobe_trace_event.The current code releases the memory only if the
debuginfo__find_probes()hits an error but not checks tf.ntevs. In the result, the memory allocated on *tevs are not released if tf.ntevs == 0.
Quoted 6 lines
This fixes the memory leakage by checking tf.ntevs == 0 in addition to ret < 0.
Fixes ff741783506c ("perf probe: Introduce debuginfo to encapsulate dwarf information")Signed-off-by Masami Hiramatsu <[email protected]>
Looks good to me.
Quoted 18 lines
--- tools/perf/util/probe-finder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/util/probe-finder.c +1
-1@@ -1467,7 +1467,7 @@ int debuginfo__find_trace_events(struct debuginfo *dbg,if (ret >=0 && tf.pf.skip_empty_arg) ret =fill_empty_trace_arg (pev, tf.tevs, tf.ntevs); -if (ret <0 ) { +if (ret <0 || tf.ntevs ==0 ) {for (i =0 ; i < tf.ntevs; i++)clear_probe_trace_event (&tf.tevs[i]);zfree (tevs);
Signature · 2 lines
Thanks and Regards Srikar Dronamraju
PATCH 4/4 perf-probe: Warn if the target function is GNU Indirect function
In reply to Masami HiramatsuWarn if the probe target function is GNU indirect function (GNU_IFUNC) because it may not what the user want to probe.
The GNU indirect function ( https://sourceware.org/glibc/wiki/GNU_IFUNC ) is the dynamic solved symbol at runtime. IFUNC function is a selector which is invoked from the elf loader, but the symbol address of the function which will be modified by the IFUNC is same as the IFUNC in the symbol table. This can confuse users who is trying to probe on such functions.
For example, the memcpy is one of IFUNC.
# perf probe -x /lib64/libc-2.30.so -a memcpy # perf probe -l probe_libc:memcpy (on __new_memcpy_ifunc@x86_64/multiarch/memcpy.c in /usr/lib64/libc-2.30.so)
the probe is put on a IFUNC.
# perf record -e probe_libc:memcpy --call-graph dwarf -aR ./perf
# perf script
perf 1742 [000] 26201.715632: probe_libc:memcpy: (7fdaa53824c0)
7fdaa53824c0 __new_memcpy_ifunc+0x0 (inlined)
7fdaa5d4a980 elf_machine_rela+0x6c0 (inlined)
7fdaa5d4a980 elf_dynamic_do_Rela+0x6c0 (inlined)
7fdaa5d4a980 _dl_relocate_object+0x6c0 (/usr/lib64/ld-2.30.so)
7fdaa5d42155 dl_main+0x1cc5 (/usr/lib64/ld-2.30.so)
7fdaa5d5831a _dl_sysdep_start+0x54a (/usr/lib64/ld-2.30.so)
7fdaa5d3ffeb _dl_start_final+0x25b (inlined)
7fdaa5d3ffeb _dl_start+0x25b (/usr/lib64/ld-2.30.so)
7fdaa5d3f117 .annobin_rtld.c+0x7 (inlined)
...And the event is invoked from the elf loader instead of the target program's main code.
Moreover, at this moment, we can not probe on the function which will be selected by the IFUNC, because it is determined at runtime. But uprobe will be prepared before running the target binary.
Thus, I decided to warn user when the perf probe detects the probe point is on the GNU IFUNC symbol. Someone who wants to probe an IFUNC symbol to debug the IFUNC function, they can ignore this warning.
--- tools/perf/util/probe-event.c | 5 +++++ 1 file changed, 5 insertions(+)
tools/perf/util/probe-event.c +5 -0
@@ -379,6 +379,11 @@ static int find_alternative_probe_point(struct debuginfo *dinfo, address = sym->start; else address = map->unmap_ip (map, sym->start) - map->reloc; +if (sym->type ==STT_GNU_IFUNC ) { +pr_warning ("Warning: The probe address (0x%lx) is in a GNU indirect function.\n" +"This may not work as you expected unless you intend to probe the indirect function.\n" , + (unsigned long )address); + }break ; }if (!address) {
Re: [PATCH 4/4] perf-probe: Warn if the target function is GNU Indirect function
tools/perf/util/probe-event.c static int find_alternative_probe_point(struct debuginfo *dinfo, · line 384
Quoted 11 lines
tools/perf/util/probe-event.c +3
-0@@ -379,6 +379,11 @@ static int find_alternative_probe_point(struct debuginfo *dinfo, address = sym->start; else address = map->unmap_ip (map, sym->start) - map->reloc; +if (sym->type ==STT_GNU_IFUNC ) { + pr_warning("Warning: The probe address (0x%lx) is in a GNU indirect function.\n" + "This may not work as you expected unless you intend to probe the indirect function.\n",
I would say something like this.
Consider identifying the final function used at run time and set the probe directly on that.
I think that's more useful to the user.
-Andi
Re: [PATCH 4/4] perf-probe: Warn if the target function is GNU Indirect function
Quoted 14 lines · On Thu, 9 Jul 2020 07:36:54 -0700 Andi Kleen <[email protected]> wrote:
tools/perf/util/probe-event.c static int find_alternative_probe_point(struct debuginfo *dinfo, · line 384
Quoted 11 lines
tools/perf/util/probe-event.c +3
-0@@ -379,6 +379,11 @@ static int find_alternative_probe_point(struct debuginfo *dinfo, address = sym->start; else address = map->unmap_ip (map, sym->start) - map->reloc; +if (sym->type ==STT_GNU_IFUNC ) { + pr_warning("Warning: The probe address (0x%lx) is in a GNU indirect function.\n" + "This may not work as you expected unless you intend to probe the indirect function.\n",I would say something like this.
Quoted 4 lines
Consider identifying the final function used at run time and set the probe directly on that.
I think that's more useful to the user.
Hmm, would you mean the default function which may be used for the symbol? Let me check how we can find it.
Thank you,
Signature · 1 line
Masami Hiramatsu <[email protected]>
Arnaldo Carvalho de Melo
maintainerRe: [PATCH 4/4] perf-probe: Warn if the target function is GNU Indirect function
Em Fri, Jul 10, 2020 at 12:30:08PM +0900, Masami Hiramatsu escreveu:
Quoted 17 lines
Quoted 14 lines · On Thu, 9 Jul 2020 07:36:54 -0700 Andi Kleen <[email protected]> wrote:
tools/perf/util/probe-event.c static int find_alternative_probe_point(struct debuginfo *dinfo, · line 384
Quoted 11 lines
tools/perf/util/probe-event.c +3
-0@@ -379,6 +379,11 @@ static int find_alternative_probe_point(struct debuginfo *dinfo, address = sym->start; else address = map->unmap_ip (map, sym->start) - map->reloc; +if (sym->type ==STT_GNU_IFUNC ) { + pr_warning("Warning: The probe address (0x%lx) is in a GNU indirect function.\n" + "This may not work as you expected unless you intend to probe the indirect function.\n",I would say something like this.
Quoted 6 lines
Quoted 4 lines
Consider identifying the final function used at run time and set the probe directly on that.
I think that's more useful to the user.
Hmm, would you mean the default function which may be used for the symbol?
Humm, I think he means that the user must somehow, knowing details involved in picking the final function, probe that one instead of the IFUNC one, right Andi?
- Arnaldo
Quoted 1 line
Let me check how we can find it.
Re: [PATCH 4/4] perf-probe: Warn if the target function is GNU Indirect function
Quoted 21 lines · On Fri, 10 Jul 2020 08:55:40 -0300 Arnaldo Carvalho de Melo <[email protected]>…
Em Fri, Jul 10, 2020 at 12:30:08PM +0900, Masami Hiramatsu escreveu:
Quoted 20 lines
Quoted 17 lines · On Thu, 9 Jul 2020 07:36:54 -0700 Andi Kleen <[email protected]> wrote:
tools/perf/util/probe-event.c static int find_alternative_probe_point(struct debuginfo *dinfo, · line 384
Quoted 11 lines
tools/perf/util/probe-event.c +3
-0@@ -379,6 +379,11 @@ static int find_alternative_probe_point(struct debuginfo *dinfo, address = sym->start; else address = map->unmap_ip (map, sym->start) - map->reloc; +if (sym->type ==STT_GNU_IFUNC ) { + pr_warning("Warning: The probe address (0x%lx) is in a GNU indirect function.\n" + "This may not work as you expected unless you intend to probe the indirect function.\n",I would say something like this.
Consider identifying the final function used at run time and set the probe directly on that.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
I think that's more useful to the user.
Hmm, would you mean the default function which may be used for the symbol?
Humm, I think he means that the user must somehow, knowing details involved in picking the final function, probe that one instead of the IFUNC one, right Andi?
Ah, I got it. OK, I'll update the message :)
Thank you,
Signature · 1 line
Masami Hiramatsu <[email protected]>
Re: [PATCH 4/4] perf-probe: Warn if the target function is GNU Indirect function
In reply to Masami HiramatsuQuoted 11 lines · Masami Hiramatsu
Reported-by Andi Kleen <[email protected]>Signed-off-by Masami Hiramatsu <[email protected]>--- tools/perf/util/probe-event.c | 5 +++++ 1 file changed, 5 insertions(+)tools/perf/util/probe-event.c +0
-0
tools/perf/util/probe-event.c static int find_alternative_probe_point(struct debuginfo *dinfo, · line 386
Quoted 8 lines
tools/perf/util/probe-event.c +5
-0@@ -379,6 +379,11 @@ static int find_alternative_probe_point(struct debuginfo *dinfo, address = sym->start; else address = map->unmap_ip (map, sym->start) - map->reloc; +if (sym->type ==STT_GNU_IFUNC ) { +pr_warning ("Warning: The probe address (0x%lx) is in a GNU indirect function.\n" +"This may not work as you expected unless you intend to probe the indirect function.\n" , + (unsigned long )address); + }
Are these GNU indirect functions possible in kernel? If not we could move this warning under if (uprobes)
Also instead of printing the address, can we print the pp->function?
Quoted 4 lines
tools/perf/util/probe-event.c +0
-0break ; }if (!address) {
Signature · 2 lines
Thanks and Regards Srikar Dronamraju
Re: [PATCH 4/4] perf-probe: Warn if the target function is GNU Indirect function
Quoted 8 lines · On Fri, 10 Jul 2020 16:45:12 +0530 Srikar Dronamraju…
Quoted 6 lines · Masami Hiramatsu
Reported-by Andi Kleen <[email protected]>Signed-off-by Masami Hiramatsu <[email protected]>--- tools/perf/util/probe-event.c | 5 +++++ 1 file changed, 5 insertions(+)
Quoted 16 lines
tools/perf/util/probe-event.c static int find_alternative_probe_point(struct debuginfo *dinfo, · line 386
Quoted 13 lines
tools/perf/util/probe-event.c +5
-0@@ -379,6 +379,11 @@ static int find_alternative_probe_point(struct debuginfo *dinfo, address = sym->start; else address = map->unmap_ip (map, sym->start) - map->reloc; +if (sym->type ==STT_GNU_IFUNC ) { +pr_warning ("Warning: The probe address (0x%lx) is in a GNU indirect function.\n" +"This may not work as you expected unless you intend to probe the indirect function.\n" , + (unsigned long )address); + }Are these GNU indirect functions possible in kernel? If not we could move this warning under if (uprobes)
OK, I'll move it under if (uprobes).
Quoted 2 lines
Also instead of printing the address, can we print the
pp->function?
Hmm, OK. But it may not help user because the pp->function will the name specified by user...
Thank you,
Signature · 1 line
Masami Hiramatsu <[email protected]>