driver core: add device probe log helper
Subsystems (4)
A message that is not in the archive (sent off-list or not yet received): CGME20200710153023eucas1p152c48e4208bff8c0ae9b8c734be45db2@eucas1p1.samsung.com
v8 cover driver core: add probe error check helper
Hi All,
Thanks for comments.
Changes since v7:
- improved commit message
- added R-Bs
Changes since v6:
- removed leftovers from old naming scheme in commit descritions,
- added R-Bs.
Changes since v5:
- removed patch adding macro, dev_err_probe(dev, PTR_ERR(ptr), ...) should be used instead,
- added dev_dbg logging in case of -EPROBE_DEFER,
- renamed functions and vars according to comments,
- extended docs,
- cosmetics.
Original message (with small adjustments):
Recently I took some time to re-check error handling in drivers probe code, and I have noticed that number of incorrect resource acquisition error handling increased and there are no other propositions which can cure the situation.
So I have decided to resend my old proposition of probe_err helper which should simplify resource acquisition error handling, it also extend it with adding defer probe reason to devices_deferred debugfs property, which should improve debugging experience for developers/testers.
I have also added two patches showing usage and benefits of the helper.
My dirty/ad-hoc cocci scripts shows that this helper can be used in at least 2700 places saving about 3500 lines of code.
Regards
Andrzej
Andrzej Hajda (5):
driver core: add device probe log helper
driver core: add deferring probe reason to devices_deferred property drm/bridge/sii8620: fix resource acquisition error handling drm/bridge: lvds-codec: simplify error handling
coccinelle: add script looking for cases where probe__err can be used
drivers/base/base.h | 3 + drivers/base/core.c | 46 +++++ drivers/base/dd.c | 23 ++- drivers/gpu/drm/bridge/lvds-codec.c | 10 +- drivers/gpu/drm/bridge/sil-sii8620.c | 21 +-- include/linux/device.h | 3 + probe_err.cocci | 247 +++++++++++++++++++++++++++ 7 files changed, 333 insertions(+), 20 deletions(-) create mode 100644 probe_err.cocci
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v8 1/5 driver core: add device probe log helper
During probe every time driver gets resource it should usually check for error printk some message if it is not -EPROBE_DEFER and return the error. This pattern is simple but requires adding few lines after any resource acquisition code, as a result it is often omitted or implemented only partially.dev_err_probe helps to replace such code sequences with simple call, so code:
if (err != -EPROBE_DEFER) dev_err(dev, ...); return err; becomes: return dev_err_probe(dev, err, ...);
--- drivers/base/core.c | 42 ++++++++++++++++++++++++++++++++++++++++++ include/linux/device.h | 3 +++ 2 files changed, 45 insertions(+)
drivers/base/core.c +42 -0
@@ -3953,6 +3953,48 @@ define_dev_printk_level(_dev_info, KERN_INFO);#endif +/** +* dev_err_probe - probe error check and log helper +* @dev: the pointer to the struct device +* @err: error value to test +* @fmt: printf-style format string +* @...: arguments as specified in the format string +* +* This helper implements common pattern present in probe functions for error +* checking: print debug or error message depending if the error value is +* -EPROBE_DEFER and propagate error upwards. +* It replaces code sequence: +* if (err != -EPROBE_DEFER) +* dev_err(dev, ...); +* else +* dev_dbg(dev, ...); +* return err; +* with +* return dev_err_probe(dev, err, ...); +* +* Returns @err. +* +*/ +int dev_err_probe (const struct device *dev,int err,const char *fmt, ...) +{ +struct va_format vaf; +va_list args; + +va_start (args, fmt); + vaf.fmt = fmt; + vaf.va = &args; + +if (err != -EPROBE_DEFER ) +dev_err (dev,"error %d: %pV" , err, &vaf); +else +dev_dbg (dev,"error %d: %pV" , err, &vaf); + +va_end (args); + +return err; +} +EXPORT_SYMBOL_GPL (dev_err_probe); +static inline bool fwnode_is_primary (struct fwnode_handle *fwnode) {return fwnode && !IS_ERR (fwnode->secondary);
include/linux/device.h +3 -0
@@ -964,6 +964,9 @@ void device_link_remove(void *consumer, struct device *supplier);void device_links_supplier_sync_state_pause (void );void device_links_supplier_sync_state_resume (void ); +extern __printf(3, 4) +int dev_err_probe(const struct device *dev, int err, const char *fmt, ...); + /* Create alias, so I can be autoloaded. */ #define MODULE_ALIAS_CHARDEV(major,minor) \ MODULE_ALIAS("char-major-" __stringify(major) "-" __stringify(minor))
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v8 2/5 driver core: add deferring probe reason to devices_deferred property
In reply to Andrzej Hajda/sys/kernel/debug/devices_deferred property contains list of deferred devices. This list does not contain reason why the driver deferred probe, the patch improves it.
The natural place to set the reason is dev_err_probe function introduced recently, ie. if dev_err_probe will be called with -EPROBE_DEFER instead of printk the message will be attached to a deferred device and printed when user reads devices_deferred property.
---
v8:
- improved commit message
--- drivers/base/base.h | 3 +++ drivers/base/core.c | 8 ++++++-- drivers/base/dd.c | 23 ++++++++++++++++++++++- 3 files changed, 31 insertions(+), 3 deletions(-)
drivers/base/base.h +3 -0
@@ -93,6 +93,7 @@ struct device_private {struct klist_node knode_class;struct list_head deferred_probe;struct device_driver *async_driver; +char *deferred_probe_reason;struct device *device; u8 dead:1; };
@@ -134,6 +135,8 @@ extern void device_release_driver_internal(struct device *dev,extern void driver_detach (struct device_driver *drv);extern int driver_probe_device (struct device_driver *drv,struct device *dev);extern void driver_deferred_probe_del (struct device *dev); +extern void device_set_deferred_probe_reson (const struct device *dev, +struct va_format *vaf);static inline int driver_match_device (struct device_driver *drv,struct device *dev) {
drivers/base/core.c +6 -2
@@ -3963,6 +3963,8 @@ define_dev_printk_level(_dev_info, KERN_INFO);* This helper implements common pattern present in probe functions for error * checking: print debug or error message depending if the error value is * -EPROBE_DEFER and propagate error upwards. +* In case of -EPROBE_DEFER it sets also defer probe reason, which can be +* checked later by reading devices_deferred debugfs attribute. * It replaces code sequence: * if (err != -EPROBE_DEFER) * dev_err(dev, ...);
@@ -3984,10 +3986,12 @@ int dev_err_probe(const struct device *dev, int err, const char *fmt, ...) vaf.fmt = fmt; vaf.va = &args; -if (err != -EPROBE_DEFER ) +if (err != -EPROBE_DEFER ) {dev_err (dev,"error %d: %pV" , err, &vaf); -else + }else { +device_set_deferred_probe_reson (dev, &vaf);dev_dbg (dev,"error %d: %pV" , err, &vaf); + }va_end (args);
drivers/base/dd.c +22 -1
@@ -27,6 +27,7 @@#include <linux/async.h> #include <linux/pm_runtime.h> #include <linux/pinctrl/devinfo.h> +#include <linux/slab.h> #include "base.h" #include "power/power.h"
@@ -136,6 +137,8 @@ void driver_deferred_probe_del(struct device *dev)if (!list_empty (&dev->p->deferred_probe)) {dev_dbg (dev,"Removed from deferred list\n" );list_del_init (&dev->p->deferred_probe); +kfree (dev->p->deferred_probe_reason); + dev->p->deferred_probe_reason =NULL ; }mutex_unlock (&deferred_probe_mutex); }
@@ -211,6 +214,23 @@ void device_unblock_probing(void)driver_deferred_probe_trigger (); } +/** +* device_set_deferred_probe_reson() - Set defer probe reason message for device +* @dev: the pointer to the struct device +* @vaf: the pointer to va_format structure with message +*/ +void device_set_deferred_probe_reson (const struct device *dev,struct va_format *vaf) +{ +const char *drv =dev_driver_string (dev); + +mutex_lock (&deferred_probe_mutex); + +kfree (dev->p->deferred_probe_reason); + dev->p->deferred_probe_reason =kasprintf (GFP_KERNEL ,"%s: %pV" , drv, vaf); + +mutex_unlock (&deferred_probe_mutex); +} +/* * deferred_devs_show() - Show the devices in the deferred probe pending list. */
@@ -221,7 +241,8 @@ static int deferred_devs_show(struct seq_file *s, void *data)mutex_lock (&deferred_probe_mutex);list_for_each_entry (curr, &deferred_probe_pending_list, deferred_probe) -seq_printf (s,"%s\n" ,dev_name (curr->device)); +seq_printf (s,"%s\t%s" ,dev_name (curr->device), + curr->device->p->deferred_probe_reason ?:"\n" );mutex_unlock (&deferred_probe_mutex);
Signature · 1 line
2.17.1
RE: [PATCH v8 2/5] driver core: add deferring probe reason to devices_deferred property
Quoted 122 lines
-----Original Message-----
From: dri-devel <[email protected]> On Behalf Of Andrzej Hajda
Sent: Friday, July 10, 2020 11:30 AM
To: Greg Kroah-Hartman <[email protected]>
Cc: Jernej Skrabec <[email protected]>; Rafael J. Wysocki <[email protected]>; Jonas Karlman <[email protected]>; Bartlomiej Zolnierkiewicz <[email protected]>; [email protected]; open list:DRM DRIVERS <[email protected]>; Russell King - ARM Linux <[email protected]>; Neil Armstrong <[email protected]>; Andrzej Hajda <[email protected]>; [email protected]; Mark Brown <[email protected]>; Laurent Pinchart <[email protected]>; linux-arm- [email protected]; Marek Szyprowski <[email protected]>
Subject: [PATCH v8 2/5] driver core: add deferring probe reason todevices_deferredproperty
/sys/kernel/debug/devices_deferredproperty contains list of deferred devices.
This list does not contain reason why the driver deferred probe, the patch improves it.
The natural place to set the reason isdev_err_probefunction introduced recently, ie. ifdev_err_probewill be called with -EPROBE_DEFER instead of printk the message will be attached to a deferred device and printed when user
readsdevices_deferredproperty.Signed-off-by Andrzej Hajda <[email protected]>Reviewed-by Mark Brown <[email protected]>Reviewed-by Javier Martinez Canillas <[email protected]>Reviewed-by Andy Shevchenko <[email protected]>Reviewed-by Rafael J. Wysocki <[email protected]>---
v8:
- improved commit message
---drivers/base/base.h | 3 +++ drivers/base/core.c | 8 ++++++-- drivers/base/dd.c | 23 ++++++++++++++++++++++- 3 files changed, 31 insertions(+), 3 deletions(-)drivers/base/base.h +1
-0@@ -93,6 +93,7 @@ struct device_private {struct klist_node knode_class;struct list_head deferred_probe;struct device_driver *async_driver; +char *deferred_probe_reason;struct device *device; u8 dead:1; };@@ -134,6 +135,8 @@ extern void device_release_driver_internal(structdevice *dev, extern void driver_detach(struct device_driver *drv);extern int
driver_probe_device(struct device_driver *drv, struct device *dev);
extern voiddriver_deferred_probe_del(struct device *dev);drivers/base/base.h +2
-0+extern void device_set_deferred_probe_reson (const struct device *dev, +struct va_format *vaf);static inline int driver_match_device(struct
device_driver*drv,
struct device *dev)
{drivers/base/core.c +0
-0@@ -3963,6 +3963,8 @@ define_dev_printk_level(_dev_info, KERN_INFO);* This helper implements common pattern present in probe functions for error
* checking: print debug or error message depending if the error value is
* -EPROBE_DEFER and propagate error upwards.
+ * In case of -EPROBE_DEFER it sets also defer probe reason, which can be
+ * checked later by readingdevices_deferreddebugfs attribute.
* It replaces code sequence:
* if (err != -EPROBE_DEFER)
*dev_err(dev, ...);drivers/base/core.c +4
-2@@ -3984,10 +3986,12 @@ int dev_err_probe(const struct device *dev, int err, const char *fmt, ...) vaf.fmt = fmt; vaf.va = &args; -if (err != -EPROBE_DEFER ) +if (err != -EPROBE_DEFER ) {dev_err (dev,"error %d: %pV" , err, &vaf); -else + }else { +device_set_deferred_probe_reson (dev, &vaf);dev_dbg (dev,"error %d: %pV" , err, &vaf); + }va_end (args);drivers/base/dd.c +5
-0@@ -27,6 +27,7 @@#include <linux/async.h> #include <linux/pm_runtime.h> #include <linux/pinctrl/devinfo.h> +#include <linux/slab.h> #include "base.h" #include "power/power.h" @@ -136,6 +137,8 @@ void driver_deferred_probe_del(struct device *dev)if (!list_empty (&dev->p->deferred_probe)) {dev_dbg (dev,"Removed from deferred list\n" );list_del_init (&dev->p->deferred_probe); +kfree (dev->p->deferred_probe_reason); + dev->p->deferred_probe_reason =NULL ; }mutex_unlock (&deferred_probe_mutex); }@@ -211,6 +214,23 @@ void device_unblock_probing(void)driver_deferred_probe_trigger (); } +/** +* device_set_deferred_probe_reson() - Set defer probe reason message
Quoted 5 lines
for device
+ * @dev: the pointer to the struct device
+ * @vaf: the pointer tova_formatstructure with message
+ */
+void device_set_deferred_probe_reson(const struct device *dev, struct
Is 'reson' supposed to be 'reason'?
Same spelling on the above kernel-doc, but the comment says "reason".
mike
Quoted 29 lines
va_format*vaf)drivers/base/dd.c +7
-0+{ +const char *drv =dev_driver_string (dev); + +mutex_lock (&deferred_probe_mutex); + +kfree (dev->p->deferred_probe_reason); + dev->p->deferred_probe_reason = kasprintf(GFP_KERNEL, "%s:%pV", drv, vaf);
drivers/base/dd.c +4
-0+ +mutex_unlock (&deferred_probe_mutex); +} +/*
*deferred_devs_show()- Show the devices in the deferred probe pending
list.
*/drivers/base/dd.c +2
-1@@ -221,7 +241,8 @@ static int deferred_devs_show(struct seq_file *s, void *data)mutex_lock (&deferred_probe_mutex);list_for_each_entry (curr, &deferred_probe_pending_list, deferred_probe) -seq_printf (s,"%s\n" ,dev_name (curr->device)); +seq_printf (s,"%s\t%s" ,dev_name (curr->device), + curr->device->p->deferred_probe_reason ?:"\n" );mutex_unlock(&deferred_probe_mutex);
Quoted 7 lines
--
2.17.1_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v8 3/5 drm/bridge/sii8620: fix resource acquisition error handling
In reply to Andrzej HajdaIn case of error during resource acquisition driver should print error message only in case it is not deferred probe, using dev_err_probe helper solves the issue. Moreover it records defer probe reason for debugging.
--- drivers/gpu/drm/bridge/sil-sii8620.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-)
drivers/gpu/drm/bridge/sil-sii8620.c +9 -12
@@ -2299,10 +2299,9 @@ static int sii8620_probe(struct i2c_client *client,INIT_LIST_HEAD (&ctx->mt_queue); ctx->clk_xtal =devm_clk_get (dev,"xtal" ); -if (IS_ERR (ctx->clk_xtal)) { -dev_err (dev,"failed to get xtal clock from DT\n" ); -return PTR_ERR (ctx->clk_xtal); - } +if (IS_ERR (ctx->clk_xtal)) +return dev_err_probe (dev,PTR_ERR (ctx->clk_xtal), +"failed to get xtal clock from DT\n" );if (!client->irq) {dev_err (dev,"no irq provided\n" );
@@ -2313,16 +2312,14 @@ static int sii8620_probe(struct i2c_client *client, sii8620_irq_thread,IRQF_TRIGGER_HIGH |IRQF_ONESHOT , "sii8620", ctx); -if (ret <0 ) { -dev_err (dev,"failed to install IRQ handler\n" ); -return ret; - } +if (ret <0 ) +return dev_err_probe (dev, ret, +"failed to install IRQ handler\n" ); ctx->gpio_reset =devm_gpiod_get (dev,"reset" ,GPIOD_OUT_HIGH ); -if (IS_ERR (ctx->gpio_reset)) { -dev_err (dev,"failed to get reset gpio from DT\n" ); -return PTR_ERR (ctx->gpio_reset); - } +if (IS_ERR (ctx->gpio_reset)) +return dev_err_probe (dev,PTR_ERR (ctx->gpio_reset), +"failed to get reset gpio from DT\n" ); ctx->supplies[0 ].supply ="cvcc10" ; ctx->supplies[1 ].supply ="iovcc18" ;
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v8 4/5 drm/bridge: lvds-codec: simplify error handling
In reply to Andrzej HajdaUsing dev_err_probe code has following advantages:
- shorter code,
- recorded defer probe reason for debugging,
- uniform error code logging.
--- drivers/gpu/drm/bridge/lvds-codec.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
drivers/gpu/drm/bridge/lvds-codec.c +3 -7
@@ -71,13 +71,9 @@ static int lvds_codec_probe(struct platform_device *pdev) lvds_codec->connector_type = (uintptr_t )of_device_get_match_data (dev); lvds_codec->powerdown_gpio =devm_gpiod_get_optional (dev,"powerdown" ,GPIOD_OUT_HIGH ); -if (IS_ERR (lvds_codec->powerdown_gpio)) { -int err =PTR_ERR (lvds_codec->powerdown_gpio); - -if (err != -EPROBE_DEFER ) -dev_err (dev,"powerdown GPIO failure: %d\n" , err); -return err; - } +if (IS_ERR (lvds_codec->powerdown_gpio)) +return dev_err_probe (dev,PTR_ERR (lvds_codec->powerdown_gpio), +"powerdown GPIO failure\n" );/* Locate the panel DT node. */ panel_node =of_graph_get_remote_node (dev->of_node,1 ,0 );
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v8 5/5 coccinelle: add script looking for cases where probe__err can be used
In reply to Andrzej HajdaThis is AD-HOC script, it should nt be merged.
--- probe_err.cocci | 247 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 247 insertions(+) create mode 100644 probe_err.cocci
probe_err.cocci new file +247 -0
@@ -0,0 +1,247 @@ +virtual context +virtual patch + +@initialize:python@ +@@ + +import re + +@@ +expression err, dev; +constant char [] fmt; +expression list args; +@@ + +- if (err != -EPROBE_DEFER) { dev_err(dev, fmt, args); } ++ dev_err_probe(dev, err, fmt, args); + +@@ +expression ptr, dev; +constant char [] fmt; +expression list args; +@@ + +- if (ptr != ERR_PTR(-EPROBE_DEFER)) { dev_err(dev, fmt, args); } ++ dev_err_probe(dev, PTR_ERR(ptr), fmt, args); + +@@ +expression e, dev; +identifier err; +identifier fget =~ "^(devm_)?(clk_get|gpiod_get|gpiod_get_optional|gpiod_get_index|gpiod_get_index_optional|regulator_get|regulator_get_optional|reset_control_get|reset_control_get_exclusive|reset_control_get_shared|phy_get|pinctrl_get|iio_channel_get|pwm_get)$"; +identifier flog =~ "^(dev_err|dev_warn|dev_info)$"; +expression list args; +@@ + e = fget(...); + if (IS_ERR(e)) { +( + err = PTR_ERR(e); +- flog(dev, args); ++ dev_err_probe(dev, err, args); +| +- flog(dev, args); ++ dev_err_probe(dev, PTR_ERR(e), args); +) + ... + } + +@@ +expression dev; +identifier err; +identifier fget =~ "^(devm_)?(request_irq|request_threaded_irq|regulator_bulk_get)$"; +identifier flog =~ "^(dev_err|dev_warn|dev_info)$"; +expression list args; +@@ + err = fget(...); + if ( \( err \| err < 0 \) ) { + ... +- flog(dev, args); ++ dev_err_probe(dev, err, args); + ... + } + +@catch_no_nl@ +expression dev, err; +constant char [] fmt !~ "\\n$"; +@@ + dev_err_probe(dev, err, fmt, ...) + +@script:python add_nl depends on catch_no_nl@ +fmt << catch_no_nl.fmt; +nfmt; +@@ +print "add_nl " + fmt +coccinelle.nfmt = fmt[:-1] + '\\n"'; + +@fix_no_nl depends on catch_no_nl@ +constant char [] catch_no_nl.fmt; +identifier add_nl.nfmt; +@@ +- fmt ++ nfmt + +@catch_fmt@ +expression err, dev; +expression fmt; +position p; +@@ + + dev_err_probe@p(dev, err, fmt, ..., \( (int)err \| err \) ) + +@script:python trim_fmt@ +fmt << catch_fmt.fmt; +new_fmt; +@@ + +tmp = fmt +tmp = re.sub('failed: irq request (IRQ: %d, error :%d)', 'irq request %d', tmp) +tmp = re.sub('Error %l?[di] ', 'Error ', tmp) +tmp = re.sub(' as irq = %d\\\\n', ', bad irq\\\\n', tmp) +tmp = re.sub('[:,]? ?((ret|err|with|error)[ =]?)?%l?[di]\.?\\\\n', '\\\\n', tmp) +tmp = re.sub(' ?\(((err|ret|error)\s*=?\s*)?%l?[diu]\)[!.]?\\\\n', '\\\\n', tmp) + +assert tmp != fmt, "cannot trim_fmt in: " + fmt +print "trim_fmt " + fmt + " " + tmp +coccinelle.new_fmt = tmp + +@fix_fmt@ +expression err, err1, dev; +expression fmt; +expression list l; +identifier trim_fmt.new_fmt; +position catch_fmt.p; +@@ + +- dev_err_probe@p(dev, err, fmt, l, err1) ++ dev_err_probe(dev, err, new_fmt, l) + +@err_ass1@ +identifier err; +expression dev, ptr; +expression list args; +@@ + +- err = PTR_ERR(ptr); +- dev_err_probe(dev, err, args); +- return ERR_PTR(err); ++ dev_err_probe(dev, PTR_ERR(ptr), args); ++ return ERR_CAST(ptr); + +@err_ass2@ +identifier err, f1, f2; +expression dev, e; +expression list args; +@@ +- err = PTR_ERR(e); +- dev_err_probe(dev, err, args); +( +| + f1(...); +| + f1(...); + f2(...); +) +- return err; ++ return dev_err_probe(dev, PTR_ERR(e), args); + +@@ +identifier err; +expression dev, e; +expression list args; +@@ + +- int err = e; +- dev_err_probe(dev, err, args); +- return err; ++ return dev_err_probe(dev, e, args); + +@@ +expression err, dev; +expression list args; +@@ + +- dev_err_probe(dev, err, args); +- return err; ++ return dev_err_probe(dev, err, args); + +@@ +expression err, dev, ptr; +expression list args; +@@ + +- dev_err_probe(dev, PTR_ERR(ptr), args); + err = PTR_ERR(ptr); ++ dev_err_probe(dev, err, args); + +@@ +expression e; +expression list args; +statement s, s1; +@@ + +// without s1 spatch generates extra empty line after s +- if (e) { return dev_err_probe(args); } else s s1 ++ if (e) return dev_err_probe(args); s s1 + +@@ +expression e; +expression list args; +@@ + +- if (e) { return dev_err_probe(args); } ++ if (e) return dev_err_probe(args); + +@@ +expression e, s, v; +expression list args; +@@ + +- if (e == v) { s; } else { return dev_err_probe(args); } ++ if (e != v) return dev_err_probe(args); s; + +@err_ass3@ +identifier err; +expression dev, ptr; +expression list args; +@@ + +- err = PTR_ERR_OR_ZERO(ptr); +- if (err) return dev_err_probe(dev, err, args); ++ if (IS_ERR(ptr)) return dev_err_probe(dev, PTR_ERR(ptr), args); + +@@ +expression dev, ptr; +expression list args; +@@ + +- DROP_probe_err(dev, PTR_ERR(ptr), args) ++ probe_err(dev, ptr, args) + +@@ +identifier err_ass1.err; +expression e; +identifier f =~ "^(dev_err_probe|probe_err_ptr)$"; +@@ +- \( int err; \| int err = e; \) + <+... when != err + f + ...+> + +@@ +identifier err_ass2.err; +expression e; +identifier f =~ "^(dev_err_probe|probe_err_ptr)$"; +@@ +- \( int err; \| int err = e; \) + <+... when != err + f + ...+> + +@@ +identifier err_ass3.err; +expression e; +identifier f =~ "^(dev_err_probe|probe_err_ptr)$"; +@@ +- \( int err; \| int err = e; \) + <+... when != err + f + ...+>
Signature · 1 line
2.17.1