Skip to contentSkip to conversation

drm/vkms: change the max cursor width/height

PATCH Applied Melissa Wen 2 participants 3 messages Jul 10, 2020 – Jul 12, 2020

Subsystems (3)
lore
Share & tools
lore

Melissa Wen

author reviewer
#0 lore raw

PATCH 1/1 drm/vkms: change the max cursor width/height

This change expands the coverage for the IGT kms_cursor_crc test, where the size varies between 64 and 512 for a square cursor. With this, in addition to the cursor 64x64, this patch enables the test of cursors with
sizes: 128x128, 256x256, and 512x512.

---
 drivers/gpu/drm/vkms/vkms_drv.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/vkms/vkms_drv.c +2 -0
index 1e8b2169d834..57a8a397d5e8 100644
@@ -133,6 +133,8 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev)
 	dev->mode_config.min_height = YRES_MIN;
 	dev->mode_config.max_width = XRES_MAX;
 	dev->mode_config.max_height = YRES_MAX;
+	dev->mode_config.cursor_width = 512;
+	dev->mode_config.cursor_height = 512;
 	dev->mode_config.preferred_depth = 24;
 	dev->mode_config.helper_private = &vkms_mode_config_helpers;
 
Signature · 6 lines
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/1
#1 lore raw

Hi Melissa,

First of all, thanks a lot for your patch! This is a nice change since it increases the code coverage.

Quoted 26 lines · Melissa Wen

This change expands the coverage for the IGT kms_cursor_crc test, where the size varies between 64 and 512 for a square cursor. With this, in addition to the cursor 64x64, this patch enables the test of cursors with
sizes: 128x128, 256x256, and 512x512.

---
 drivers/gpu/drm/vkms/vkms_drv.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/vkms/vkms_drv.c +2 -0
index 1e8b2169d834..57a8a397d5e8 100644
@@ -133,6 +133,8 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev)
 	dev->mode_config.min_height = YRES_MIN;
 	dev->mode_config.max_width = XRES_MAX;
 	dev->mode_config.max_height = YRES_MAX;
+	dev->mode_config.cursor_width = 512;
+	dev->mode_config.cursor_height = 512;
 	dev->mode_config.preferred_depth = 24;
 	dev->mode_config.helper_private = &vkms_mode_config_helpers;
 
Signature · 1 line
2.27.0
Signature · 2 lines
Rodrigo Siqueira
https://siqueira.tech
#2 lore raw

Applied to drm-misc-next.

Thanks

Quoted 38 lines · Rodrigo Siqueira

Hi Melissa,

First of all, thanks a lot for your patch! This is a nice change since it increases the code coverage.

Quoted 26 lines · Melissa Wen

This change expands the coverage for the IGT kms_cursor_crc test, where the size varies between 64 and 512 for a square cursor. With this, in addition to the cursor 64x64, this patch enables the test of cursors with
sizes: 128x128, 256x256, and 512x512.

---
 drivers/gpu/drm/vkms/vkms_drv.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/vkms/vkms_drv.c +2 -0
index 1e8b2169d834..57a8a397d5e8 100644
@@ -133,6 +133,8 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev)
 	dev->mode_config.min_height = YRES_MIN;
 	dev->mode_config.max_width = XRES_MAX;
 	dev->mode_config.max_height = YRES_MAX;
+	dev->mode_config.cursor_width = 512;
+	dev->mode_config.cursor_height = 512;
 	dev->mode_config.preferred_depth = 24;
 	dev->mode_config.helper_private = &vkms_mode_config_helpers;
 
Signature · 1 line
2.27.0
Signature · 2 lines
Rodrigo Siqueira
https://siqueira.tech
Signature · 2 lines
Rodrigo Siqueira
https://siqueira.tech

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel