Skip to contentSkip to conversation

arm: Add support for Qualcomm IPQ40xx family

PATCH New Robert Marko 3 participants 16 messages Jul 6, 2020 – Jul 29, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 arm: Add support for Qualcomm IPQ40xx family

This introduces initial support for the popular Qualcomm IPQ40x8 and IPQ40x9 WiSoC series.

IPQ40xx series have 4x Cortex A7 ARM-v7A cores. Supported are: IPQ4018, IPQ4019, IPQ4028 and IPQ4029.

IPQ40x8 and IPQ40x9 use the same cores, but differ in addressable RAM size (1GB for IPQ40x9 and 256MB for IPQ40x8) and supported peripherals (IPQ40x8 lacks RGMII, LCD controller and EMMC/SDHCI controllers).

IQP4028/IPQ4029 models differ from IPQ4018/IPQ4019 only by their rated temperatures rates with IPQ402X models being rated for wider temperature ranges.

Initially this supports:
* Simple clock driver (Only for UART1 now, will be extended)
* Pinctrl driver (Supports UARTX and GPIO now, will be extended)
* GPIOs already supported by msm_gpio driver with updates
* UARTs already supported by serial_msm driver with updates

Further peripherals will come in later patches.

---
 MAINTAINERS                                |   7 ++
 arch/arm/Kconfig                           |  13 ++
 arch/arm/Makefile                          |   1 +
 arch/arm/dts/qcom-ipq4019.dtsi             |  79 ++++++++++++
 arch/arm/mach-ipq40xx/Kconfig              |  15 +++
 arch/arm/mach-ipq40xx/Makefile             |   9 ++
 arch/arm/mach-ipq40xx/clock-ipq4019.c      |  64 ++++++++++
 arch/arm/mach-ipq40xx/include/mach/gpio.h  |  10 ++
 arch/arm/mach-ipq40xx/pinctrl-ipq4019.c    |  47 +++++++
 arch/arm/mach-ipq40xx/pinctrl-snapdragon.c | 137 +++++++++++++++++++++
 arch/arm/mach-ipq40xx/pinctrl-snapdragon.h |  30 +++++
 11 files changed, 412 insertions(+)
 create mode 100644 arch/arm/dts/qcom-ipq4019.dtsi
 create mode 100644 arch/arm/mach-ipq40xx/Kconfig
 create mode 100644 arch/arm/mach-ipq40xx/Makefile
 create mode 100644 arch/arm/mach-ipq40xx/clock-ipq4019.c
 create mode 100644 arch/arm/mach-ipq40xx/include/mach/gpio.h
 create mode 100644 arch/arm/mach-ipq40xx/pinctrl-ipq4019.c
 create mode 100644 arch/arm/mach-ipq40xx/pinctrl-snapdragon.c
 create mode 100644 arch/arm/mach-ipq40xx/pinctrl-snapdragon.h
MAINTAINERS +7 -0
index db8cecd5e0..e689d1ebeb 100644
@@ -216,6 +216,13 @@ F:	arch/arm/cpu/armv8/hisilicon
 F:	arch/arm/include/asm/arch-hi6220/
 F:	arch/arm/include/asm/arch-hi3660/
 
+ARM IPQ40XX
+M:	Robert Marko <[email protected]>
+M:	Luka Kovacic <[email protected]>
+M:	Luka Perkov <[email protected]>
+S:	Maintained
+F:	arch/arm/mach-ipq40xx/
+
 ARM MARVELL KIRKWOOD ARMADA-XP ARMADA-38X ARMADA-37XX ARMADA-7K/8K
 M:	Stefan Roese <[email protected]>
 S:	Maintained
arch/arm/Kconfig +13 -0
index 54d65f8488..3868c5c674 100644
@@ -763,6 +763,17 @@ config ARCH_INTEGRATOR
 	select PL01X_SERIAL
 	imply CMD_DM
 
+config ARCH_IPQ40XX
+	bool "Qualcomm IPQ40xx SoCs"
+	select CPU_V7A
+	select DM
+	select DM_GPIO
+	select DM_SERIAL
+	select PINCTRL
+	select CLK
+	select OF_CONTROL
+	imply CMD_DM
+
 config ARCH_KEYSTONE
 	bool "TI Keystone"
 	select CMD_POWEROFF
@@ -1772,6 +1783,8 @@ source "arch/arm/mach-highbank/Kconfig"
 
 source "arch/arm/mach-integrator/Kconfig"
 
+source "arch/arm/mach-ipq40xx/Kconfig"
+
 source "arch/arm/mach-k3/Kconfig"
 
 source "arch/arm/mach-keystone/Kconfig"
arch/arm/Makefile +1 -0
index 94eb50bf72..a20b82bc8d 100644
@@ -58,6 +58,7 @@ machine-$(CONFIG_ARCH_BCMSTB)		+= bcmstb
 machine-$(CONFIG_ARCH_DAVINCI)		+= davinci
 machine-$(CONFIG_ARCH_EXYNOS)		+= exynos
 machine-$(CONFIG_ARCH_HIGHBANK)		+= highbank
+machine-$(CONFIG_ARCH_IPQ40XX)		+= ipq40xx
 machine-$(CONFIG_ARCH_K3)		+= k3
 machine-$(CONFIG_ARCH_KEYSTONE)		+= keystone
 machine-$(CONFIG_ARCH_KIRKWOOD)		+= kirkwood
arch/arm/dts/qcom-ipq4019.dtsi new file +79 -0

79 lines not on this page · raw message

arch/arm/mach-ipq40xx/Kconfig new file +15 -0
new file mode 100644
index 0000000000..4eef80e935
@@ -0,0 +1,15 @@
+if ARCH_IPQ40XX
+
+config SYS_SOC
+	default "ipq40xx"
+
+config SYS_MALLOC_F_LEN
+	default 0x2000
+
+config SYS_TEXT_BASE
+	default 0x87300000
+
+config NR_DRAM_BANKS
+	default 1
+
+endif
arch/arm/mach-ipq40xx/Makefile new file +9 -0
new file mode 100644
index 0000000000..08a65b8854
@@ -0,0 +1,9 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Copyright (c) 2019 Sartura Ltd.
+#
+# Author: Robert Marko <[email protected]>
+
+obj-y += clock-ipq4019.o
+obj-y += pinctrl-snapdragon.o
+obj-y += pinctrl-ipq4019.o
arch/arm/mach-ipq40xx/clock-ipq4019.c new file +64 -0

64 lines not on this page · raw message

arch/arm/mach-ipq40xx/include/mach/gpio.h new file +10 -0
new file mode 100644
index 0000000000..a45747c0fe
@@ -0,0 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Empty gpio.h
+ *
+ * This file must stay as arch/arm/include/asm/gpio.h requires it.
+ *
+ * Copyright (c) 2019 Sartura Ltd.
+ *
+ * Author: Robert Marko <[email protected]>
+ */
arch/arm/mach-ipq40xx/pinctrl-ipq4019.c new file +47 -0

47 lines not on this page · raw message

arch/arm/mach-ipq40xx/pinctrl-snapdragon.c new file +137 -0

137 lines not on this page · raw message

arch/arm/mach-ipq40xx/pinctrl-snapdragon.h new file +30 -0
new file mode 100644
index 0000000000..2341a71349
@@ -0,0 +1,30 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Qualcomm Pin control
+ *
+ * (C) Copyright 2018 Ramon Fried <[email protected]>
+ *
+ */
+#ifndef _PINCTRL_SNAPDRAGON_H
+#define _PINCTRL_SNAPDRAGON_H
+
+#include <common.h>
+
+struct msm_pinctrl_data {
+	int pin_count;
+	int functions_count;
+	const char *(*get_function_name)(struct udevice *dev,
+					 unsigned int selector);
+	unsigned int (*get_function_mux)(unsigned int selector);
+	const char *(*get_pin_name)(struct udevice *dev,
+				    unsigned int selector);
+};
+
+struct pinctrl_function {
+	const char *name;
+	int val;
+};
+
+extern struct msm_pinctrl_data ipq4019_data;
+
+#endif
Signature · 1 line
2.26.2
#1 lore raw

PATCH 2/3 msm_serial: Read bit rate register value from DT

IPQ40xx and currently supported Snapdragon boards don't use the same one so enable reading it from DT, if no DT property is found default value is the same as the previous define.

---
 doc/device-tree-bindings/serial/msm-serial.txt | 4 ++++
 drivers/serial/serial_msm.c                    | 6 +++++-
 2 files changed, 9 insertions(+), 1 deletion(-)
doc/device-tree-bindings/serial/msm-serial.txt +4 -0
index 48b8428aca..dca995798a 100644
@@ -4,3 +4,7 @@ Required properties:
 - compatible: must be "qcom,msm-uartdm-v1.4"
 - reg: start address and size of the registers
 - clock: interface clock (must accept baudrate as a frequency)
+
+Optional properties:
+- bit-rate: Data Mover bit rate register value
+			(If not defined then 0xCC is used as default)
drivers/serial/serial_msm.c +5 -1
index 0cc1aadce4..a32de373d7 100644
@@ -61,6 +61,7 @@ struct msm_serial_data {
 	phys_addr_t base;
 	unsigned chars_cnt; /* number of buffered chars */
 	uint32_t chars_buf; /* buffered chars */
+	uint32_t clk_bit_rate; /* data mover mode bit rate register value */
 };
 
 static int msm_serial_fetch(struct udevice *dev)
@@ -190,7 +191,7 @@ static int msm_uart_clk_init(struct udevice *dev)
 
 static void uart_dm_init(struct msm_serial_data *priv)
 {
-	writel(UART_DM_CLK_RX_TX_BIT_RATE, priv->base + UARTDM_CSR);
+	writel(priv->clk_bit_rate, priv->base + UARTDM_CSR);
 	writel(0x0, priv->base + UARTDM_MR1);
 	writel(MSM_BOOT_UART_DM_8_N_1_MODE, priv->base + UARTDM_MR2);
 	writel(MSM_BOOT_UART_DM_CMD_RESET_RX, priv->base + UARTDM_CR);
@@ -223,6 +224,9 @@ static int msm_serial_ofdata_to_platdata(struct udevice *dev)
 	if (priv->base == FDT_ADDR_T_NONE)
 		return -EINVAL;
 
+	priv->clk_bit_rate = fdtdec_get_int(gd->fdt_blob, dev_of_offset(dev), 
+							"bit-rate", UART_DM_CLK_RX_TX_BIT_RATE);
+
 	return 0;
 }
 
Signature · 1 line
2.26.2
#2 lore raw

PATCH 2/3 msm_serial: Read bit rate register value from DT

Quoted 44 lines · Robert Marko

IPQ40xx and currently supported Snapdragon boards don't use the same one so enable reading it from DT, if no DT property is found default value is the same as the previous define.

---
 doc/device-tree-bindings/serial/msm-serial.txt | 4 ++++
 drivers/serial/serial_msm.c                    | 6 +++++-
 2 files changed, 9 insertions(+), 1 deletion(-)
doc/device-tree-bindings/serial/msm-serial.txt +4 -0
index 48b8428aca..dca995798a 100644
@@ -4,3 +4,7 @@ Required properties:
 - compatible: must be "qcom,msm-uartdm-v1.4"
 - reg: start address and size of the registers
 - clock: interface clock (must accept baudrate as a frequency)
+
+Optional properties:
+- bit-rate: Data Mover bit rate register value
+			(If not defined then 0xCC is used as default)
drivers/serial/serial_msm.c +2 -1
index 0cc1aadce4..a32de373d7 100644
@@ -61,6 +61,7 @@ struct msm_serial_data {
 	phys_addr_t base;
 	unsigned chars_cnt; /* number of buffered chars */
 	uint32_t chars_buf; /* buffered chars */
+	uint32_t clk_bit_rate; /* data mover mode bit rate register value */
 };
 
 static int msm_serial_fetch(struct udevice *dev)
@@ -190,7 +191,7 @@ static int msm_uart_clk_init(struct udevice *dev)
 
 static void uart_dm_init(struct msm_serial_data *priv)
 {
-	writel(UART_DM_CLK_RX_TX_BIT_RATE, priv->base + UARTDM_CSR);
+	writel(priv->clk_bit_rate, priv->base + UARTDM_CSR);
 	writel(0x0, priv->base + UARTDM_MR1);
 	writel(MSM_BOOT_UART_DM_8_N_1_MODE, priv->base + UARTDM_MR2);
 	writel(MSM_BOOT_UART_DM_CMD_RESET_RX, priv->base + UARTDM_CR);

drivers/serial/serial_msm.c static int msm_serial_ofdata_to_platdata(struct udevice *dev) · line 231

Quoted 8 lines
drivers/serial/serial_msm.c +3 -0
@@ -223,6 +224,9 @@ static int msm_serial_ofdata_to_platdata(struct udevice *dev)
 	if (priv->base == FDT_ADDR_T_NONE)
 		return -EINVAL;
 
+	priv->clk_bit_rate = fdtdec_get_int(gd->fdt_blob, dev_of_offset(dev), 
+							"bit-rate", UART_DM_CLK_RX_TX_BIT_RATE);
+
 	return 0;
 }

Adding the maintainer.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200710/ff60851b/attachment.sig>
#3 lore raw

PATCH 2/3 msm_serial: Read bit rate register value from DT

In reply to Robert Marko
Quoted 55 lines · Robert Marko

IPQ40xx and currently supported Snapdragon boards don't use the same one so enable reading it from DT, if no DT property is found default value is the same as the previous define.

---
 doc/device-tree-bindings/serial/msm-serial.txt | 4 ++++
 drivers/serial/serial_msm.c                    | 6 +++++-
 2 files changed, 9 insertions(+), 1 deletion(-)
doc/device-tree-bindings/serial/msm-serial.txt +4 -0
index 48b8428aca..dca995798a 100644
@@ -4,3 +4,7 @@ Required properties:
 - compatible: must be "qcom,msm-uartdm-v1.4"
 - reg: start address and size of the registers
 - clock: interface clock (must accept baudrate as a frequency)
+
+Optional properties:
+- bit-rate: Data Mover bit rate register value
+                       (If not defined then 0xCC is used as default)
drivers/serial/serial_msm.c +5 -2
index 0cc1aadce4..a32de373d7 100644
@@ -61,6 +61,7 @@ struct msm_serial_data {
        phys_addr_t base;
        unsigned chars_cnt; /* number of buffered chars */
        uint32_t chars_buf; /* buffered chars */
+       uint32_t clk_bit_rate; /* data mover mode bit rate register value */
 };
 
 static int msm_serial_fetch(struct udevice *dev)
@@ -190,7 +191,7 @@ static int msm_uart_clk_init(struct udevice *dev)
 
 static void uart_dm_init(struct msm_serial_data *priv)
 {
-       writel(UART_DM_CLK_RX_TX_BIT_RATE, priv->base + UARTDM_CSR);
+       writel(priv->clk_bit_rate, priv->base + UARTDM_CSR);
        writel(0x0, priv->base + UARTDM_MR1);
        writel(MSM_BOOT_UART_DM_8_N_1_MODE, priv->base + UARTDM_MR2);
        writel(MSM_BOOT_UART_DM_CMD_RESET_RX, priv->base + UARTDM_CR);
@@ -223,6 +224,9 @@ static int msm_serial_ofdata_to_platdata(struct udevice *dev)
        if (priv->base == FDT_ADDR_T_NONE)
                return -EINVAL;
 
+       priv->clk_bit_rate = fdtdec_get_int(gd->fdt_blob, dev_of_offset(dev),
+                                                       "bit-rate", UART_DM_CLK_RX_TX_BIT_RATE);
+
        return 0;
 }
 
--
Quoted 2 lines

2.26.2

#4 lore raw

PATCH 2/3 msm_serial: Read bit rate register value from DT

In reply to Robert Marko
Quoted 6 lines · Robert Marko

IPQ40xx and currently supported Snapdragon boards don't use the same one so enable reading it from DT, if no DT property is found default value is the same as the previous define.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200729/209e92ab/attachment.sig>
#5 lore raw

PATCH 3/3 msm_gpio: Add support for Qualcomm IPQ40xx

In reply to Robert Marko

Snapdragon SoCs and IPQ40xx use common TLMM IP,
so existing driver supports IPQ40xx as well.

So lets simply add a compatible for IPQ40xx.

---
 doc/device-tree-bindings/gpio/gpio-msm.txt | 3 ++-
 drivers/gpio/msm_gpio.c                    | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)
doc/device-tree-bindings/gpio/gpio-msm.txt +2 -1
index 966ce0af09..70a2c7f0dd 100644
@@ -1,7 +1,8 @@
 Qualcomm Snapdragon GPIO controller
 
 Required properties:
-- compatible : "qcom,msm8916-pinctrl" or "qcom,apq8016-pinctrl"
+- compatible : "qcom,msm8916-pinctrl", "qcom,apq8016-pinctrl" or
+				"qcom,ipq4019-pinctrl"
 - reg : Physical base address and length of the controller's registers.
 	This controller is called "Top Level Mode Multiplexing" in
 	Qualcomm documentation.
drivers/gpio/msm_gpio.c +1 -0
index ac5d20c1b9..868291eddb 100644
@@ -118,6 +118,7 @@ static int msm_gpio_ofdata_to_platdata(struct udevice *dev)
 static const struct udevice_id msm_gpio_ids[] = {
 	{ .compatible = "qcom,msm8916-pinctrl" },
 	{ .compatible = "qcom,apq8016-pinctrl" },
+	{ .compatible = "qcom,ipq4019-pinctrl" },
 	{ }
 };
 
Signature · 1 line
2.26.2
#6 lore raw

PATCH 3/3 msm_gpio: Add support for Qualcomm IPQ40xx

Quoted 30 lines · Robert Marko

Snapdragon SoCs and IPQ40xx use common TLMM IP,
so existing driver supports IPQ40xx as well.

So lets simply add a compatible for IPQ40xx.

---
 doc/device-tree-bindings/gpio/gpio-msm.txt | 3 ++-
 drivers/gpio/msm_gpio.c                    | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)
doc/device-tree-bindings/gpio/gpio-msm.txt +2 -1
index 966ce0af09..70a2c7f0dd 100644
@@ -1,7 +1,8 @@
 Qualcomm Snapdragon GPIO controller
 
 Required properties:
-- compatible : "qcom,msm8916-pinctrl" or "qcom,apq8016-pinctrl"
+- compatible : "qcom,msm8916-pinctrl", "qcom,apq8016-pinctrl" or
+				"qcom,ipq4019-pinctrl"
 - reg : Physical base address and length of the controller's registers.
 	This controller is called "Top Level Mode Multiplexing" in
 	Qualcomm documentation.
drivers/gpio/msm_gpio.c +0 -0
index ac5d20c1b9..868291eddb 100644

drivers/gpio/msm_gpio.c static int msm_gpio_ofdata_to_platdata(struct udevice *dev) · line 123

Quoted 6 lines
drivers/gpio/msm_gpio.c +1 -0
@@ -118,6 +118,7 @@ static int msm_gpio_ofdata_to_platdata(struct udevice *dev)
 static const struct udevice_id msm_gpio_ids[] = {
 	{ .compatible = "qcom,msm8916-pinctrl" },
 	{ .compatible = "qcom,apq8016-pinctrl" },
+	{ .compatible = "qcom,ipq4019-pinctrl" },
 	{ }
 };

Adding the maintainer.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200710/c6c5462a/attachment.sig>
#7 lore raw

PATCH 3/3 msm_gpio: Add support for Qualcomm IPQ40xx

In reply to Robert Marko
Quoted 39 lines · Robert Marko

Snapdragon SoCs and IPQ40xx use common TLMM IP,
so existing driver supports IPQ40xx as well.

So lets simply add a compatible for IPQ40xx.

---
 doc/device-tree-bindings/gpio/gpio-msm.txt | 3 ++-
 drivers/gpio/msm_gpio.c                    | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)
doc/device-tree-bindings/gpio/gpio-msm.txt +2 -1
index 966ce0af09..70a2c7f0dd 100644
@@ -1,7 +1,8 @@
 Qualcomm Snapdragon GPIO controller
 
 Required properties:
-- compatible : "qcom,msm8916-pinctrl" or "qcom,apq8016-pinctrl"
+- compatible : "qcom,msm8916-pinctrl", "qcom,apq8016-pinctrl" or
+                               "qcom,ipq4019-pinctrl"
 - reg : Physical base address and length of the controller's registers.
        This controller is called "Top Level Mode Multiplexing" in
        Qualcomm documentation.
drivers/gpio/msm_gpio.c +1 -1
index ac5d20c1b9..868291eddb 100644
@@ -118,6 +118,7 @@ static int msm_gpio_ofdata_to_platdata(struct udevice *dev)
 static const struct udevice_id msm_gpio_ids[] = {
        { .compatible = "qcom,msm8916-pinctrl" },
        { .compatible = "qcom,apq8016-pinctrl" },
+       { .compatible = "qcom,ipq4019-pinctrl" },
        { }
 };
 
--
Quoted 2 lines

2.26.2

#8 lore raw

PATCH 3/3 msm_gpio: Add support for Qualcomm IPQ40xx

In reply to Robert Marko
Quoted 7 lines · Robert Marko

Snapdragon SoCs and IPQ40xx use common TLMM IP,
so existing driver supports IPQ40xx as well.

So lets simply add a compatible for IPQ40xx.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200729/1cc92357/attachment.sig>
#9 lore raw

PATCH 1/3 arm: Add support for Qualcomm IPQ40xx family

In reply to Robert Marko
Quoted 21 lines · Robert Marko

This introduces initial support for the popular Qualcomm IPQ40x8 and IPQ40x9 WiSoC series.

IPQ40xx series have 4x Cortex A7 ARM-v7A cores. Supported are: IPQ4018, IPQ4019, IPQ4028 and IPQ4029.

IPQ40x8 and IPQ40x9 use the same cores, but differ in addressable RAM size (1GB for IPQ40x9 and 256MB for IPQ40x8) and supported peripherals (IPQ40x8 lacks RGMII, LCD controller and EMMC/SDHCI controllers).

IQP4028/IPQ4029 models differ from IPQ4018/IPQ4019 only by their rated temperatures rates with IPQ402X models being rated for wider temperature ranges.

Initially this supports:
* Simple clock driver (Only for UART1 now, will be extended)
* Pinctrl driver (Supports UARTX and GPIO now, will be extended)
* GPIOs already supported by msm_gpio driver with updates
* UARTs already supported by serial_msm driver with updates

Quoted 8 lines

Further peripherals will come in later patches.

---
 MAINTAINERS                                |   7 ++
 arch/arm/Kconfig                           |  13 ++
 arch/arm/Makefile                          |   1 +
 arch/arm/dts/qcom-ipq4019.dtsi             |  79 ++++++++++++

The goal with dts files (that aren't the -u-boot.dtsi ones of course) is that they come from upstream Linux. How far along is that with this SoC? Everything else here looks fine, thanks.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200710/4a734f2d/attachment.sig>
#10 lore raw

PATCH 1/3 arm: Add support for Qualcomm IPQ40xx family

Quoted 32 lines · Tom Rini
Quoted 21 lines · Robert Marko

This introduces initial support for the popular Qualcomm IPQ40x8 and IPQ40x9 WiSoC series.

IPQ40xx series have 4x Cortex A7 ARM-v7A cores. Supported are: IPQ4018, IPQ4019, IPQ4028 and IPQ4029.

IPQ40x8 and IPQ40x9 use the same cores, but differ in addressable RAM size (1GB for IPQ40x9 and 256MB for IPQ40x8) and supported peripherals (IPQ40x8 lacks RGMII, LCD controller and EMMC/SDHCI controllers).

IQP4028/IPQ4029 models differ from IPQ4018/IPQ4019 only by their rated temperatures rates with IPQ402X models being rated for wider temperature ranges.

Initially this supports:
* Simple clock driver (Only for UART1 now, will be extended)
* Pinctrl driver (Supports UARTX and GPIO now, will be extended)
* GPIOs already supported by msm_gpio driver with updates
* UARTs already supported by serial_msm driver with updates

Quoted 8 lines

Further peripherals will come in later patches.

---
 MAINTAINERS                                |   7 ++
 arch/arm/Kconfig                           |  13 ++
 arch/arm/Makefile                          |   1 +
 arch/arm/dts/qcom-ipq4019.dtsi             |  79 ++++++++++++
Quoted 4 lines

The goal with dts files (that aren't the -u-boot.dtsi ones of course) is that they come from upstream Linux. How far along is that with this SoC? Everything else here looks fine, thanks.

Well, I tried to keep as much as possible identical or really similar to the upstream Linux nodes,
but there are still differences due to how drivers are simplified.

Thanks

Quoted 4 lines

--
Tom

#11 lore raw

PATCH 1/3 arm: Add support for Qualcomm IPQ40xx family

Quoted 34 lines · Robert Marko
Quoted 32 lines · Tom Rini
Quoted 29 lines · Robert Marko

This introduces initial support for the popular Qualcomm IPQ40x8 and IPQ40x9 WiSoC series.

IPQ40xx series have 4x Cortex A7 ARM-v7A cores. Supported are: IPQ4018, IPQ4019, IPQ4028 and IPQ4029.

IPQ40x8 and IPQ40x9 use the same cores, but differ in addressable RAM size (1GB for IPQ40x9 and 256MB for IPQ40x8) and supported peripherals (IPQ40x8 lacks RGMII, LCD controller and EMMC/SDHCI controllers).

IQP4028/IPQ4029 models differ from IPQ4018/IPQ4019 only by their rated temperatures rates with IPQ402X models being rated for wider temperature ranges.

Initially this supports:
* Simple clock driver (Only for UART1 now, will be extended)
* Pinctrl driver (Supports UARTX and GPIO now, will be extended)
* GPIOs already supported by msm_gpio driver with updates
* UARTs already supported by serial_msm driver with updates

Further peripherals will come in later patches.

---
 MAINTAINERS                                |   7 ++
 arch/arm/Kconfig                           |  13 ++
 arch/arm/Makefile                          |   1 +
 arch/arm/dts/qcom-ipq4019.dtsi             |  79 ++++++++++++
Quoted 7 lines
Quoted 4 lines

The goal with dts files (that aren't the -u-boot.dtsi ones of course) is that they come from upstream Linux. How far along is that with this SoC? Everything else here looks fine, thanks.

Well, I tried to keep as much as possible identical or really similar to the upstream Linux nodes,
but there are still differences due to how drivers are simplified.

OK. You should be able to take the base upstream DTS files and between things like CONFIG_OF_REMOVE_PROPS / CONFIG_OF_SPL_REMOVE_PROPS and the automatically included -u-boot.dtsi files make any further changes that we have to make for space reasons or other tweaks.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200710/5523bb18/attachment.sig>
#12 lore raw

PATCH 1/3 arm: Add support for Qualcomm IPQ40xx family

Quoted 40 lines · Tom Rini
Quoted 38 lines · Robert Marko
Quoted 36 lines · Tom Rini
Quoted 21 lines · Robert Marko

This introduces initial support for the popular Qualcomm IPQ40x8 and IPQ40x9 WiSoC series.

IPQ40xx series have 4x Cortex A7 ARM-v7A cores. Supported are: IPQ4018, IPQ4019, IPQ4028 and IPQ4029.

IPQ40x8 and IPQ40x9 use the same cores, but differ in addressable RAM size (1GB for IPQ40x9 and 256MB for IPQ40x8) and supported peripherals (IPQ40x8 lacks RGMII, LCD controller and EMMC/SDHCI controllers).

IQP4028/IPQ4029 models differ from IPQ4018/IPQ4019 only by their rated temperatures rates with IPQ402X models being rated for wider temperature ranges.

Initially this supports:
* Simple clock driver (Only for UART1 now, will be extended)
* Pinctrl driver (Supports UARTX and GPIO now, will be extended)
* GPIOs already supported by msm_gpio driver with updates
* UARTs already supported by serial_msm driver with updates

Quoted 8 lines

Further peripherals will come in later patches.

---
 MAINTAINERS                                |   7 ++
 arch/arm/Kconfig                           |  13 ++
 arch/arm/Makefile                          |   1 +
 arch/arm/dts/qcom-ipq4019.dtsi             |  79 ++++++++++++

The goal with dts files (that aren't the -u-boot.dtsi ones of course) is that they come from upstream Linux. How far along is that with this SoC? Everything else here looks fine, thanks.

Quoted 8 lines
Quoted 3 lines

Well, I tried to keep as much as possible identical or really similar to the upstream Linux nodes,
but there are still differences due to how drivers are simplified.

OK. You should be able to take the base upstream DTS files and between things like CONFIG_OF_REMOVE_PROPS / CONFIG_OF_SPL_REMOVE_PROPS and the automatically included -u-boot.dtsi files make any further changes that we have to make for space reasons or other tweaks.

Well, I would actually like to avoid that kind of scenario as Linux DTS has way more nodes that U-boot will ever have.
I intentionally used the smallest possible amount of DT nodes that made sense.

Regards,
Robert

Quoted 3 lines

--
Tom

#13 lore raw

PATCH 1/3 arm: Add support for Qualcomm IPQ40xx family

Quoted 45 lines · Robert Marko
Quoted 44 lines · Tom Rini
Quoted 41 lines · Robert Marko
Quoted 32 lines · Tom Rini
Quoted 21 lines · Robert Marko

This introduces initial support for the popular Qualcomm IPQ40x8 and IPQ40x9 WiSoC series.

IPQ40xx series have 4x Cortex A7 ARM-v7A cores. Supported are: IPQ4018, IPQ4019, IPQ4028 and IPQ4029.

IPQ40x8 and IPQ40x9 use the same cores, but differ in addressable RAM size (1GB for IPQ40x9 and 256MB for IPQ40x8) and supported peripherals (IPQ40x8 lacks RGMII, LCD controller and EMMC/SDHCI controllers).

IQP4028/IPQ4029 models differ from IPQ4018/IPQ4019 only by their rated temperatures rates with IPQ402X models being rated for wider temperature ranges.

Initially this supports:
* Simple clock driver (Only for UART1 now, will be extended)
* Pinctrl driver (Supports UARTX and GPIO now, will be extended)
* GPIOs already supported by msm_gpio driver with updates
* UARTs already supported by serial_msm driver with updates

Quoted 8 lines

Further peripherals will come in later patches.

---
 MAINTAINERS                                |   7 ++
 arch/arm/Kconfig                           |  13 ++
 arch/arm/Makefile                          |   1 +
 arch/arm/dts/qcom-ipq4019.dtsi             |  79 ++++++++++++
Quoted 4 lines

The goal with dts files (that aren't the -u-boot.dtsi ones of course) is that they come from upstream Linux. How far along is that with this SoC? Everything else here looks fine, thanks.

Well, I tried to keep as much as possible identical or really similar to the upstream Linux nodes,
but there are still differences due to how drivers are simplified.

Quoted 8 lines
Quoted 4 lines

OK. You should be able to take the base upstream DTS files and between things like CONFIG_OF_REMOVE_PROPS / CONFIG_OF_SPL_REMOVE_PROPS and the automatically included -u-boot.dtsi files make any further changes that we have to make for space reasons or other tweaks.

Well, I would actually like to avoid that kind of scenario as Linux DTS has way more nodes that U-boot will ever have.
I intentionally used the smallest possible amount of DT nodes that made sense.

That's the opposite of the current intentions. But so long as all of the bindings you're using match, at the end of the day the additional maintenance is on you, so it's not a blocker for merging. Thanks for explaining.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200710/b7e2f890/attachment.sig>
#14 lore raw

PATCH 1/3 arm: Add support for Qualcomm IPQ40xx family

Bindings match upstream as much as possible, only exception is the pinctrl and GPIO drivers.
They are unified in Linux while they are separate in U-boot.

Thanks

Quoted 63 lines · Tom Rini
Quoted 45 lines · Robert Marko
Quoted 44 lines · Tom Rini
Quoted 41 lines · Robert Marko
Quoted 32 lines · Tom Rini
Quoted 21 lines · Robert Marko

This introduces initial support for the popular Qualcomm IPQ40x8 and IPQ40x9 WiSoC series.

IPQ40xx series have 4x Cortex A7 ARM-v7A cores. Supported are: IPQ4018, IPQ4019, IPQ4028 and IPQ4029.

IPQ40x8 and IPQ40x9 use the same cores, but differ in addressable RAM size (1GB for IPQ40x9 and 256MB for IPQ40x8) and supported peripherals (IPQ40x8 lacks RGMII, LCD controller and EMMC/SDHCI controllers).

IQP4028/IPQ4029 models differ from IPQ4018/IPQ4019 only by their rated temperatures rates with IPQ402X models being rated for wider temperature ranges.

Initially this supports:
* Simple clock driver (Only for UART1 now, will be extended)
* Pinctrl driver (Supports UARTX and GPIO now, will be extended)
* GPIOs already supported by msm_gpio driver with updates
* UARTs already supported by serial_msm driver with updates

Quoted 8 lines

Further peripherals will come in later patches.

---
 MAINTAINERS                                |   7 ++
 arch/arm/Kconfig                           |  13 ++
 arch/arm/Makefile                          |   1 +
 arch/arm/dts/qcom-ipq4019.dtsi             |  79 ++++++++++++
Quoted 4 lines

The goal with dts files (that aren't the -u-boot.dtsi ones of course) is that they come from upstream Linux. How far along is that with this SoC? Everything else here looks fine, thanks.

Well, I tried to keep as much as possible identical or really similar to the upstream Linux nodes,
but there are still differences due to how drivers are simplified.

Quoted 8 lines
Quoted 4 lines

OK. You should be able to take the base upstream DTS files and between things like CONFIG_OF_REMOVE_PROPS / CONFIG_OF_SPL_REMOVE_PROPS and the automatically included -u-boot.dtsi files make any further changes that we have to make for space reasons or other tweaks.

Well, I would actually like to avoid that kind of scenario as Linux DTS has way more nodes that U-boot will ever have.
I intentionally used the smallest possible amount of DT nodes that made sense.

That's the opposite of the current intentions. But so long as all of the bindings you're using match, at the end of the day the additional maintenance is on you, so it's not a blocker for merging. Thanks for explaining.

--
Tom

#15 lore raw

PATCH 1/3 arm: Add support for Qualcomm IPQ40xx family

In reply to Robert Marko
Quoted 21 lines · Robert Marko

This introduces initial support for the popular Qualcomm IPQ40x8 and IPQ40x9 WiSoC series.

IPQ40xx series have 4x Cortex A7 ARM-v7A cores. Supported are: IPQ4018, IPQ4019, IPQ4028 and IPQ4029.

IPQ40x8 and IPQ40x9 use the same cores, but differ in addressable RAM size (1GB for IPQ40x9 and 256MB for IPQ40x8) and supported peripherals (IPQ40x8 lacks RGMII, LCD controller and EMMC/SDHCI controllers).

IQP4028/IPQ4029 models differ from IPQ4018/IPQ4019 only by their rated temperatures rates with IPQ402X models being rated for wider temperature ranges.

Initially this supports:
* Simple clock driver (Only for UART1 now, will be extended)
* Pinctrl driver (Supports UARTX and GPIO now, will be extended)
* GPIOs already supported by msm_gpio driver with updates
* UARTs already supported by serial_msm driver with updates

Quoted 3 lines

Further peripherals will come in later patches.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200729/9e7558b3/attachment.sig>