Skip to contentSkip to conversation

staging: rtl8723bs: core: Using comparison to true is error prone

PATCH Superseded John Oldman 2 participants 3 messages Jul 10, 2020 – Jul 11, 2020 Staging

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: core: Using comparison to true is error prone

clear below issues reported by checkpatch.pl:

CHECK: Using comparison to true is error prone

---
 drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ieee80211.c +3 -2
index ca98274ae390..d9bdd4fb9dc3 100644
@@ -363,8 +363,9 @@ int rtw_generate_ie(struct registry_priv *pregistrypriv)
 	}
 
 	/* HT Cap. */
-	if (((pregistrypriv->wireless_mode&WIRELESS_11_5N) || (pregistrypriv->wireless_mode&WIRELESS_11_24N))
-		&& (pregistrypriv->ht_enable == true)) {
+	if (((pregistrypriv->wireless_mode & WIRELESS_11_5N)
+	      || (pregistrypriv->wireless_mode & WIRELESS_11_24N))
+	      && (pregistrypriv->ht_enable)) {
 		/* todo: */
 	}
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 14 lines · John Oldman

clear below issues reported by checkpatch.pl:

CHECK: Using comparison to true is error prone

---
 drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ieee80211.c +0 -0
index ca98274ae390..d9bdd4fb9dc3 100644

drivers/staging/rtl8723bs/core/rtw_ieee80211.c int rtw_generate_ie(struct registry_priv *pregistrypriv) · line 368

Quoted 8 lines
drivers/staging/rtl8723bs/core/rtw_ieee80211.c +3 -2
@@ -363,8 +363,9 @@ int rtw_generate_ie(struct registry_priv *pregistrypriv)
 	}
 
 	/* HT Cap. */
-	if (((pregistrypriv->wireless_mode&WIRELESS_11_5N) || (pregistrypriv->wireless_mode&WIRELESS_11_24N))
-		&& (pregistrypriv->ht_enable == true)) {
+	if (((pregistrypriv->wireless_mode & WIRELESS_11_5N)
+	      || (pregistrypriv->wireless_mode & WIRELESS_11_24N))
+	      && (pregistrypriv->ht_enable)) {
		 ^			  ^

The enclosing parentheses are unnecessary.

Also, if you run checkpatch.pl on your patch, you'll see the following:

CHECK: Logical continuations should be on the previous line #12: FILE: drivers/staging/rtl8723bs/core/rtw_ieee80211.c:367:
+ if (((pregistrypriv->wireless_mode & WIRELESS_11_5N)
+ || (pregistrypriv->wireless_mode & WIRELESS_11_24N))

CHECK: Logical continuations should be on the previous line #13: FILE: drivers/staging/rtl8723bs/core/rtw_ieee80211.c:368:
+ || (pregistrypriv->wireless_mode & WIRELESS_11_24N))
+ && (pregistrypriv->ht_enable)) {

It'd be nice to fix the above, too. :)

--
Gustavo

Quoted 4 lines
drivers/staging/rtl8723bs/core/rtw_ieee80211.c +0 -0
 		/* todo: */
 	}
 
#2 lore raw

Hi Gustavo
Thanks for the feedback.
I'll re-submit the patch.
Many thanks
john

Quoted 51 lines · Gustavo A. R. Silva
Quoted 14 lines · John Oldman

clear below issues reported by checkpatch.pl:

CHECK: Using comparison to true is error prone

---
 drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ieee80211.c +0 -0
index ca98274ae390..d9bdd4fb9dc3 100644

drivers/staging/rtl8723bs/core/rtw_ieee80211.c int rtw_generate_ie(struct registry_priv *pregistrypriv) · line 368

Quoted 8 lines
drivers/staging/rtl8723bs/core/rtw_ieee80211.c +3 -2
@@ -363,8 +363,9 @@ int rtw_generate_ie(struct registry_priv *pregistrypriv)
 	}
 
 	/* HT Cap. */
-	if (((pregistrypriv->wireless_mode&WIRELESS_11_5N) || (pregistrypriv->wireless_mode&WIRELESS_11_24N))
-		&& (pregistrypriv->ht_enable == true)) {
+	if (((pregistrypriv->wireless_mode & WIRELESS_11_5N)
+	      || (pregistrypriv->wireless_mode & WIRELESS_11_24N))
+	      && (pregistrypriv->ht_enable)) {
		 ^			  ^

The enclosing parentheses are unnecessary.

Also, if you run checkpatch.pl on your patch, you'll see the following:

CHECK: Logical continuations should be on the previous line #12: FILE: drivers/staging/rtl8723bs/core/rtw_ieee80211.c:367:

drivers/staging/rtl8723bs/core/rtw_ieee80211.c +2 -0
+	if (((pregistrypriv->wireless_mode & WIRELESS_11_5N)
+	      || (pregistrypriv->wireless_mode & WIRELESS_11_24N))

CHECK: Logical continuations should be on the previous line #13: FILE: drivers/staging/rtl8723bs/core/rtw_ieee80211.c:368:

drivers/staging/rtl8723bs/core/rtw_ieee80211.c +2 -0
+	      || (pregistrypriv->wireless_mode & WIRELESS_11_24N))
+	      && (pregistrypriv->ht_enable)) {

It'd be nice to fix the above, too. :)

--
Gustavo

Quoted 4 lines
drivers/staging/rtl8723bs/core/rtw_ieee80211.c +0 -0
 		/* todo: */
 	}